New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve PrinterHelper (less duplication, more encapsulation) #1332

Merged
merged 1 commit into from May 29, 2017

Conversation

Projects
None yet
3 participants
@monperrus
Collaborator

monperrus commented May 29, 2017

No description provided.

@spoon-bot

This comment has been minimized.

Show comment
Hide comment
@spoon-bot

spoon-bot May 29, 2017

Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170529.142408-132

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 1.

Change 1

Name Element
Old method void spoon.reflect.visitor.printer.PrinterHelper::insertLine()
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking
Collaborator

spoon-bot commented May 29, 2017

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170529.142408-132

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 1.

Change 1

Name Element
Old method void spoon.reflect.visitor.printer.PrinterHelper::insertLine()
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking

@surli surli merged commit ea0bde3 into INRIA:master May 29, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 81.806%
Details
pull_request-INRIA-spoon-master-docker exec in /tmp/tmp74radahh
Details
@spoon-bot

This comment has been minimized.

Show comment
Hide comment
@spoon-bot

spoon-bot May 29, 2017

Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170529.151252-133

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 1.

Change 1

Name Element
Old method void spoon.reflect.visitor.printer.PrinterHelper::insertLine()
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking
Collaborator

spoon-bot commented May 29, 2017

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170529.151252-133

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 1.

Change 1

Name Element
Old method void spoon.reflect.visitor.printer.PrinterHelper::insertLine()
New none
Code java.method.removed
Description Method was removed.
Breaking source: breaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment