fix: test and fix untested method createNewClass() #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
force-pushed
the
refactor-newClass
branch
from
67a4924
to
a0ab3bd
Compare
surli
reviewed
Apr 10, 2019
| */ | ||
| public <T> CtNewClass<T> createNewClass(CtTypeReference<T> type, CtClass<?> anonymousClass, CtExpression<?>...parameters) { | ||
| public <T> CtNewClass<T> createNewClass(CtType<T> superClass, CtExpression<?>...parameters) { |
There was a problem hiding this comment.
I'm surprised that revapi is not complaining there?
There was a problem hiding this comment.
I'm not a huge fan on this signature change: it's really a potential breaking change for users. Why don't you keep the existing one and add a new one?
There was a problem hiding this comment.
This method 1) was useless and incorrect 1) is not used anywhere (consequence of 1))
So I'd say there is no need to keep this technical debt.
|
gakoci/revapi is dead since mid january :-)
|
|
ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.