Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate ModifiersTest to JUnit 5 #4545

Merged
merged 2 commits into from
Jan 22, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testMethodWithVarargsDoesNotBecomeTransient
  • Replaced junit 4 test annotation with junit 5 test annotation in testCtModifiableAddRemoveReturnCtModifiable
  • Replaced junit 4 test annotation with junit 5 test annotation in testSetVisibility
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetModifiersHelpers
  • Replaced junit 4 test annotation with junit 5 test annotation in testClearModifiersByEmptySet
  • Replaced junit 4 test annotation with junit 5 test annotation in testClearModifiersByNull

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testMethodWithVarargsDoesNotBecomeTransient
  • Transformed junit4 assert to junit 5 assertion in testCtModifiableAddRemoveReturnCtModifiable
  • Transformed junit4 assert to junit 5 assertion in testSetVisibility
  • Transformed junit4 assert to junit 5 assertion in testGetModifiersHelpers
  • Transformed junit4 assert to junit 5 assertion in checkCtModifiableHelpersAssertion
  • Transformed junit4 assert to junit 5 assertion in testClearModifiersByEmptySet
  • Transformed junit4 assert to junit 5 assertion in testClearModifiersByNull

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testMethodWithVarargsDoesNotBecomeTransient
Replaced junit 4 test annotation with junit 5 test annotation in testCtModifiableAddRemoveReturnCtModifiable
Replaced junit 4 test annotation with junit 5 test annotation in testSetVisibility
Replaced junit 4 test annotation with junit 5 test annotation in testGetModifiersHelpers
Replaced junit 4 test annotation with junit 5 test annotation in testClearModifiersByEmptySet
Replaced junit 4 test annotation with junit 5 test annotation in testClearModifiersByNull
Transformed junit4 assert to junit 5 assertion in testMethodWithVarargsDoesNotBecomeTransient
Transformed junit4 assert to junit 5 assertion in testCtModifiableAddRemoveReturnCtModifiable
Transformed junit4 assert to junit 5 assertion in testSetVisibility
Transformed junit4 assert to junit 5 assertion in testGetModifiersHelpers
Transformed junit4 assert to junit 5 assertion in checkCtModifiableHelpersAssertion
Transformed junit4 assert to junit 5 assertion in testClearModifiersByEmptySet
Transformed junit4 assert to junit 5 assertion in testClearModifiersByNull
@monperrus monperrus merged commit 6c8d8c2 into INRIA:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants