review: fix: Keep implicit status for more implicit enclosing class references #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
force-pushed
the
fix/more-implicit-enclosing
branch
from
4fc4f1f
to
25e9d0c
Compare
I-Al-Istannen
changed the title
I-Al-Istannen
force-pushed
the
fix/more-implicit-enclosing
branch
from
25e9d0c
to
3c7ce22
Compare
MartinWitt
approved these changes
Sep 5, 2023
|
LGTM |
SirYwell
approved these changes
Sep 9, 2023
|
Thanks, @SirYwell, for reminding me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still imperfect, but I don't feel like rewriting
getQualifiedTypeReferenceright now.