Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MineralResources sourceReference problem #41

Closed
CLinGBA opened this issue Oct 4, 2021 · 10 comments · Fixed by #56
Closed

MineralResources sourceReference problem #41

CLinGBA opened this issue Oct 4, 2021 · 10 comments · Fixed by #56
Labels
breaking change The change proposal prevents backward compatibility of the schema endorsed The change proposal is endorsed by the MIG.
Milestone

Comments

@CLinGBA
Copy link

CLinGBA commented Oct 4, 2021

Dear all,

There seems to be an issue with EarthResource and the sourceReference element in MineralResources, defined in the UML as: sourceReference: DocumentCitation[1..*]

In the XSD, the reference to the DocumentCitation dataType gets lost (only mentioned in the appinfo tag), while the xlinks provided via the gml:AssociationAttributeGroup aren't of help as DocumentCitation is a dataType, thus cannot be referenced.

This is an issue, as we thus cannot provide this mandatory information. XSD Snippet showing the issue below

<element name="sourceReference" nillable="true" maxOccurs="unbounded"> <annotation> <documentation>-- Definition -- The source or reference for the Earth Resource.</documentation> <appinfo> <targetElement xmlns="http://www.opengis.net/gml/3.2">base2:DocumentCitation</targetElement> </appinfo> </annotation> <complexType> <complexContent> <extension base="gml:AbstractMemberType"> <sequence/> <attributeGroup ref="gml:AssociationAttributeGroup"/> </extension> </complexContent> </complexType> </element>

Many thanks,

Christian

@JohannaOtt
Copy link

Hi Christian,

There was a discussion on this in the INSPIRE Forum back in the days https://wayback.archive-it.org/12090/20210123101226/https://inspire.ec.europa.eu/forum/discussion/view/269595/mineraloccurencesourcereference-does-not-allow-inline-creation-of-documentcitation
Kathi wanted to forward the issue to the JRC.

All the best

Johanna

@sMorrone
Copy link
Collaborator

sMorrone commented Oct 4, 2021

Dear @CLinGBA
bugs in current version of INSPIRE schemas (as well as change proposals) should now be reported via the issue tracker of the application-schemas github repository using the New issue template.
Once this is done, the change proposal (in this case the bug-fixing proposal) will follow the specific governance and release process for INSPIRE schemas described in this document and, if endorsed, will be carried out and lead to a new schema version.
I am now moving this issue to abovementioned application-schemas repository.
In order to help the governance and release process move forward, please copy/paste below and fill in the change proposal template to the best of your knowledge.
Thank you

@sMorrone sMorrone transferred this issue from INSPIRE-MIF/helpdesk Oct 4, 2021
@KathiSchleidt
Copy link

MR_EarthResource_sourceReference_doesn't_link_to_DocumentCitation

Change proposal description

Update the XSD so that the reference to the DocumentCitation dataType is contained in sourceReference of EarthResource and derived types as foreseen in the UML model

Issue faced

As the sequence provided under sourceReference doesn't contain DocumentCitation, this information cannot be provided inline.
In the XSD, there is a gml:AssociationAttributeGroup providing xlinks, however, DocumentCitation is a dataType, thus cannot be referenced.
As sourceReference is mandatory, this means it is not possible to provide valid data in featureTypes based on EarthResource

Expected behaviour

It should be possible to provide a DocumentCitation inline as foreseen by the model

Current behaviour

It is not possible to provide a DocumentCitation inline as foreseen by the model

Steps to reproduce

Try and provide EarthResource including sourceReference

Proposed solution

Fix the empty sequence currently under sourceReference by adding DocumentCitation - currently just <sequence/>

Technical details

`

<annotation> 

    <documentation>-- Definition -- The source or reference for the Earth Resource.</documentation> 

    <appinfo> <targetElement xmlns="http://www.opengis.net/gml/3.2">base2:DocumentCitation</targetElement> </appinfo> 

</annotation> 

<complexType> 

    <complexContent> 

        <extension base="gml:AbstractMemberType"> 

            <sequence/> 

            <attributeGroup ref="gml:AssociationAttributeGroup"/> 

        </extension> 

    </complexContent> 

</complexType> 

`

Additional information

Proposal reason

This is a bug, and hinders provision of valid information utilizing the EarthResource featureType

Addressed schema

MineralResources

Impact on INSPIRE TG / IR

Makes it possible to fulfill the TG/IR Requirements

Change proposer

Geologische Bundesanstalt (GBA) (Austrian Geological Agency), supported by DataCove e.U.

@heidivanparys heidivanparys added this to the 2022.2 milestone Oct 29, 2021
@sMorrone
Copy link
Collaborator

sMorrone commented Dec 6, 2021

Dear @CLinGBA , @KathiSchleidt
could one of you provide a pull request with changes to the schema?
Thank you

@KathiSchleidt
Copy link

Hiya,
now fixed the schema, replaced

<sequence minOccurs="0">
	<element ref="swe:Category"/>
</sequence>

with

<sequence minOccurs="0">
	<element ref="base2:DocumentCitation"/>
</sequence>

Does the trick

@sMorrone
Copy link
Collaborator

@kathi,
I think you meant you replaced
<sequence/>
i.e the empty sequence tag with

<sequence minOccurs="0">
  <element ref="base2:DocumentCitation"/>
</sequence>

am I right?

@KathiSchleidt
Copy link

Sorry, my mistake! Thanks for the correction

@sMorrone
Copy link
Collaborator

Subgroup Meeting 15-12-2021: Change proposal is approved

@sMorrone sMorrone added the for INSPIRE CT The change proposal is to be assessed by the INSPIRE CT. label Dec 15, 2021
sMorrone added a commit that referenced this issue Dec 23, 2021
Added data type DocumentCitation to definition of sourceReference property. See issue #41
@MarcoMinghini
Copy link
Contributor

The INSPIRE CT approved the change proposal during today's meeting. In the next step, the proposal will be moved to the MIG for the final endorsement.

@MarcoMinghini MarcoMinghini added for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. and removed for INSPIRE CT The change proposal is to be assessed by the INSPIRE CT. labels Feb 8, 2022
@fabiovinci fabiovinci linked a pull request Mar 11, 2022 that will close this issue
@sMorrone sMorrone added the breaking change The change proposal prevents backward compatibility of the schema label Mar 31, 2022
@sMorrone
Copy link
Collaborator

sMorrone commented Apr 4, 2022

During the joint MIG/MIG-T meeting held on 31/03-01/04/2022, the proposal was endorsed.
More details in the meeting minutes on the 69th MIG-T meeting page

@sMorrone sMorrone added endorsed The change proposal is endorsed by the MIG. and removed for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. labels Apr 4, 2022
fabiovinci added a commit that referenced this issue Aug 2, 2022
* Update MineralResourcesCore

Added data type DocumentCitation to definition of sourceReference property. See issue #41

* Add changelog and version

Add a comment with changelog and update the version

Co-authored-by: Fabio Vinci <f.vinci@epsilon-italia.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The change proposal prevents backward compatibility of the schema endorsed The change proposal is endorsed by the MIG.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants