Cyclic dependency in `FieldLayout.hpp`

[simon-schlepphorst]

Including Ippl.h in FieldLayout.hpp creates a cyclic dependency. This should be avoided altogether!

ippl/src/Ippl.h

Line 50 in c2ec8aa

#include "IpplCore.h"

ippl/src/IpplCore.h

Line 22 in c2ec8aa

#include "FieldLayout/FieldLayout.h"

ippl/src/FieldLayout/FieldLayout.h

Line 402 in c2ec8aa

#include "FieldLayout/FieldLayout.hpp"

ippl/src/FieldLayout/FieldLayout.hpp

Line 8 in c2ec8aa

#include "Ippl.h"

[simon-schlepphorst]

List of additional files within src/ that include Ippl.h:

• creating a loop:
  

  ippl/src/Field/BareField.hpp

  Line 5 in 246c01f

  #include "Ippl.h"

  ippl/src/FieldLayout/SubFieldLayout.hpp

  Line 7 in c2ec8aa

  #include "Ippl.h"

  ippl/src/Particle/ParticleAttrib.hpp

  Line 16 in c2ec8aa

  #include "Ippl.h"

• not directly creating a loop:
  

  ippl/src/Manager/BaseManager.h

  Line 4 in c2ec8aa

  #include "Ippl.h"

• potentially including to much:
  

  ippl/src/Communicate/Environment.cpp

  Line 4 in c2ec8aa

  #include "Ippl.h"

  ippl/src/Communicate/Buffers.cpp

  Line 23 in c2ec8aa

  #include "Ippl.h"

  ippl/src/Utility/Inform.cpp

  Line 27 in c2ec8aa

  #include "Ippl.h"

  ippl/src/Utility/IpplInfo.cpp

  Line 5 in c2ec8aa

  #include "Ippl.h"

  ippl/src/Utility/IpplTimings.cpp

  Line 25 in c2ec8aa

  #include "Ippl.h"

• valid case:
  

  ippl/src/Ippl.cpp

  Line 6 in c2ec8aa

  #include "Ippl.h"