Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dadosabertos.rnp.br #42

Closed
pdurbin opened this issue Dec 18, 2019 · 15 comments · Fixed by #53
Closed

add dadosabertos.rnp.br #42

pdurbin opened this issue Dec 18, 2019 · 15 comments · Fixed by #53
Labels

Comments

@pdurbin
Copy link
Member

pdurbin commented Dec 18, 2019

http://dadosabertos.rnp.br has been added to the old map and should be added to the new map as well.

@pdurbin
Copy link
Member Author

pdurbin commented Jan 14, 2020

As I mentioned in standup, when we switched https://dataverse.org from the old miniverse map to the new leaflet map we lost an installation in Brazil ( http://dadosabertos.rnp.br ), dropping from 53 to 52.

I know that @shlake and @jggautier and others have updated the data.json file in this repo before by running the Python script but @djbrooke would like to give it a try so please let him pick up this issue as time allows.

@djbrooke here are the docs (thank you @shlake for working on these!):

@djbrooke djbrooke added the small label Jan 15, 2020
@djbrooke djbrooke moved this from IQSS Sprint 1/15 - 2/5 to IQSS Team Dev 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jan 30, 2020
@djbrooke djbrooke self-assigned this Jan 30, 2020
@djbrooke
Copy link
Contributor

@jggautier @pdurbin @shlake I took a quick look at the docs and I could probably figure it out but I want to better understand the workflow first. Does all of this process just serve to update the https://github.com/IQSS/dataverse-installations/blob/master/data/data.json file which I assume powers the map? If that's the case, why not just make PRs directly against that file?

@pdurbin
Copy link
Member Author

pdurbin commented Jan 31, 2020

@djbrooke sounds like we should document the workflow. I just created an issue for this: #50.

@djbrooke djbrooke moved this from IQSS Team Dev 💻 to IQSS Sprint 1/15 - 2/5 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 3, 2020
@djbrooke djbrooke removed their assignment Feb 3, 2020
@djbrooke
Copy link
Contributor

djbrooke commented Feb 3, 2020

I worked on this a little on Friday and wasn't able to get it going, and I have a busy week and I'm not able to work on this. :( Someone else should pick it up if they are interested and have capacity.

@jggautier
Copy link
Contributor

jggautier commented Feb 3, 2020

I tried running the script and got a key error:

Screen Shot 2020-02-03 at 1 40 49 PM

In the miniverse database, that installation is NOT marked as active (waiting to hear back from the admin (https://help.hmdc.harvard.edu/Ticket/Display.html?id=283158)).

I'm not sure what part of the final JSON file the script is complaining about. The two spreadsheets didn't have info about this installation, dataverse.arch.be, so I added Country (and Continent) to one of the spreadsheets and reran the script, but I get the same key error.

Then I saw these lines in update_data.py, in the "# Data from miniverse map application" section where it looks like it's getting data from miniverse:

i['country'] = mydict[i['hostname']]['country']
i['continent'] = mydict[i['hostname']]['continent']

Is the script expecting the miniverse map application to store info about country and continent? It doesn't:

Screen Shot 2020-02-03 at 2 10 26 PM

@pdurbin
Copy link
Member Author

pdurbin commented Feb 4, 2020

@donsizemore I think @shlake is at an NIH meeting. Do you have capacity to work on this and #49?

@pdurbin
Copy link
Member Author

pdurbin commented Feb 4, 2020

@tcoupin or @lwo you are also welcome to help with this and #49 if you'd like. I think you all have access to update the spreadsheets linked from the README. If not, please feel free to request edit access! 😄

@shlake
Copy link
Contributor

shlake commented Feb 4, 2020

@pdurbin I can try to fix this. Sorry I haven't been much help lately. I'm at NIH next week.

@pdurbin
Copy link
Member Author

pdurbin commented Feb 4, 2020

@shlake thank you! Please let me know if you need anything! I'll be in chat, etc.

@pdurbin pdurbin added this to To do list for shlake in pdurbin Feb 4, 2020
@shlake
Copy link
Contributor

shlake commented Feb 4, 2020

@pdurbin there are 3 pull requests that I will look at and merge and then start on this one and #49

@pdurbin
Copy link
Member Author

pdurbin commented Feb 4, 2020

@shlake perfect! Thank you!!

@shlake
Copy link
Contributor

shlake commented Feb 4, 2020

@jggautier the script is now working, problem was with the uclovain site. It was on the crowd source doc & old map, BUT not on the IQSS spreadsheet. Once I closed #49 things worked.

@pdurbin BUT am not adding dadosabertos.rnp.br (this issue) just yet. That URL does not resolve.

@pdurbin
Copy link
Member Author

pdurbin commented Feb 4, 2020

@shlake huh. You're right, that installation seems to be down (I'll take you off this issue):

Screen Shot 2020-02-04 at 10 21 51 AM

@jggautier I'm having trouble finding an RT ticket for http://dadosabertos.rnp.br . Can you please take a look?

@pdurbin
Copy link
Member Author

pdurbin commented Feb 4, 2020

@shlake two things.

http://dadosabertos.rnp.br is resolving now. It looks like they're working on getting Dataverse running again. We can give them time to work on this.

Meanwhile, it looks like you've already added http://dadosabertos.rnp.br in 51cc067 which is great.

Screen Shot 2020-02-04 at 12 42 14 PM

What else do we need? To add the installation to the spreadsheets and add a launch year (#7) of 2019? It looks like I announced it here: https://groups.google.com/d/msg/dataverse-community/4UOFychBqnA/f2IqurALAQAJ . Am I forgetting something? 😄 Do you want to keep working on this? Or should I or someone else pick it up? Thanks. 😄

@pdurbin
Copy link
Member Author

pdurbin commented Feb 4, 2020

@shlake I just created pull request #53

If you're happy with it, please feel free to merge it. Thanks!

@pdurbin pdurbin self-assigned this Feb 4, 2020
@pdurbin pdurbin removed this from To do list for shlake in pdurbin Feb 4, 2020
@pdurbin pdurbin removed their assignment Feb 4, 2020
pdurbin added a commit that referenced this issue Feb 5, 2020
add country, year, etc for dadosabertos.rnp.br #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants