Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private URL To Unpublished Dataset #1012

Closed
posixeleni opened this issue Oct 28, 2014 · 41 comments

Comments

@posixeleni
Copy link
Contributor

@posixeleni posixeleni commented Oct 28, 2014

We are working to integrate with PLOS and they require a private dataset URL (similar to Google Docs or Dropbox links) which can be sent to reviewers to view specific datasets before they are published (read only). The Private URL can also be revoked.

See how figshare handles sharing private URLs: http://figshare.com/blog/figshare_new_features_Get_DOI_or_private_sharing_link/135

@posixeleni posixeleni added this to the In Review - Dataverse 4.0 milestone Oct 28, 2014
@posixeleni

This comment has been minimized.

Copy link
Contributor Author

@posixeleni posixeleni commented Oct 29, 2014

PLOS has requested that we have this feature available by January 2015. I have spoken with @scolapasta and given the tight schedule for 4.0 we would need to schedule this for post 4.0. We should be able to develop this with about a week of development effort. So it should be feasible to get this done by end of Jan 2015 if everything with 4.0 goes according to schedule.

@posixeleni posixeleni modified the milestones: Post 4.0 , In Review - Dataverse 4.0 Oct 29, 2014
@posixeleni posixeleni assigned posixeleni and unassigned scolapasta Oct 29, 2014
@posixeleni

This comment has been minimized.

Copy link
Contributor Author

@posixeleni posixeleni commented Oct 29, 2014

Will work with @eaquigley and @mheppler to design the UI requirements for this feature during the 1st week of November.

@eaquigley

This comment has been minimized.

@posixeleni posixeleni assigned eaquigley and unassigned posixeleni Nov 4, 2014
@eaquigley eaquigley modified the milestones: Beta 11 - Dataverse 4.0, In Review - Dataverse 4.0 Dec 8, 2014
@eaquigley

This comment has been minimized.

Copy link
Contributor

@eaquigley eaquigley commented Dec 8, 2014

@posixeleni can we talk about this tomorrow to get everything ready for this to be implemented. now that 4.0 is going to take a little longer than expected, we need to do this with the launch of 4.0.

@eaquigley

This comment has been minimized.

Copy link
Contributor

@eaquigley eaquigley commented Jan 6, 2015

Two options for this were mocked up:
https://iqssharvard.mybalsamiq.com/projects/privateurl-dataverse40/list
https://iqssharvard.mybalsamiq.com/projects/privateurl-dataverse40option2/list

@posixeleni could you please send to PLOS and have them review the two to let us know which works best? thanks.

@eaquigley eaquigley assigned posixeleni and unassigned eaquigley Jan 6, 2015
@posixeleni posixeleni assigned eaquigley and unassigned posixeleni Jan 7, 2015
@posixeleni

This comment has been minimized.

Copy link
Contributor Author

@posixeleni posixeleni commented Jan 7, 2015

Got a response from PLOS that either option works for them:

Either works for me. If there are
different sharing options, makes sense to put them all on that page.
There might be different options available for the type of "embargo"
we're talking about: when journal article publishes, at a specified date
by author, etc.

@posixeleni

This comment has been minimized.

Copy link
Contributor Author

@posixeleni posixeleni commented Jan 13, 2015

Got a revised response from PLOS when they asked me to clarify the two options further: (prefer option 1 but either works)

Thanks for the clarification. Either works, but I prefer the first option since it makes it very clear that a private URL is an available functionality.

@eaquigley

This comment has been minimized.

Copy link
Contributor

@eaquigley eaquigley commented Jan 13, 2015

@posixeleni I like option 1 better myself. Is cleaner and easier to get to. Will pass to @scolapasta to determine which developer can implement this.

@eaquigley eaquigley assigned posixeleni and unassigned eaquigley Jan 13, 2015
@posixeleni posixeleni removed their assignment Jan 13, 2015
pdurbin added a commit that referenced this issue Jun 23, 2016
pdurbin added a commit that referenced this issue Jun 24, 2016
pdurbin added a commit that referenced this issue Jun 24, 2016
pdurbin added a commit that referenced this issue Jun 24, 2016
@pdurbin

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin commented Jun 24, 2016

I just left a status update at #3111 (comment) (the pull request for this feature).

Since this issue is mostly about the code from my perspective, I'm going to pass it to @mheppler who can move this to QA when he's done reviewing or changing things in #3174. Please note that there is a separate issue about docs at #3138.

@pdurbin pdurbin assigned mheppler and unassigned scolapasta Jun 24, 2016
@mheppler

This comment has been minimized.

Copy link
Contributor

@mheppler mheppler commented Jun 27, 2016

Workflow displaying "Success!" msg is great. After reviewing with @pdurbin and @scolapasta we're going to fine tune it an improvement to the backing bean.

@mheppler mheppler assigned pdurbin and unassigned mheppler Jun 27, 2016
pdurbin added a commit that referenced this issue Jun 27, 2016
@pdurbin

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin commented Jun 27, 2016

@mheppler @scolapasta and I worked through the final fixes for the success message in 50ae521 . It's working as desired now.

Passing to QA. The pull request is #3111.

@pdurbin pdurbin removed their assignment Jun 27, 2016
@pdurbin pdurbin added Status: QA and removed Status: Dev labels Jun 27, 2016
@pdurbin

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin commented Jul 8, 2016

I took pull request #3111 out of QA due to #3200 and #3201 so I'm taking this out of QA as well.

@pdurbin pdurbin added Status: Dev and removed Status: QA labels Jul 8, 2016
@pdurbin

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin commented Jul 14, 2016

pdurbin added a commit that referenced this issue Jul 14, 2016
@pdurbin

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin commented Jul 14, 2016

@scolapasta and @michbarsinai blessed the fix at 24df280 so I merged it into pull request #3111. Passing to QA.

@pdurbin pdurbin assigned kcondon and unassigned scolapasta Jul 14, 2016
@pdurbin pdurbin added Status: QA and removed Status: Dev labels Jul 14, 2016
@kcondon

This comment has been minimized.

Copy link
Contributor

@kcondon kcondon commented Jul 18, 2016

Tested according to the design doc in github and looks good, closing.

@kcondon kcondon closed this Jul 18, 2016
@djbrooke djbrooke added this to QA 👍 in IQSS/dataverse May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.