New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Bootstrap 3.3.7 Upgrade #4219

Closed
mheppler opened this Issue Oct 19, 2017 · 7 comments

Comments

Projects
None yet
6 participants
@mheppler
Contributor

mheppler commented Oct 19, 2017

Upgrade our Bootstrap library from v3.3.2 to v4.0. Read more here: https://getbootstrap.com/docs/4.0/migration/

As of this posting, it is still in beta, but that beta release was two years in the making, with "6 major alpha releases", and has been out for two months now.

They do warn that they've dropped older browser support. "Need support for IE8/IE9, Safari 8-, iOS 8-, etc? Keep using Bootstrap 3." So we should take that into consideration before upgrading.

@mheppler

This comment has been minimized.

Contributor

mheppler commented Jun 20, 2018

There was some discussion with @pameyer and @matthew-a-dunlap in Slack about the PrimeFaces upgrade, specifically the jQuery libraries included since those need to be updated because of security concerns. It was determined that as long as we upgrade to Bootstrap 4 and PrimeFaces 6.2, we'll be good.

PrimeFaces 6.2 is out now, and if we upgrade to Bootstrap 4, we would need no lower than 6.2 due to the jQuery versions.

It appears that PrimeFaces 6.2 uses jQuery 3.2.1 which is the version that Bootstrap 4 recommends.

@mheppler

This comment has been minimized.

Contributor

mheppler commented Jun 26, 2018

This appears to be the migration guide to follow for 3.x to 4.x.

https://v4-alpha.getbootstrap.com/migration/

@mheppler mheppler changed the title from UI - Bootstrap 4 Upgrade to UI - Bootstrap 3.3.7 Upgrade Jun 26, 2018

@mheppler

This comment has been minimized.

Contributor

mheppler commented Jun 26, 2018

It appears that I overlooked the fact that there was a 3.3.7 release, which would provide a lot of the improvements we were aiming for in upgrading (read: jQuery 3 support).

http://blog.getbootstrap.com/2016/07/25/bootstrap-3-3-7-released/

I have retitled this issue to upgrade to that release, as the 4.0 upgrade would require far more effort than we intended for this issue. If and when we redesign the UI as a whole, it would be worth considering an upgrade to Bootstrap 4.0. But for our proposes now with this current UI, 3.3.7 is sufficient and will get done much sooner.

mheppler added a commit that referenced this issue Jul 3, 2018

Upgrade Bootstrap for the Dataverse UI, pointing to CDN for v. 3.3.7.…
… Also upgrade local version for the guides. [ref #4219]
@mheppler

This comment has been minimized.

Contributor

mheppler commented Jul 3, 2018

Initial commit for upgrading Bootstrap versions in the app and guides. Also cleaned up or upgraded a few other random issues.

DATAVERSE

  • Removed local version of Bootstrap 3.3.2 and updated dataverse_template.xhtml to point to CDN copies of v. 3.3.7 (ref #2647)
  • Removed local version of matchHeight 0.7.2 jQuery plugin and updated dataverse_template.xhtml to point to CDN copies of v. 0.7.2 (ref #2647)
  • Removed local version of bootstrap-hover-dropdown.min.js that was not being used in the app because of ui:remove component in dataverse_header.xhtml added comment there in HTML to explain changes and link to newer version if needed (ref #2647)

GUIDES

  • Added local version of jquery-3.1.0.min.jsto guides static resources and link to it in layout.html from the guides Sphinx Bootstrap theme
  • Removed local version of jquery-1.11.0.min.js from guides static resources
  • Upgraded version of Sphinx Bootstrap theme 0.4 to 0.6.1
  • Fixed jQuery code formatting in navbarscroll.js to remove console warning after jQuery 3.1.0 upgrade
  • Removed extra <meta charset='utf-8'> tag in layout.html from the guides Sphinx Bootstrap theme
  • Removed xnavbar_from_dataverse_org.js from guides static resources, which was no longer being used

The move to CDN's was something originally suggested in #2647 but also seemed to a good solution to warnings when deploying.

Warning: JSF1091: No mime type could be found for file bs/fonts/glyphicons-halflings-regular.eot?#iefix. To resolve this, add a mime-type mapping to the applications web.xml.
Warning: JSF1091: No mime type could be found for file bs/fonts/glyphicons-halflings-regular.eot?#iefix. To resolve this, add a mime-type mapping to the applications web.xml.

Still on the to-do list is updating this 4219-bootstrap-upgrade branch with the latest and greatest version of PrimeFaces #4220, which is currently in QA. Still have a few other minor details to comb over.

One other random note, in the guides, there is a warning in the console about the Google Analytics code, which I do not see in the current 4.9.1 released version. I am assuming this is a dev environment issue only.

Not allowed to load local resource: file://www.google-analytics.com/analytics.js

@mheppler mheppler removed their assignment Jul 3, 2018

@mheppler mheppler referenced this issue Jul 3, 2018

Merged

Upgrade Bootstrap v. 3.3.7 [ref #4219] #4806

0 of 5 tasks complete
@pdurbin

This comment has been minimized.

Member

pdurbin commented Jul 9, 2018

Pull request #4806 looks good. I'm excited about the use of CDNs for better performance.

@djbrooke

This comment has been minimized.

Contributor

djbrooke commented Jul 9, 2018

Moving back to Code Review for now as there are some discussions in the PR and we need to decide whether or not we are OK with a CDN here.

@scolapasta

This comment has been minimized.

Contributor

scolapasta commented Jul 9, 2018

Since CDNs are not required for the upgrade to bootstrap, we're going to remove that from this issue / PR. That'll give us time to gather some feedback from the community on their needs / desires / concerns regarding CDNs.

mheppler added a commit that referenced this issue Jul 9, 2018

Removed controversy, swapped out CDN sources for Bootstrap and added …
…local files for 3.3.7 upgrade. Also updated iframe template. [ref #4219]

@mheppler mheppler removed their assignment Jul 9, 2018

pdurbin added a commit that referenced this issue Jul 11, 2018

@kcondon kcondon self-assigned this Jul 13, 2018

kcondon added a commit that referenced this issue Jul 16, 2018

Merge pull request #4806 from IQSS/4219-bootstrap-upgrade
Upgrade Bootstrap v. 3.3.7  [ref #4219]

@kcondon kcondon closed this Jul 16, 2018

@kcondon kcondon removed the Status: QA label Jul 16, 2018

@pdurbin pdurbin added this to the 4.9.2 - Stata Upgrades, etc. milestone Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment