Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
UI - Bootstrap 3.3.7 Upgrade #4219
Upgrade our Bootstrap library from v3.3.2 to v4.0. Read more here: https://getbootstrap.com/docs/4.0/migration/
As of this posting, it is still in beta, but that beta release was two years in the making, with "6 major alpha releases", and has been out for two months now.
They do warn that they've dropped older browser support. "Need support for IE8/IE9, Safari 8-, iOS 8-, etc? Keep using Bootstrap 3." So we should take that into consideration before upgrading.
referenced this issue
May 14, 2018
There was some discussion with @pameyer and @matthew-a-dunlap in Slack about the PrimeFaces upgrade, specifically the jQuery libraries included since those need to be updated because of security concerns. It was determined that as long as we upgrade to Bootstrap 4 and PrimeFaces 6.2, we'll be good.
It appears that I overlooked the fact that there was a 3.3.7 release, which would provide a lot of the improvements we were aiming for in upgrading (read: jQuery 3 support).
I have retitled this issue to upgrade to that release, as the 4.0 upgrade would require far more effort than we intended for this issue. If and when we redesign the UI as a whole, it would be worth considering an upgrade to Bootstrap 4.0. But for our proposes now with this current UI, 3.3.7 is sufficient and will get done much sooner.
added a commit
Jul 3, 2018
Initial commit for upgrading Bootstrap versions in the app and guides. Also cleaned up or upgraded a few other random issues.
The move to CDN's was something originally suggested in #2647 but also seemed to a good solution to warnings when deploying.
Still on the to-do list is updating this
One other random note, in the guides, there is a warning in the console about the Google Analytics code, which I do not see in the current 4.9.1 released version. I am assuming this is a dev environment issue only.