Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Add Data" to navbar, plus Host Dataverse input to create dataverse/dataset forms #5615

Closed
TaniaSchlatter opened this issue Mar 7, 2019 · 22 comments · Fixed by #6338 or #6361
Closed
Assignees
Labels
Milestone

Comments

@TaniaSchlatter
Copy link
Contributor

@TaniaSchlatter TaniaSchlatter commented Mar 7, 2019

One way to have people create more dataverses is to make it easier to see how to do it. People who get to dataverse from google and bypass the home page or search results page don't see a clear way to add data.

One solution: adding a button to the header on every page will help make it clear how to add to Harvard Dataverse.

Adding a button. The button has a dropdown to select a new dataverse or new dataset, as current Add Data functionality from the buttons on the home page:
add_data_header_loggedin

If users are not logged in, the Log in/Sign in popup with a link to sign up (issue #6170) is shown.
Proposed flow:
Add_data_header_flow

Removing the "Add Data" button from the search results page, and showing it on the header for not logged in users:
add_data_header_search_nologin

@TaniaSchlatter

This comment has been minimized.

Copy link
Contributor Author

@TaniaSchlatter TaniaSchlatter commented Mar 11, 2019

Adding the ability to add data from the header means that users need to be able to select the dataverse and/or dataset that they want to deposit data to or create a dataverse in. We would want to show users the dataverses they have permission to add to. This needs to be thought through for admins so that we do not show all options.

Screen Shot 2019-05-02 at 10 24 34 AM

create_dataset2

@mheppler

This comment has been minimized.

Copy link
Contributor

@mheppler mheppler commented Mar 12, 2019

[SORRY: Mistakenly left this comment on the wrong issue on 3/8.]

Adding this feature should including resolving this issue, Moving Dataverses + Datasets: Provide way in the UI for a user to do this #2073.

The navbar contains links for actions at the root/installation level. When you sign up for an account, the account is created at the highest level. When you use the search input, you are searching all contents of the root/installation. Following that logic, clicking "Add Data" would deposit the dataset/dataverse into the root dataverse, which goes against the preferred workflow, of depositing datasets into your own dataverse.

[ALSO: Adding comments from other related issues that were closed as those issues were consolidated into this issue.]

@ajirnyi commented on Jan 14, 2016 in issue #2874

When the base URL is long enough (e.g. 49 symbols in our test case), the Identifier entry field is too short except for very wide browser windows, and it is not possible to see the text entered there (see example below). The issue is most noticeable in Firefox (box is too small up to screen width of 1183 pixels, after which it instantly expands), but is present in all browsers.

dvidentifier

...

@kaitlinnewson commented on Oct 17, 2017 in issue #4212

Hi Harvard team!

We received a report from one of our users about display issues on the 'Create a new dataverse' page. I've tested this in both the Scholars Portal instance and the Harvard instance, have tested in Chrome (v 61.0.3163.100) and Firefox (v 56.0), and am using OSX 10.11.6.

The issue seems to happen at a screen width of 990px or less, and causes text overlap and the inability to see text entered into the identifier field. I've attached a couple of screenshots for reference.

screen shot 2017-10-17 at 2 44 24 pm

screen shot 2017-10-17 at 2 44 39 pm

Let me know if you need any more information!

@djbrooke

This comment has been minimized.

Copy link
Contributor

@djbrooke djbrooke commented Mar 13, 2019

@TaniaSchlatter I moved this over to the design column on the board. Feel free to move back to inbox if this is not the correct status.

@TaniaSchlatter

This comment has been minimized.

Copy link
Contributor Author

@TaniaSchlatter TaniaSchlatter commented Apr 3, 2019

Related issue #5493 (closed), #5874: Push researchers towards Dataverse Creation and Dataset Linking from Journal Acceptance Notifications

@TaniaSchlatter

This comment has been minimized.

Copy link
Contributor Author

@TaniaSchlatter TaniaSchlatter commented May 2, 2019

@pdurbin

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin commented May 2, 2019

Related: As the creator of a dataverse I'd like to know how to make an "Add Data" button appear for non-logged in users to encourage user interaction #5718

@djbrooke djbrooke added this to UI/UX Design 💡📝 in IQSS/dataverse May 8, 2019
@kcondon kcondon moved this from UI/UX Design 💡📝 to Ready 🙋 in IQSS/dataverse Sep 10, 2019
@kcondon kcondon moved this from Ready 🙋 to Community Dev 💻❤️ in IQSS/dataverse Sep 10, 2019
@djbrooke djbrooke moved this from Community Dev 💻❤️ to Ready 🙋 in IQSS/dataverse Sep 23, 2019
@djbrooke djbrooke moved this from Ready 🙋 to IQSS Sprint 9/25 - 10/9 in IQSS/dataverse Sep 24, 2019
@djbrooke djbrooke changed the title Add an "Add Data" button to the header on Harvard dataverse, except on the home page Add an "Add Data" button to the header on Harvard dataverse, except on the custom home page Sep 25, 2019
@djbrooke

This comment has been minimized.

Copy link
Contributor

@djbrooke djbrooke commented Sep 25, 2019

  • Consider a configuration option for whether or not it displays on the custom homepage
  • We could consider a different experience (drop down vs type ahead) depending on the number of dataverses available for selection (consider 5 as a start)
  • Noted some performance concerns about the dataverses list, but we've done work in this area so it may now be more performant (caching? does changing host update dataverse metadata fields? does changing host update dataset template dropdown?)
  • The goal is more participation and more users uploading data, so we don't want it under the name drop down, we should consider internationalization issues re: width
  • We could use Google Analytics or look at the number of records in the DB
  • Evaluate responsiveness of Dataverse create form (#2874, #4212)
@djbrooke djbrooke added the Medium label Sep 25, 2019
@mheppler mheppler self-assigned this Oct 4, 2019
@mheppler mheppler moved this from IQSS Sprint 9/25 - 10/9 to IQSS Team Dev 💻 in IQSS/dataverse Oct 4, 2019
mheppler added a commit that referenced this issue Oct 7, 2019
…ader, edit dataverse form [ref #5615]
@mheppler

This comment has been minimized.

Copy link
Contributor

@mheppler mheppler commented Oct 7, 2019

Outline of the moving parts:

navbar

  • add data dropdown link
  • noopener
  • responsive layout (SM < 992px)

edit/create dataverse form

  • host dataverse UI component (create only)
  • host dataverse backend (refactoring of original beta code; related? #2073)
  • host dataverse backend page refresh on select/change
  • responsive layout (#2874, #4212)
  • accessibility/label
  • accessibility/required
  • accessibility/tabindex

view dataverse pg

  • responsive layout/metrics[root only]; btn block: contact/share, publish/link/edit

edit/create dataset form

  • host dataverse UI component (create only)
  • host dataverse backend (refactoring of original beta code; related? #2073)
  • host dataverse backend page refresh on select/change
  • responsive layout
  • accessibility/required

view dataset pg

  • responsive layout/btn block: contact/share, publish/link/edit
  • responsive layout/deaccession (#6162)

view file pg

  • responsive layout/deaccession

contact form

  • accessibility/label

my data

  • add data dropdown btn (#3923)

user guide

  • account creation + management
  • dataverse management
  • dataset + file management

release notes

  • Add Data and Host Dataverse

OUT OF SCOPE

edit/create dataset form

  • accessibility/label (needs some input from @scolapasta, new issue Create/Edit Dataset Form - need dynamic ID's for input and textarea components #6310)
mheppler added a commit that referenced this issue Oct 8, 2019
@mheppler mheppler changed the title Add an "Add Data" button to the header on Harvard dataverse, except on the custom home page Add "Add Data" to navbar, plus Host Dataverse input to create dataverse/dataset forms Oct 8, 2019
mheppler added a commit that referenced this issue Oct 15, 2019
@landreev landreev mentioned this issue Nov 1, 2019
1 of 5 tasks complete
@landreev landreev removed this from IQSS Team Dev 💻 in IQSS/dataverse Nov 1, 2019
landreev added a commit that referenced this issue Nov 5, 2019
…r is allowed to add datasets... this is not fully acceptable either, unfortunately (#5615)
landreev added a commit that referenced this issue Nov 6, 2019
landreev added a commit that referenced this issue Nov 6, 2019
landreev added a commit that referenced this issue Nov 6, 2019
@landreev

This comment has been minimized.

Copy link
Contributor

@landreev landreev commented Nov 6, 2019

@mheppler So I switched from the selectOne pulldown menu, to the autoComplete setup similar to what we have in the linking popups.
Could you please take a look at the branch and see if any cosmetic readjustments are needed?

landreev added a commit that referenced this issue Nov 7, 2019
mheppler added a commit that referenced this issue Nov 7, 2019
…e, dataset forms plus other instances [ref #5615]
@mheppler

This comment has been minimized.

Copy link
Contributor

@mheppler mheppler commented Nov 7, 2019

Cleaned up the markup and CSS for autoComplete component on edit dataverse and dataset forms. This will also improve the consistency of other instances of this component across the app, like in the link dataset, create group, assign roles and other workflows. There is no change to the functionality of the component, just improving the consistency of the width and padding of the component in the form compared to other form components on the page.

Screen Shot 2019-11-07 at 12 16 12 PM

@landreev will clicking around on the create/edit dataverse and create/edit dataset versions of these forms, I stumbled across two issues that need to resolved:

  • on edit dataverse version of the form, the Host Dataverse autoComplete component is displayed, and not the static text version (see the edit dataset form for how edit the host after create is not allowed)
  • autoComplete components on both dataverse and dataset forms are missing "No results found" emptyMessage attribute (see example on dashboard-datamove form)
landreev added a commit that referenced this issue Nov 7, 2019
…the "edit existing dataverse" mode. (#5615)
landreev added a commit that referenced this issue Nov 7, 2019
@landreev

This comment has been minimized.

Copy link
Contributor

@landreev landreev commented Nov 7, 2019

@mheppler OK, checked in fixes for the 2 things above.

mheppler added a commit that referenced this issue Nov 7, 2019
to top of list since it is at the top of the form now [ref #5615]
landreev added a commit that referenced this issue Nov 7, 2019
landreev added a commit that referenced this issue Nov 8, 2019
mheppler added a commit that referenced this issue Nov 8, 2019
@landreev

This comment has been minimized.

Copy link
Contributor

@landreev landreev commented Nov 8, 2019

The issue mentioned in the PR appears to be the result of primefaces autoComplete giving us trouble; it also looks like it's something we've seen on another page before. Parking it in dev., we'll be working on it first thing next week.

@mheppler

This comment has been minimized.

Copy link
Contributor

@mheppler mheppler commented Nov 12, 2019

Various references for autoComplete/duplicate ID's:

  • JSF errors when adding a dataset: duplicated component IDs #5586 (with PR #6025)
  • Binding attribute causes duplicate component ID found in the view (Stack Overflow)
  • Too much logging messages #5749
landreev added a commit that referenced this issue Nov 12, 2019
…rong owner dataverse on create. (#5615)
landreev added a commit that referenced this issue Nov 12, 2019
landreev added a commit that referenced this issue Nov 12, 2019
@landreev landreev mentioned this issue Nov 12, 2019
0 of 5 tasks complete
kcondon added a commit that referenced this issue Nov 12, 2019
final search query cleanup (#5615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.