Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API: Add API end point to copy language-pack to Dataverse Installation #5806

Closed
JayanthyChengan opened this issue Apr 30, 2019 · 10 comments

Comments

5 participants
@JayanthyChengan
Copy link
Contributor

commented Apr 30, 2019

Create an API call to copy the property files from https://github.com/GlobalDataverseCommunityConsortium/dataverse-language-packs to the dataverse.lang.directory path specified in dataverse installation.

@djbrooke djbrooke added this to Inbox 🗄 in IQSS/dataverse May 8, 2019

@djbrooke

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Hi @JayanthyChengan - is this something that you're working on or are planning to work on?

@JayanthyChengan

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@djbrooke : I am working on it and will submit PR soon

@djbrooke djbrooke added this to Community Dev 💻❤️ in IQSS/dataverse May 14, 2019

@djbrooke

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Awesome, thanks @JayanthyChengan !

@JayanthyChengan

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@djbrooke - submitted PR #5843

@djbrooke djbrooke moved this from Community Dev 💻❤️ to Code Review 🦁 in IQSS/dataverse May 14, 2019

@pdurbin

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@JayanthyChengan thanks for the pull request! I'm excited to try this out but I requested changes, docs, specifically. Thank you!!

This work is very timely because @pkiraly just gave us a lot of great feedback at https://groups.google.com/d/msg/dataverse-community/AgYRCOz1Tlk/ex66tU9FAwAJ

@djbrooke djbrooke moved this from Code Review 🦁 to Community Dev 💻❤️ in IQSS/dataverse May 15, 2019

@djbrooke

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@JayanthyChengan - I'm moving this back to code review for some doc changes. Please let us know when it's ready for another code review pass. Thanks!

pdurbin added a commit to scholarsportal/dataverse that referenced this issue May 15, 2019

@pdurbin

This comment has been minimized.

Copy link
Member

commented May 15, 2019

In 5a8c18d I added @JayanthyChengan 's write up to a new "Internationalization" section of the config section of the Installation Guide. I tried it out on dev2 and it seemed to work. @JayanthyChengan heads up that I looks some liberties to re-write and add what I hope is clarity. 😄 Off to QA! Thanks!

@pdurbin pdurbin moved this from Community Dev 💻❤️ to QA in IQSS/dataverse May 15, 2019

@JayanthyChengan

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Thanks @pdurbin

@pkiraly

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@JayanthyChengan: great work, congratulation!

For me it is still open question if the language pack should or should not contain the original language property files available in the Dataverse core.

Don't you want to cover dataverse-docker repository's language properties as well? Or maybe move the language files from there to the now referenced repository? (I include @4tikhonov into this discussion.)

@pdurbin

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@pkiraly yes, I believe the English files are required. Please see #5793 and this note that I left in the guides (I just highlighted the important part in my browser):

Screen Shot 2019-05-15 at 4 19 53 PM

And yes, we absolutely want the languages in the dataverse-docker repo. Please see this issue I just opened (and please feel free to work on it if you'd like! 😄 ): GlobalDataverseCommunityConsortium/dataverse-language-packs#10

@kcondon kcondon self-assigned this May 15, 2019

@kcondon kcondon moved this from QA to Done 🚀 in IQSS/dataverse May 15, 2019

@kcondon kcondon closed this May 15, 2019

pdurbin added a commit that referenced this issue May 16, 2019

kcondon added a commit that referenced this issue May 16, 2019

Merge pull request #5849 from IQSS/5806-lang-api
separate header for loading lang zip #5806

@djbrooke djbrooke added this to the 4.15 milestone Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.