6684 dataset pg btn responsive #6909
Conversation
…ary on dataset pg [ref #6684]
6684 thumbnails
That's seemingly a lot of changes, but it was the assumption throughout the code base that all the dataset-level thumbnails are always the same size. Removing it now will help with making all the thumbnails for everything completely variable (as opposed to how they come in the few pre-defined sizes now), which we are planning to add as well, sometime soon (?) ref #6684
…ed up thumbnail size on dataset pg [ref #6684]
… using the small, 48 pixel thumbnails). #6684
…ns and headers [ref #6684]
|
@sekmiller contributed a bunch of render logic optimization code, moving a lot of the render logic of the publish/submit for review links/buttons from the XHTML to the DatasetPage.java backing bean. There is now only one publish commandLink in the new button UI xhtml code. @kcondon, with these improvements, I have linked issue Dataset Publish/Submit for Review - Optimize Button/Popup Code #1664 to be closed when this PR is merged. |
# Conflicts: # src/main/webapp/dataset.xhtml # src/main/webapp/file-download-button-fragment.xhtml
|
Discussed briefly in the design meeting. The steps remaining here are:
|
|
Fixed (a16adff) the merge conflict/broken dataset pg added in the last update from develop, related to request access javascript that was added by @qqmyers #6943. (Hope that I didn't break anything even more!) In order to make sure his new code was delivered to both the dataset pg and file pg, I had to duplicate that code block, since we don't have a very elegant way of delivering two different looking buttons to two different pages in the new button UI. |
|
OK. Back to QA. Thank you for the refactored publish btn and popup code, @sekmiller. The old #1664 issue reporting that has been linked to the original PR comment above to close it. I also had to back out an unnecessary duplication of javascript that I added in my last merge conflict fix and referenced in my last comment above. |
mheppler
moved this from IQSS Team - In Progress 💻
to QA 🔎✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
Issues found: |
What this PR does / why we need it:
Which issue(s) this PR closes:
Closes #6684 Layout and styling of action buttons on the dataset and file page
Closes #3815 Improve visibility of buttons for data owners
Closes #1664 Dataset Publish/Submit for Review - Optimize Button/Popup Code
Closes #1221 Deaccessioning: What should show in search card?
Closes #1063 Mobile Dataverse: Solution for Displaying Dataverse on a Mobile Device
Ref #6605 Dataset Page Redesign
Ref #6604 File Page Redesign
Ref #3953 Improve the clarity of page types and their purpose
Special notes for your reviewer:
Thank you for your time.
Suggestions on how to test this:
@kcondon, I would be happy to meet and discuss what I should put here to help you.
Does this PR introduce a user interface change?:
Well, yeah. (Link to mockups: https://sketch.cloud/s/mWGQJ/a/4KZgLZ)
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A