add file previewers to dev env, more docs#11181
Conversation
pdurbin
added
Component: Containers
| @@ -97,7 +97,8 @@ services: | |||
| - DATAVERSE_URL=http://dataverse:8080 | |||
| - TIMEOUT=10m | |||
| - PREVIEWERS_PROVIDER_URL=http://${MACHINE_IP:-localhost}:9000 | |||
There was a problem hiding this comment.
Should we consider removing this MACHINE_IP stuff from this compose file? We already removed it from the dev version.
There was a problem hiding this comment.
I expect that it would make a lot of sense to be able to provide an alternative IP address (or host name) in a production environment. Leaving it in would be a good idea IMHO.
There was a problem hiding this comment.
Yeah, I suspect we'll dig into this more when we work on fronting Dataverse with some sort of proxy:
Kris-LIBIS
left a comment
Kris-LIBIS
left a comment
There was a problem hiding this comment.
I would recommend to add the --rm option to the docker run command to clean up the container after running. But besides that, this is a perfect addition.
|
@Kris-LIBIS great idea. I added the rm in 322b3a6. |
|
Hmm, seeing strange icons for the zip previewer/downloader: 
|
|
It looks like we're getting a 404 for files like http://localhost:9000/previewers/v1.4/fonts/glyphicons-halflings-regular.ttf 
|
pdurbin
force-pushed
the
10506-previewers
branch
from
322b3a6 to
94c639d
Compare
|
Hello, can you please update 6.5 to 6.6. Thanks! |
|
Sure, done. |
|
Merging PR, no issues found. |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
7 participants
What this PR does / why we need it:
Developers like previewers too! Plus, we're adding some docs.
Which issue(s) this PR closes:
Special notes for your reviewer:
The previewers run on port 9080 in the development environment. In the demo/eval environment, they run on 9000 because MinIO isn't running (also on port 9000).
Suggestions on how to test this:
Try both the dev env and the "demo or eval" env.
Both should have all the previewers available.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Sort of? You can see previewers, like this:
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
https://dataverse-guide--11181.org.readthedocs.build/en/11181/container/running/demo.html#file-previewers