explain how to customize root collection in "running in Docker" tutorial - #11201
Merged
Conversation
pdurbin
added
Component: Containers
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
pdurbin
commented
Feb 6, 2025
|
|
||
| API_TOKEN=$(grep apiToken "/tmp/setup-all.sh.out" | jq ".data.apiToken" | tr -d \") | ||
| export API_TOKEN | ||
|
|
Member
Author
There was a problem hiding this comment.
Add "if file exists" here, perhaps.
Member
Author
There was a problem hiding this comment.
@Kris-LIBIS I added the "if" in this commit: 4f8ea65
Please take a look! Thanks!
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
This one is good to go, test and regression tested, no issues found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In Milestone F of the container proposal and in recent discussions, we've said we want people to be able to configure the alias and name of the root collection.
Which issue(s) this PR closes:
Special notes for your reviewer:
This PR is an alternative to #11196. It allows more customization.
Please feel free to discuss here or at https://dataverse.zulipchat.com/#narrow/channel/375812-containers/topic/in.20demo.2Feval.20env.2C.20configure.20root.20collection.20alias.20and.20name/near/496383414
Suggestions on how to test this:
Follow the provided instructions. Your root collection should look like this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
https://dataverse-guide--11201.org.readthedocs.build/en/11201/container/running/demo.html#root-collection-customization-alias-name-etc