Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4448 api edit var meta #5971

Merged
merged 77 commits into from Jul 10, 2019

Conversation

@lubitchv
Copy link
Contributor

commented Jun 25, 2019

New API endpoint in EditDDI.java for updating variable level metadata.
It is used in Data Curation Tool and also can be called using curl command with corresponding xml file.

Related Issues

Closes #4448
Closes #4174

Pull Request Checklist

  • Unit [tests][] completed
  • [ X] Integration [tests][]: EditDDIIT.java
  • Deployment requirements, [SQL updates][], [Solr updates][], etc.: None
  • [ x] [Documentation][docs] completed
  • Merged latest from "develop" [branch][] and resolved conflicts

lubitchv added some commits Mar 26, 2019

@pdurbin

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

@lubitchv I just made this pull request against your pull request: lubitchv#23

Please take a look and merge it if you're happy with it. Then I'll move this pull request to QA.

If you don't like anything in my pull request, please let me know!

I'm excited about the Data Curation Tool! After talking to @djbrooke we decided to go ahead and add it to the list of external tools. This means someone will need to add some installation instructions to the README at https://github.com/scholarsportal/Dataverse-Data-Curation-Tool just like https://github.com/scholarsportal/Dataverse-Data-Explorer#installation

@pdurbin pdurbin moved this from QA to Community Dev 💻❤️ in IQSS/dataverse Jun 28, 2019

@pdurbin pdurbin assigned lubitchv and unassigned pdurbin Jun 28, 2019

@pdurbin

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

This means someone will need to add some installation instructions to the README at https://github.com/scholarsportal/Dataverse-Data-Curation-Tool just like https://github.com/scholarsportal/Dataverse-Data-Explorer#installation

I just created an issue for this: scholarsportal/Dataverse-Data-Curation-Tool#4

Merge pull request #23 from IQSS/4448-api-edit-var-meta-pdurbin-code-…
…review

4448 api edit var meta pdurbin code review
@lubitchv

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

@pdurbin I merged your pull request into mine.

IQSS/dataverse automation moved this from Community Dev 💻❤️ to QA Jun 28, 2019

@pdurbin

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

@lubitchv thanks! I moved your pull request to QA. Please don't forget to work on scholarsportal/Dataverse-Data-Curation-Tool#4 so the Dataverse community can start installing and using this great new tool!

@amberleahey amberleahey added this to In progress in Scholars Portal Dataverse Jul 3, 2019

@amberleahey amberleahey moved this from In progress to Done in Scholars Portal Dataverse Jul 4, 2019

@kcondon

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@lubitchv

API works if I download dct.xml from curation tool after making changes. A couple data curation tool issues:
[ ] FYI, curation tool persists weighted var on selected var even if cancel, eg. make var 1 wgt, make var2 have var1 as wgt but then cancel. If view, var2 still has var1 as wgt unless choose unweighted.
[ ] Cannot save edits in curation tool

Also, one potential issue for Dataverse:
[ ] Versions tab shows difference type but no details. Should it?
it says, "Variable Metadata (Changed Variable Metadata: 1); View Details" but no details
This can probably be merged but passing back for comment

@kcondon kcondon moved this from QA to Community Dev 💻❤️ in IQSS/dataverse Jul 9, 2019

@lubitchv

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Thank you, @kcondon

  1. Persistence of weighted var on selected var even if cancel is indeed a bug in UI Data Curation Tool. I started working on fixing it. But it does not have a direct connection to this pull request (API), it is an UI issue. Thank you for noticing it.

  2. Save edits does not work in DCT if one integrates external tool with siteUrl (for example github). Then it runs into issue of CORS. We should discuss it. How should we allow PUT from external site. But if one integrates external tool putting it in webapps and compiling it with dataverse, getting it in war file then save edits works.
    This issue can be treated as separate issue and I was planning to open an issue for that.

  3. Version tab indeed shows difference type but no details. It was done on purpose. The reason for it: there can be hundreads of variables that may be updated. It was not clear how to present it in dataverse UI. And we probably should think how it can be done and we left it for later work.

@kcondon

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@lubitchv OK, makes sense. Thanks. What does the 1 represent in: "Variable Metadata (Changed Variable Metadata: 1); View Details"

@lubitchv

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@kcondon 1 represents number of files changed, not a number of variables, since in in one dataset can be several files that maybe updated.

@kcondon

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@lubitchv OK, thanks. Will move it back to qa. Ready to merge, pending point release planning. It may need refresh from develop if it is not included in point release.

@kcondon kcondon moved this from Community Dev 💻❤️ to QA in IQSS/dataverse Jul 9, 2019

@kcondon kcondon assigned kcondon and unassigned lubitchv Jul 9, 2019

@djbrooke djbrooke added this to the 4.15.1 milestone Jul 10, 2019

@kcondon kcondon merged commit dcb6ca1 into IQSS:develop Jul 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on 4448-api-edit-var-meta at 19.584%
Details

IQSS/dataverse automation moved this from QA to Done 🚀 Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.