From 38760b05e14a078d3b03a031a43dd27965869543 Mon Sep 17 00:00:00 2001 From: Michael Heppler Date: Mon, 24 Feb 2020 15:35:22 -0500 Subject: [PATCH] Swapped extra quotes in bibtex citation for title for double brackets [ref #6658] --- .../java/edu/harvard/iq/dataverse/DataCitation.java | 4 ++-- .../edu/harvard/iq/dataverse/DataCitationTest.java | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/edu/harvard/iq/dataverse/DataCitation.java b/src/main/java/edu/harvard/iq/dataverse/DataCitation.java index 051055efb42..a16cf3b67b7 100644 --- a/src/main/java/edu/harvard/iq/dataverse/DataCitation.java +++ b/src/main/java/edu/harvard/iq/dataverse/DataCitation.java @@ -265,12 +265,12 @@ public void writeAsBibtexCitation(OutputStream os) throws IOException { out.write(title); out.write("},\r\n"); } else { - out.write("title = \"{"); + out.write("title = {{"); String doubleQ = "\""; String doubleTick = "``"; String doubleAp = "''"; out.write(title.replaceFirst(doubleQ, doubleTick).replaceFirst(doubleQ, doubleAp)); - out.write("}\",\r\n"); + out.write("}},\r\n"); } if(UNF != null){ out.write("UNF = {"); diff --git a/src/test/java/edu/harvard/iq/dataverse/DataCitationTest.java b/src/test/java/edu/harvard/iq/dataverse/DataCitationTest.java index a2abf573e46..b32243d446d 100644 --- a/src/test/java/edu/harvard/iq/dataverse/DataCitationTest.java +++ b/src/test/java/edu/harvard/iq/dataverse/DataCitationTest.java @@ -72,7 +72,7 @@ public void testWriteAsBibtexCitation() throws ParseException, IOException { "@data{LK0D1H_1955,\r\n" + "author = {First Last},\r\n" + "publisher = {LibraScholar},\r\n" - + "title = \"{Dataset Title}\",\r\n" + + "title = {{Dataset Title}},\r\n" + "year = {1955},\r\n" + "version = {V1},\r\n" + "doi = {10.5072/FK2/LK0D1H},\r\n" @@ -95,7 +95,7 @@ public void testToBibtexString() throws ParseException { "@data{LK0D1H_1955,\r\n" + "author = {First Last},\r\n" + "publisher = {LibraScholar},\r\n" - + "title = \"{Dataset Title}\",\r\n" + + "title = {{Dataset Title}},\r\n" + "year = {1955},\r\n" + "version = {V1},\r\n" + "doi = {10.5072/FK2/LK0D1H},\r\n" @@ -119,7 +119,7 @@ public void testToBibtexString_withoutAuthor() throws ParseException { "@data{LK0D1H_1955,\r\n" + "author = {},\r\n" + "publisher = {LibraScholar},\r\n" - + "title = \"{Dataset Title}\",\r\n" + + "title = {{Dataset Title}},\r\n" + "year = {1955},\r\n" + "version = {V1},\r\n" + "doi = {10.5072/FK2/LK0D1H},\r\n" @@ -144,7 +144,7 @@ public void testToBibtexString_withoutTitle() throws ParseException { "@data{LK0D1H_1955,\r\n" + "author = {First Last},\r\n" + "publisher = {LibraScholar},\r\n" - + "title = \"{}\",\r\n" + + "title = {{}},\r\n" + "year = {1955},\r\n" + "version = {V1},\r\n" + "doi = {10.5072/FK2/LK0D1H},\r\n" @@ -169,7 +169,7 @@ public void testToBibtexString_withoutTitleAndAuthor() throws ParseException { "@data{LK0D1H_1955,\r\n" + "author = {},\r\n" + "publisher = {LibraScholar},\r\n" - + "title = \"{}\",\r\n" + + "title = {{}},\r\n" + "year = {1955},\r\n" + "version = {V1},\r\n" + "doi = {10.5072/FK2/LK0D1H},\r\n" @@ -335,7 +335,7 @@ public void testTitleWithQuotes() throws ParseException { "@data{LK0D1H_1955,\r\n" + "author = {First Last},\r\n" + "publisher = {LibraScholar},\r\n" - + "title = \"{This Title ``Has Quotes'' In It}\",\r\n" + + "title = {{This Title ``Has Quotes'' In It}},\r\n" + "year = {1955},\r\n" + "version = {V1},\r\n" + "doi = {10.5072/FK2/LK0D1H},\r\n"