Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7922 translation for subfield with controlled vocabullary #7923

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

tcoupin
Copy link
Member

@tcoupin tcoupin commented Jun 4, 2021

What this PR does / why we need it:

Which issue(s) this PR closes:

Closes #7922

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@tcoupin
Copy link
Member Author

tcoupin commented Jun 4, 2021

Capture d’écran 2021-06-04 à 19 34 20

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.324% when pulling 800b87e on tcoupin:fix-7922 into b61b572 on IQSS:develop.

Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kcondon
Copy link
Contributor

kcondon commented Jun 29, 2021

@tcoupin This works, thanks! @qqmyers Any review comments?

@qqmyers
Copy link
Member

qqmyers commented Jun 29, 2021

Nope - good to go!

@kcondon kcondon merged commit fbd1aa0 into IQSS:develop Jun 29, 2021
@djbrooke djbrooke added this to the 5.6 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no translation for subfield with controlled vocabulary
7 participants