-
Notifications
You must be signed in to change notification settings - Fork 511
9444 push images #9447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9444 push images #9447
Conversation
@poikilotherm @GPortas and I have been discussing this PR and decided to give it a size of 3. At the sprint planning kickoff just now, I advocated for a column in the global backlog for containerization (and mentioned it's a topic for the working group meeting next week). For now, I put it at the top of the community column. |
I added a link to the pet project in the description. We can simply copy the workflows from there, rename the targets/modules and drop it in here. Probably should add some docs to our container guides how that pipeline works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed to switch from "stable" to something else.
Also, what else is need to move this pull request from "draft" to "ready for review"?
3458d8f
to
efe85dc
Compare
efe85dc
to
a826bda
Compare
Pushed preview application image as |
@pdurbin I just moved this to ready for review. Someone should take a look at the text and docs. It seems the workflow itself does what we expect it to do. We will only learn about mistakes with the Docker Hub push after merging, when a push build fails. |
@GPortas @MellyGray as you'd be the folks mostly reusing this feature of PR-based images, please let me know if having a bot generated comment like shown above is helpful or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great! I left a few comments and suggestions.
The bot is really cool! I haven't use this PR image feature yet, but it seems really useful, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! API tests are passing. Let's give it a whirl!
What this PR does / why we need it:
This pull request will enable pushing Dataverse application images from the stable master branch, nightly builds from the unstable development branch and feature builds from pull requests. It will also enable scheduled rebuilds to keep the important/supported tags up to date.
Which issue(s) this PR closes:
Special notes for your reviewer:
This is not yet ready for review. We will need to investigate the correct workflow setups in a separate pet project.
Here's the fancy pet project. Works like a charm. https://github.com/poikilotherm/test-image-push-flows
Suggestions on how to test this:
None yet.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes. Will be included once it works.
Additional documentation:
None.