Skip to content

9444 push images #9447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 25, 2023
Merged

9444 push images #9447

merged 15 commits into from
Apr 25, 2023

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Mar 15, 2023

What this PR does / why we need it:

This pull request will enable pushing Dataverse application images from the stable master branch, nightly builds from the unstable development branch and feature builds from pull requests. It will also enable scheduled rebuilds to keep the important/supported tags up to date.

Which issue(s) this PR closes:

Special notes for your reviewer:
This is not yet ready for review. We will need to investigate the correct workflow setups in a separate pet project.

Here's the fancy pet project. Works like a charm. https://github.com/poikilotherm/test-image-push-flows

Suggestions on how to test this:
None yet.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.

Is there a release notes update needed for this change?:
Yes. Will be included once it works.

Additional documentation:
None.

@poikilotherm poikilotherm added Feature: Installation Guide User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh Component: Containers Anything related to cloudy Dataverse, shipped in containers. D: DataverseInDocker Deliverable of running Dataverse within Docker labels Mar 15, 2023
@poikilotherm poikilotherm self-assigned this Mar 15, 2023
@pdurbin pdurbin added the Size: 3 A percentage of a sprint. 2.1 hours. label Mar 15, 2023
@pdurbin
Copy link
Member

pdurbin commented Mar 15, 2023

@poikilotherm @GPortas and I have been discussing this PR and decided to give it a size of 3.

At the sprint planning kickoff just now, I advocated for a column in the global backlog for containerization (and mentioned it's a topic for the working group meeting next week). For now, I put it at the top of the community column.

@poikilotherm
Copy link
Contributor Author

poikilotherm commented Mar 15, 2023

I added a link to the pet project in the description.

We can simply copy the workflows from there, rename the targets/modules and drop it in here. Probably should add some docs to our container guides how that pipeline works.

@poikilotherm poikilotherm mentioned this pull request Mar 16, 2023
2 tasks
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to switch from "stable" to something else.

Also, what else is need to move this pull request from "draft" to "ready for review"?

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Pushed preview application image as ghcr.io/gdcc/dataverse:9444-push-images.
Use it by referencing it with its full name as printed above.

@poikilotherm poikilotherm marked this pull request as ready for review April 24, 2023 14:32
@poikilotherm
Copy link
Contributor Author

@pdurbin I just moved this to ready for review. Someone should take a look at the text and docs. It seems the workflow itself does what we expect it to do. We will only learn about mistakes with the Docker Hub push after merging, when a push build fails.

@poikilotherm poikilotherm removed their assignment Apr 24, 2023
@poikilotherm poikilotherm requested a review from GPortas April 24, 2023 14:35
@poikilotherm
Copy link
Contributor Author

poikilotherm commented Apr 24, 2023

@GPortas @MellyGray as you'd be the folks mostly reusing this feature of PR-based images, please let me know if having a bot generated comment like shown above is helpful or not.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! I left a few comments and suggestions.

@MellyGray
Copy link

@GPortas @MellyGray as you'd be the folks mostly reusing this feature of PR-based images, please let me know if having a bot generated comment like shown above is helpful or not.

The bot is really cool! I haven't use this PR image feature yet, but it seems really useful, thanks!

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! API tests are passing. Let's give it a whirl!

@pdurbin pdurbin merged commit 4903e9f into develop Apr 25, 2023
@poikilotherm poikilotherm deleted the 9444-push-images branch April 25, 2023 11:26
@pdurbin pdurbin added this to the 5.14 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. D: DataverseInDocker Deliverable of running Dataverse within Docker Feature: Installation Guide Size: 3 A percentage of a sprint. 2.1 hours. User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change tag from "stable" to "alpha" on Docker Hub Push dev app images to registries
3 participants