Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inhance - switching project from js to Typescript #117

Merged
merged 42 commits into from
Sep 2, 2023
Merged

inhance - switching project from js to Typescript #117

merged 42 commits into from
Sep 2, 2023

Conversation

bellaabdelouahab
Copy link
Member

i have faced many problems working with js in the back end :

  • testing unite doesnt support es module
  • swagger docs are not generated correctly
  • i face type error now and then which take lots of time traking and fixing

@bellaabdelouahab
fix - paths to user model
11582d9
@bellaabdelouahab
feat - api version control
016c2a0
@bellaabdelouahab
fix - conf morgan to ignore redirected req
a823d1d
@bellaabdelouahab
docs - base controller
a30dcc7
@bellaabdelouahab
feat - calendar model
5a829b7
@bellaabdelouahab
Merge branch 'main' of https://github.com/ISIL-ESTE/Student-Workflow-…
6825ffb 
…Organizer
@bellaabdelouahab
Squashed commit of the following:
a3afdea 
commit 3e0da0c
Author: Muttaqin <MDMUTTAQIN20@GMAIL.COM>
Date:   Fri Aug 11 00:13:20 2023 +0600

    Feat/token based authentication 2 (ISIL-ESTE#91)

    * Move .husky to the base dir.

    * Delete eslintrc.json.

    * Resolve ISIL-ESTE#71 & fix import paths for user_model .

    * token refresh & logout.

    * Add utility class auth_utils.

    * Configure cookie parser.

commit d5ff984
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Fri Jul 28 12:49:05 2023 +0100

    fix - add logo path to readme (ISIL-ESTE#86)

commit 00c882e
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Fri Jul 28 12:47:07 2023 +0100

    fix - eslint json roles -> js (ISIL-ESTE#85)

    * Update access to env

    * configure rate limiter to ignore the SSE requests

    * verify user authorities and restrictions

    * update access to env variables

    * fix - adapt testing to new functionalities

    * fix - env variables security

    * extra fix

    * fix eslint json -> js

commit f0674fb
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Fri Jul 28 11:29:11 2023 +0100

    Update app_config.js (ISIL-ESTE#84)

commit b659237
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Fri Jul 28 11:21:01 2023 +0100

    fix - Up date env variables : remove hard coded credentials  (ISIL-ESTE#83)

    * Update access to env

    * configure rate limiter to ignore the SSE requests

    * verify user authorities and restrictions

    * update access to env variables

    * fix - adapt testing to new functionalities

    * fix - env variables security

commit af609a1
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Fri Jul 28 10:41:55 2023 +0100

    Creating CONTRIBUTING.md (ISIL-ESTE#79)

commit 9254b1d
Author: Muttaqin <MDMUTTAQIN20@GMAIL.COM>
Date:   Fri Jul 28 00:10:13 2023 +0600

    Feat/configure pre-commit hook (ISIL-ESTE#81)

    * configure pre-commit hooks.

    * Pre-commit hook test - lint & fix every .js & .json file.

commit fbb1537
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Wed Jul 26 17:47:48 2023 +0100

    fix - rate limiter & duplicated methods & env variables (ISIL-ESTE#74)

    * Update access to env

    * configure rate limiter to ignore the SSE requests

    * verify user authorities and restrictions

    * update access to env variables

commit c1894bc
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Tue Jul 25 19:59:30 2023 +0100

    add count of closed pr (ISIL-ESTE#76)

commit 8cf1209
Author: Muttaqin <MDMUTTAQIN20@GMAIL.COM>
Date:   Wed Jul 26 00:38:42 2023 +0600

    Feat - token-based-authentication (ISIL-ESTE#75)

    * Configure linter and formatter.

    * Add configurations for access & refresh token.

    * Add token model.

    * Add functionality to generate Access & refresh token and send it to
    user.

    * save exact version of dev-dependencies.

commit 0140aa1
Author: boujrada yassine <63125972+yassineboujrada@users.noreply.github.com>
Date:   Fri Jul 21 10:44:15 2023 +0100

    Implement Sign Up Component with Next.js (ISIL-ESTE#67)

    * adding a login page but it need a auth

    * adding sign up componenet

commit e2227f9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Jul 21 09:46:10 2023 +0100

     dependencies update ISIL-ESTE#69

    Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
    - [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
    - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

    ---
    updated-dependencies:
    - dependency-name: word-wrap
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 19b5bf9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Jul 21 09:45:40 2023 +0100

     dependencies update ISIL-ESTE#68

    Bumps [mongoose](https://github.com/Automattic/mongoose) from 6.10.4 to 6.11.3.
    - [Release notes](https://github.com/Automattic/mongoose/releases)
    - [Changelog](https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md)
    - [Commits](Automattic/mongoose@6.10.4...6.11.3)

    ---
    updated-dependencies:
    - dependency-name: mongoose
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit c6c6d61
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Jul 21 09:44:40 2023 +0100

     dependencies update ISIL-ESTE#65

    Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
    - [Release notes](https://github.com/npm/node-semver/releases)
    - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
    - [Commits](npm/node-semver@v5.7.1...v5.7.2)

    ---
    updated-dependencies:
    - dependency-name: semver
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit dd8c55a
Merge: e2503a6 9b899d0
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Thu Jul 13 15:02:36 2023 +0100

    Bump semver from 6.3.0 to 6.3.1 in /frontend-app ISIL-ESTE#64

    Bump semver from 6.3.0 to 6.3.1 in /frontend-app ISIL-ESTE#64

commit e2503a6
Merge: 372d6ce 26702c0
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Thu Jul 13 15:01:06 2023 +0100

    Github Oauth integration ISIL-ESTE#58

    Github Oauth integration ISIL-ESTE#58

commit 9b899d0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Jul 13 05:00:30 2023 +0000

    Bump semver from 6.3.0 to 6.3.1 in /frontend-app

    Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1.
    - [Release notes](https://github.com/npm/node-semver/releases)
    - [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md)
    - [Commits](npm/node-semver@v6.3.0...v6.3.1)

    ---
    updated-dependencies:
    - dependency-name: semver
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit 26702c0
Author: Muttaqin <MDMUTTAQIN20@GMAIL.COM>
Date:   Fri Jul 7 10:12:04 2023 +0600

    Github integration.

commit 372d6ce
Merge: 55be937 92eddd6
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Sat Jul 1 16:29:57 2023 +0100

    Merge pull request ISIL-ESTE#61 from bellaabdelouahab/dev

    Enhance -  appError & code cleanup & login page in frontend [ISIL-ESTE#61]

commit 92eddd6
Merge: 2d3a5d3 d5b3b60
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Sat Jul 1 16:26:43 2023 +0100

    Merge commit 'd5b3b6057f88106099a3fd2a1095de400e767ff6' into dev

commit 2d3a5d3
Merge: fbbdda1 55be937
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Sat Jul 1 16:23:56 2023 +0100

    Merge branch 'ISIL-ESTE:dev' into dev

commit fbbdda1
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Sat Jul 1 16:22:42 2023 +0100

    enhe-app error clean up

commit 55be937
Merge: a6fe803 dab86a2
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Sat Jul 1 16:20:07 2023 +0100

    Merge pull request ISIL-ESTE#56 from bellaabdelouahab/dev

    Add user activation, metadata, routes, and soft delete logic; fix response path and server errors

commit d5b3b60
Author: yassineboujrada <yassine.boujrada@gmail.com>
Date:   Wed Jun 28 23:29:42 2023 +0100

    adding page for login with tailwind the part need is fix auth

commit 1cdb4ae
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Tue Jun 27 18:57:46 2023 +0100

    fix errors and add testing for activation

commit dab86a2
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Mon Jun 26 19:49:14 2023 +0100

    requested changes

commit 41865dd
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Mon Jun 26 17:31:27 2023 +0100

    Add user activation, metadata, routes, and soft delete logic; fix response path and server errors

commit 8ebd680
Merge: 710ccbf a6fe803
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Sun Jun 25 21:56:09 2023 +0100

    trying to merge

commit a6fe803
Merge: 0115fee 2c4d94c
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Sun Jun 25 21:49:23 2023 +0100

    Merge pull request ISIL-ESTE#53 from muttaqin1/refactor/file-names

    Refactor - ISIL-ESTE#53  change file names

commit 2c4d94c
Author: muttaqin1 <mdmuttaqin20@gmail.com>
Date:   Mon Jun 26 02:18:51 2023 +0600

    Update import paths.

commit 7609c6b
Author: muttaqin1 <mdmuttaqin20@gmail.com>
Date:   Mon Jun 26 01:32:02 2023 +0600

    Refactor file names with underscore.

commit 392b611
Author: muttaqin1 <mdmuttaqin20@gmail.com>
Date:   Mon Jun 26 01:08:59 2023 +0600

    resolve ISIL-ESTE#52.

commit 710ccbf
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Sun Jun 25 19:17:42 2023 +0100

    requested changes

commit 0115fee
Merge: dca09e4 c7b8464
Author: Khalid BOUSSAROUAL <102565973+Khalid1G@users.noreply.github.com>
Date:   Sun Jun 25 19:14:38 2023 +0100

    Merge pull request ISIL-ESTE#51 from bellaabdelouahab/dev

    fix - testing role managment

commit c7b8464
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Sun Jun 25 12:43:24 2023 +0100

    code cleaning

commit 5b65a0f
Merge: b2aa675 dca09e4
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Sun Jun 25 12:21:08 2023 +0100

    Merge remote-tracking

commit b2aa675
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Sun Jun 25 11:52:49 2023 +0100

    👌fix-swagger-autogen & endpoints & jwt,feat-tests

commit dca09e4
Merge: a97eeea 154d7ee
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Fri Jun 23 17:10:00 2023 +0100

    Merge pull request ISIL-ESTE#45 from muttaqin1/bugFix/ban-user

    [ISIL-ESTE#45 ] issue - Bug fix/ban user

commit 154d7ee
Merge: 8d857ee a97eeea
Author: Abdelouahab Bella <abdobella977@gmail.com>
Date:   Fri Jun 23 16:58:37 2023 +0100

    Merge branch 'dev' into bugFix/ban-user

commit 8d857ee
Author: muttaqin1 <mdmuttaqin20@gmail.com>
Date:   Fri Jun 23 21:34:32 2023 +0600

    Fix ban and unban user.

commit a97eeea
Merge: d9ae2c6 17e53a5
Author: Khalid BOUSSAROUAL <102565973+Khalid1G@users.noreply.github.com>
Date:   Thu Jun 22 15:41:41 2023 +0100

    Merge pull request ISIL-ESTE#40 from bellaabdelouahab/dev

    test - start code testing for login and sign up

commit 17e53a5
Merge: be73f7d d9ae2c6
Author: Khalid BOUSSAROUAL <102565973+Khalid1G@users.noreply.github.com>
Date:   Thu Jun 22 15:39:57 2023 +0100

    Merge branch 'dev' into dev

commit d9ae2c6
Merge: 9d0bdd6 d6ebb36
Author: Khalid BOUSSAROUAL <102565973+Khalid1G@users.noreply.github.com>
Date:   Thu Jun 22 15:31:44 2023 +0100

    Merge pull request ISIL-ESTE#38 from ISIL-ESTE/limiter

    add rate limit

commit be73f7d
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Thu Jun 22 14:58:43 2023 +0100

    test - add basic example of testing & fix imports

commit d6ebb36
Author: Khalid BOUSSAROUAL <102565973+Khalid1G@users.noreply.github.com>
Date:   Thu Jun 22 13:46:01 2023 +0100

    add rate limit

commit 70bbe22
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Thu Jun 22 11:33:17 2023 +0100

    👌 ensuring that main branch is protected

commit 7301c3b
Author: Abdelouahab Bella <a.bella4246@uca.ac.ma>
Date:   Thu Jun 22 11:27:28 2023 +0100

    👌ensuring that Conterbute is working
@bellaabdelouahab
Merge branch 'main' of https://github.com/ISIL-ESTE/Student-Workflow-…
e0f65e8 
…Organizer
@bellaabdelouahab
enhance - add base routes for Calendar
09deb18
@bellaabdelouahab
fix - add metadata to event model
46f3fd7
@bellaabdelouahab
fix - update calendar routes
2772e48
@bellaabdelouahab
fix add gitignore in base dir
18c8b08
@bellaabdelouahab
feat - add bearer extractor
65f4d18
@bellaabdelouahab
fix - api auto versioning and clean code
d7429f1
@bellaabdelouahab
fix - swagger load after app starts
f13aa58
@bellaabdelouahab
create jest config file
2e8d3c4
@bellaabdelouahab
fix - access boolean in env
9d2c3f9
@bellaabdelouahab
fix -
a331e4e 
*  required account activation
* add new impl of api version
* config jest setup & teardown
* add calendar participents routes
@bellaabdelouahab
fix - jest command not found
97ee2ab
@bellaabdelouahab
update - unit tests
cc333dc
@bellaabdelouahab
fix - keep db connection alive in all tests
2abd365
@bellaabdelouahab
inhen - signup tests working
663dba6
@bellaabdelouahab
Merge branch 'main' of https://github.com/ISIL-ESTE/Student-Workflow-…
ac32e32 
…Organizer into Calendar-model
@bellaabdelouahab
fix - tests for signup login activate
67537eb
@bellaabdelouahab
fix - signup conflict
d516110
@bellaabdelouahab
combine signip and login tests
026fa85
@bellaabdelouahab
fix - sanitize email input
0333696
@bellaabdelouahab
fix - other sql inj vulnerabilities
1ddd54a
@bellaabdelouahab
help wanted - disable signup
c9ca18f
@bellaabdelouahab
fix - restructure controllers folders
802518a
@bellaabdelouahab bellaabdelouahab added enhancement New feature or request good first issue Good for newcomers feature suggest fix used to refer a bug fix or code enhancement labels Sep 2, 2023
@bellaabdelouahab bellaabdelouahab self-assigned this Sep 2, 2023
@bellaabdelouahab bellaabdelouahab merged commit cea21c9 into ISIL-ESTE:main Sep 2, 2023
1 check failed
muttaqin1
muttaqin1 approved these changes Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@muttaqin1 muttaqin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use ts-node-dev. It's faster than nodemon.
We can use ts-config-paths to import files from non-relative path.

We can enable decorators. Then we can use typegoose to define mongoose models.Its makes so easy and enjoyable to define mongoose models!

backend-app/tsconfig.json Show resolved Hide resolved
@muttaqin1
Copy link
Collaborator

@bellaabdelouahab

@bellaabdelouahab
Copy link
Member Author

Isre i have done the first two tasks
The last one not yet, because I'm not sure how.
@muttaqin1

@muttaqin1
Copy link
Collaborator

muttaqin1 commented Sep 4, 2023 •
edited
Loading

Isre i have done the first two tasks
The last one not yet, because I'm not sure how.
@muttaqin1

visit typegoose documentation.
To enable decorators :

{
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
}

@muttaqin1
Copy link
Collaborator

@bellaabdelouahab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muttaqin1 muttaqin1 muttaqin1 approved these changes

@Khalid1G Khalid1G Awaiting requested review from Khalid1G

Assignees

@bellaabdelouahab bellaabdelouahab

Labels
enhancement New feature or request feature fix used to refer a bug fix or code enhancement good first issue Good for newcomers suggest
Projects
Student-Workflow-Organizer
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bellaabdelouahab @muttaqin1