Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: it-can/CodeIgniter
base: 7cb5f98759
...
head fork: it-can/CodeIgniter
compare: 84fed35fde
Checking mergeability… Don't worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 0 commit comments
  • 3 contributors
Commits on Nov 19, 2012
@Eco91 Eco91 Update system/database/drivers/sqlsrv/sqlsrv_driver.php
Connection error if database name contains space-characters. 
Use of MSSQL brackets => 
'USE [Database Name]' 
instead of 
'USE Database Name'
2f32890
@narfbg narfbg DB forge to use single quotes for ENUM/SET string delimiters 356d4f4
@Eco91 Eco91 Update system/database/drivers/sqlsrv/sqlsrv_driver.php d0822ce
Commits on Nov 20, 2012
@narfbg narfbg Merge pull request #2009 from Eco91/patch-2
SQLSRV - Connection error if database name contains space-characters
52e7b24
@it-can Merge branch 'develop' of git://github.com/EllisLab/CodeIgniter into …
…develop
84fed35
View
2  system/database/DB_forge.php
@@ -762,7 +762,7 @@ protected function _process_fields($create_table = FALSE)
$attributes['CONSTRAINT'] = $this->db->escape($attributes['CONSTRAINT']);
default:
$field['length'] = is_array($attributes['CONSTRAINT'])
- ? '("'.implode('","', $attributes['CONSTRAINT']).'")'
+ ? "('".implode("','", $attributes['CONSTRAINT'])."')"
: '('.$attributes['CONSTRAINT'].')';
break;
}
View
2  system/database/drivers/sqlsrv/sqlsrv_driver.php
@@ -135,7 +135,7 @@ public function db_select($database = '')
$database = $this->database;
}
- if ($this->_execute('USE '.$database))
+ if ($this->_execute('USE '.$this->escape_identifiers($database)))
{
$this->database = $database;
return TRUE;

No commit comments for this range

Something went wrong with that request. Please try again.