Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor partstat, value and status to remove code smells #15

Merged
merged 1 commit into from Oct 3, 2018

Conversation

karakayasemi
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #15 into master will increase coverage by 1.43%.
The diff coverage is 24%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #15      +/-   ##
===========================================
+ Coverage     41.76%   43.2%   +1.43%     
- Complexity      140     142       +2     
===========================================
  Files           101     101              
  Lines           929     912      -17     
  Branches        120      93      -27     
===========================================
+ Hits            388     394       +6     
+ Misses          528     505      -23     
  Partials         13      13
Impacted Files Coverage Δ Complexity Δ
.../edu/itu/cavabunga/lib/entity/parameter/Value.java 11.11% <0%> (+5.55%) 1 <0> (ø) ⬇️
.../edu/itu/cavabunga/lib/entity/property/Status.java 26.66% <21.42%> (+19.52%) 2 <1> (+1) ⬆️
...u/itu/cavabunga/lib/entity/parameter/Partstat.java 26.66% <50%> (+22.5%) 2 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d7fcf...b0f832e. Read the comment docs.

@karakayasemi karakayasemi merged commit b889693 into master Oct 3, 2018
@karakayasemi karakayasemi deleted the fix-scrutinizer-smells branch October 3, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants