From 8a60e93c603b95134ba224fbe3dfa1865b00d168 Mon Sep 17 00:00:00 2001 From: mtfishman Date: Wed, 1 Oct 2025 12:41:25 -0400 Subject: [PATCH 1/3] Unbreak fixed acoth tests --- .gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 10593a9a..7085ca87 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,10 @@ .vscode/ Manifest.toml benchmark/*.json +dev/ +docs/LocalPreferences.toml docs/Manifest.toml docs/build/ docs/src/index.md +examples/LocalPreferences.toml +test/LocalPreferences.toml From 7a9f329031262ceea2115caf0cc11362d448c004 Mon Sep 17 00:00:00 2001 From: mtfishman Date: Wed, 1 Oct 2025 12:41:42 -0400 Subject: [PATCH 2/3] Bump version --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index f22daa01..338cbc82 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "BlockSparseArrays" uuid = "2c9a651f-6452-4ace-a6ac-809f4280fbb4" authors = ["ITensor developers and contributors"] -version = "0.10.5" +version = "0.10.6" [deps] Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e" From cbe589057b5189dfc24ccb382f37e80285dbdcc2 Mon Sep 17 00:00:00 2001 From: mtfishman Date: Wed, 1 Oct 2025 16:39:45 -0400 Subject: [PATCH 3/3] Skip broken acoth test --- test/test_factorizations.jl | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/test/test_factorizations.jl b/test/test_factorizations.jl index 6c6a695f..e9d9dc38 100644 --- a/test/test_factorizations.jl +++ b/test/test_factorizations.jl @@ -31,7 +31,7 @@ using MatrixAlgebraKit: trunctol using Random: Random using StableRNGs: StableRNG -using Test: @inferred, @test, @test_broken, @test_throws, @testset +using Test: @inferred, @test, @test_throws, @testset @testset "Matrix functions (T=$elt)" for elt in (Float32, Float64, ComplexF64) for matrixt in (Matrix, AbstractMatrix) @@ -55,13 +55,10 @@ using Test: @inferred, @test, @test_broken, @test_throws, @testset for f in MATRIX_FUNCTIONS_LOW_ACCURACY @eval begin fa = $f($a) - if !Sys.isapple() && ($elt <: Real) - # `acoth` appears to be broken on this matrix on Windows and Ubuntu - # for real matrices. - @test_broken Matrix(fa) ≈ $f(Matrix($a)) rtol = √eps(real($elt)) - else - @test Matrix(fa) ≈ $f(Matrix($a)) rtol = √eps(real($elt)) - end + # `acoth` appears to be broken on this matrix on Windows and Ubuntu + # for real matrices. + skip = !Sys.isapple() && ($elt <: Real) + @test Matrix(fa) ≈ $f(Matrix($a)) rtol = √eps(real($elt)) skip = skip @test fa isa BlockSparseMatrix @test issetequal(eachblockstoredindex(fa), [Block(1, 1), Block(2, 2)]) end