Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Videos are stretched or cropped #425

Closed
adro79 opened this issue Jun 24, 2024 · 0 comments
Closed

[BUG] Videos are stretched or cropped #425

adro79 opened this issue Jun 24, 2024 · 0 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@adro79
Copy link

adro79 commented Jun 24, 2024

Describe the bug
Some videos have large stretching or aren't fit properly on screen when opening from timeline or album. It fixes itself when you swipe from another image/video.

To Reproduce
Steps to reproduce the behavior:

  1. Open video from timeline/album

Screenshots
Wrong:
Screenshot_20240624-134916.png
Correct:
Screenshot_20240624-134936.png

Smartphone (please complete the following information):

  • Device: Google Pixel 7 Pro
  • OS: Graphene OS (Android 14)
  • Version: 1.2.1 and latest build

Additional context
I think it tries to stretch the to the screen ratio rather than the actual video ratio, I tested screen recording and it plays nice.

@adro79 adro79 added the bug Something isn't working label Jun 24, 2024
@IacobIonut01 IacobIonut01 added the duplicate This issue or pull request already exists label Jun 24, 2024
IacobIonut01 added a commit that referenced this issue Jul 13, 2024
Now using sanghun's compose video player to handle the logic

Fixes [BUG] Videos are stretched or cropped #425
Fixes [BUG] Videos are stretched #420

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>
IacobIonut01 added a commit that referenced this issue Sep 1, 2024
* Update dependencies, kotlin and setup 3.0.0 development

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Introduce Vaults

Encrypt your Media in a secure folder only accessible by your credentials

The vaults and media and their info are completely encrypted and stored in the app's private folder.
The encryption is a standard AES256_GCM scheme, but customisable options are on their way (with option to backup/restore the vault)

Fixes Ability to hide photos/videos in a hidden folder within the app #232
Fixes Hidden folders[Enhancement] #402

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix sha256 generation script

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Redesign First-Launch Setup

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Add Library Screen

Work in Progress, currently the only way to access Trash, Favorites and Vault.
But more features to come

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Various fixes to Vault

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Revert "Gallery: Improve scroll speed in media grid"

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix sha256 generation once again

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Vault: Set secure mode while viewing

Hides the gallery screen in the recents apps or in screenrecording (and screenshots) to protect users privacy to their hidden content

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Various fixes to VideoPlayer

Now using sanghun's compose video player to handle the logic

Fixes [BUG] Videos are stretched or cropped #425
Fixes [BUG] Videos are stretched #420

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Update subsampling library, Update coil and add avif support

Also fixes Using double tap to zoom #399

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Update major dependencies

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Add avif coder dependency

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Cursor: Fix media not being retriven when stored in a null bucket

This happens when you want to display images stored in the root of the phone's storage (Internal Storage)

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Merge changes last nightly

This is the last nightly before the 3.0.0 release
Expect bugs (do not report yet)
Might require app data clear or reinstall

The built-in image editor is currently disabled as is facing a major re-work

Includes, but not limited to:
- Settings for auto-hide search/navigation bar
- Switched from coil to sketch for image loading
- Switched from zoomable to zoomimage/sketch for image subsampling
- Reduced unecessary recompositions
- Added total 'Images & Videos' counter at the bottom of the Album screen
- Added total Album media size after counter (eg: 1011 items (628.20MB))
- Improved Album sorting UI
- Improvements to Vault (now limited to Images only)
- Improvements to Ignored Albums
* New Setup UI for creating new Ignored Albums
* Added wildcard patterns (Regex) for hiding multiple albums at once
* Added visibility option for hiding the albums (and it's medie content) either only in timeline, album screens or both
* Added more information about the created Ignored Albums
- Re-arranged Settings screen
- Updated major dependecies
- Added avif support
- Improved video player

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Launch media state collecting only once, no need to be recreated on resume

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix leaking buffers for Heif and Jxl decoders

Also reduce the image type detection to mimeType

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Gallery: 3.0.0-30033 Release

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

---------

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants