Even slower slowGC #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I changed the wait to 1 second, and the test completed successfully. |
IanButterworth
force-pushed
the
ib/slower_slowgc
branch
from
45ba2da to
cd99da9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #32 Windows seems to sometimes hang on to files, even after GC has completed. I'm hoping just a longer pause will help
It's worth saying that this package is in need of love. It was put together quite quickly and saw wide use, but it's sorely in need of a refactor and review of the tests done
cc. @PetrKryslUCSD
Fixes #24
Fixes #32