Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type/non-type sorting #47

Merged
merged 1 commit into from Oct 27, 2022
Merged

Fix type/non-type sorting #47

merged 1 commit into from Oct 27, 2022

Conversation

IanVS
Copy link
Owner

@IanVS IanVS commented Oct 27, 2022

We had a bug, identified by @mattiaz9 in #35 (comment), which was causing the "^[./]" group to include both type and value imports, instead of only value imports.

This PR fixes that bug, and expands both the unit and e2e tests, which fail without this change and pass with it.

@IanVS IanVS merged commit 6f5cbbc into main Oct 27, 2022
6 checks passed
@IanVS IanVS deleted the fix-type-sorting branch October 27, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant