This repository was archived by the owner on Dec 22, 2022. It is now read-only.
Repository navigation
Adding Rspec tests for random bounding box - #4
Merged
Merged
Conversation
Member
|
Thanks! I think there is possibly still some edge cases when dealing with the coordinate border cases and bounding boxes. |
Member
|
Since this is owned by Ibotta, do you mind adding me to the rubygems owners? |
Author
|
@onyxraven I just added you. Let me know if that worked. |
Member
|
yep, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. I added a test for the randomly generated bounding boxes and notes about my research into why I think the tests were breaking down.
I published the gem to version 0.2.1 as well.