Add Set removal operations that throw on failure. #77

jmalloc opened this Issue Mar 4, 2014 · 0 comments


None yet
1 participant

jmalloc commented Mar 4, 2014

Currently, Set::remove*() returns a boolean indicating whether the element(s) being removed were found. We need a variant of this operation that throws if the element is not found.

I'd prefer to rename the existing operations to discard*() and change remove*() into the strict variants. This matches Python's set type and some others, however this is a BC break with very little justification. So failing that we need to come up with a good name and I tend to dislike things like removeStrict()... what's it being strict about? Further to that 'strict' already has a pretty specific meaning in set theory.

@jmalloc jmalloc added this to the 2.0.0 milestone Mar 4, 2014

@jmalloc jmalloc added feature labels Mar 4, 2014

@jmalloc jmalloc removed the feature label Mar 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment