Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #2681] Confusing use of display_name in JSON and CSV output #1002

Closed
icinga-migration opened this issue Jun 12, 2012 · 6 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jun 12, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2681

Created by trehn on 2012-06-12 21:28:28 +00:00

Assignee: ricardo
Status: Resolved (closed on 2012-06-18 11:51:42 +00:00)
Target Version: 1.7.1
Last Update: 2014-12-08 09:42:46 +00:00 (in Redmine)

Icinga Version: 1.10.0
OS Version: any

Currently the host and service names provided via JSON/CSV come from display_name (if it is defined) or the internal name (if display_name is not defined). This is bad because a client cannot be sure if they're seeing a display_name or a normal name. Furthermore, the display_name cannot be used to submit commands and does not appear in the JSON/CSV output for host and service groups.

I will attach a patch that removes the abiguous behavior and (in JSON) exposes the display_name explicitly in a separate attribute. This way clients using JSON can issue commands to the correct hostnames, link hosts to hostgroups and still display pretty names.

Attachments

Changesets

2012-06-12 23:12:59 +00:00 by (unknown) 985bd5a

classic-ui: don't be ambiguous about display_name in JSON and CSV output #2681

refs: #2681

Signed-off-by: Ricardo Bartels <ricardo@bitchbrothers.com>

2012-06-12 23:26:17 +00:00 by ricardo 9d21426

classic-ui: applyed last commit to other cgi's as well #2681

refs: #2681

2012-06-15 15:17:25 +00:00 by mfriedrich 7ee849e

correct Changelog on committer RB, update THANKS for patch providers

refs #2680
refs #2681
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 12, 2012

Updated by trehn on 2012-06-12 21:28:41 +00:00

  • File added 0001-classic-ui-2681-don-t-be-ambiguous-about-display_nam.patch
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 12, 2012

Updated by trehn on 2012-06-12 21:30:59 +00:00

  • File added 0002-classic-ui-2681-don-t-be-ambiguous-about-display_nam.patch
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 12, 2012

Updated by mfriedrich on 2012-06-12 21:40:44 +00:00

  • Status changed from New to Assigned
  • Assigned to set to ricardo

thanks. sounds rather logical to expose that a bit different in an export, than the gui layer shows it. for what it's worth it might be worth discussing to explicitely export that within csv as well, as seperated column. though i am not sure if that will existing parsers.

@ricardo - please have a look into.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 12, 2012

Updated by ricardo on 2012-06-12 23:35:56 +00:00

  • Status changed from Assigned to Feedback
  • Target Version set to 1.7.1
  • Done % changed from 0 to 90

in current rbartels/cgi

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 18, 2012

Updated by mfriedrich on 2012-06-18 11:51:42 +00:00

  • Status changed from Feedback to Resolved
  • Done % changed from 90 to 100
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:42:46 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category set to Classic UI
  • Icinga Version set to 1
  • OS Version set to any
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.