Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #2697] host/service selection for commands, leave out passive only checks on check reschedule in cmd.cgi #1011

Closed
icinga-migration opened this issue Jun 20, 2012 · 21 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Jun 20, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2697

Created by mfriedrich on 2012-06-20 08:04:04 +00:00

Assignee: ricardo
Status: Resolved (closed on 2012-09-03 17:35:04 +00:00)
Target Version: 1.8
Last Update: 2014-12-08 09:27:19 +00:00 (in Redmine)


we are using the compound commands quite extensively, but in combination with check_mk (which got a special action_url to run the check_mk related command itsself).

now the thing is - the long list of "mark all" tick also marks the passive hosts/services, and this is totally fine when you want to acknowledge a problem.

but the specific command "reschedule checks for these services" also affects the passive hosts/services - which normally leads into a call on the command which is defined for freshness checking only. guess what happens - everything fucked up on the current check schedule.

i know that pre-filtering in the gui is difficult, but i'd like to propose a dedicated filter for cmd.cgi

  • if the host/service is passive only (not active+passive!) do not allow it to be re-scheduled for a check
  • this should be the default. if someone wants the old behaviour, restore it with a config option, or require the user to re-select it on the cmd.cgi once more (or similar).

since we already rewrote the tac.cgi in order to show "only passive hosts/services", it think it's worth adding such an enhancement filter as well.

what do others think?

Attachments

Changesets

2012-08-17 23:33:05 +00:00 by ricardo 449580e

classic-ui: Added host/service selection for commands, leaving out passive only checks on check reschedule in cmd.cgi #2697

refs: #2697

passive checks get disable for:
* CMD_SCHEDULE_HOST_CHECK
* CMD_DISABLE_HOST_CHECK
* CMD_SCHEDULE_SVC_CHECK
* CMD_DISABLE_SVC_CHECK

now you have a checkbox on every line when sending a command, where you can enable/disable
the host/service if you like to.

Enjoy!

2012-08-20 14:57:53 +00:00 by ricardo 2949ee4

classic-ui: Added "Select All" checkbox to cmd.cgi host/service list #2697

refs: #2697

* Added "Select All" checkbox
* Added title to checkboxes (active / passive)

2012-08-31 12:53:31 +00:00 by mfriedrich 372daa3

classic ui: add passive icon to scheduled checks on cmd.cgi, table header new background #2697

refs #2697

2012-09-18 23:18:25 +00:00 by ricardo 192d429

classic-ui: Added host/service group filter to notifications.cgi & history.cgi #2679

refs: #2697

notifications and history can be filtered with "hostgroup" and "servicegroup" param.
added links to status.cgi to access it easily

2012-09-24 21:20:09 +00:00 by ricardo 700d5e0

classic-ui: moved passive icons in cmd.cgi a bit, not sticking to cell border #2697

refs: #2697
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2012

Updated by mjbrooks on 2012-07-25 23:14:26 +00:00

I agree that a host/service that is fully passive shouldn't be allowed to be re-scheduled by default.

The passive hosts/service could maybe be listed separately on the confirmation page with an additional "re-schedule these passive hosts/services too" check box.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2012

Updated by mfriedrich on 2012-07-26 06:56:21 +00:00

cool idea! +1 from me :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2012

Updated by mfriedrich on 2012-07-31 19:00:59 +00:00

  • Category set to 53
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 1.8
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2012

Updated by mfriedrich on 2012-08-01 01:07:03 +00:00

we could modify print_object_list, and add a second param, indicating the cmd_type.

then there is a further problem - the passed host/service strings are not checked for integrity (so no find_host|service() calls) so we actually need to do that in order to filter out "passive only" hosts/services - this might decrease performance on the cmd.cgi form.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2012

Updated by ricardo on 2012-08-17 23:36:42 +00:00

  • Category changed from 53 to 52
  • Status changed from Assigned to 7
  • Done % changed from 0 to 90

in current 'dev/cgis'

please Test and tell me what you think.

passive checks get disable for:
* CMD_SCHEDULE_HOST_CHECK
* CMD_DISABLE_HOST_CHECK
* CMD_SCHEDULE_SVC_CHECK
* CMD_DISABLE_SVC_CHECK
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2012

Updated by tgelf on 2012-08-18 09:33:35 +00:00

I like this feature, but I'd also opt for special care when implementing it. I'm aware of environments where people really want to reschedule passive-only checks having freshness-checking disabled. One example that comes to my mind is a specialized check daemons providing aggregating thousands of SNMP Traps and sending aggregated passive check results to different Icinga services. The "reschedule" is (miss?)used to tell the deamon to reset it's knowledge at a specific aggregation level.

Others have managed it to set up working reschedule mechanisms in distributed environments. Listing passive checks separately as suggested by mjbrooks is much better. From a usability point of view I think someone choosing a passive only check for reschedule shall not be forced to declare "Yes, I want to do this with this passive only check". Usually in that situation he knows what he is doing. Therefore I'd suggest the following: if someone selects only passive checks when submitting a command, he could be shown a warning message telling him that he did so. However he should still be able to reschedule them without additional clicks.

Cheers,
Thomas

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2012

Updated by ricardo on 2012-08-18 09:46:30 +00:00

Have you tested it?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2012

Updated by tgelf on 2012-08-19 09:20:36 +00:00

Hi Ricardo!

No, I didn't test it yet - shall I? I stumbled over Michis "what do others think?", and as I know more than one environment where they are regularly rescheduling passive-only service checks I wanted to add my thoughts.

Cheers,
Thomas

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2012

Updated by ricardo on 2012-08-19 13:29:55 +00:00

I would appreciate if vould test the patch.

I could also add a select all checkbox. With this it should fullfill every need.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2012

Updated by mfriedrich on 2012-08-19 14:19:03 +00:00

  • Assigned to changed from mfriedrich to ricardo

i will test that after hunting #2993

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2012

Updated by mfriedrich on 2012-08-19 17:56:50 +00:00

  • File added icinga_classicui_2697_active_passive_checks_cmd_cgi.png

looks pretty good. meaning to say - f*cking awesome for my report :)
but as thomas remarked, a one-click-select-all buttom should be there (maybe on top and bottom).

icinga_classicui_2697_active_passive_checks_cmd_cgi.png

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2012

Updated by mfriedrich on 2012-08-19 18:03:53 +00:00

either way - this works with the other checkboxes as well, and only the passive checks will be excluded.

Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;1228localhost-flexible;1228ORACLESTANDBY;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;1300localhost;DISEÑOS;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;1300localhost;dep1;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;1300localhost;dep2;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;1300localhost;dep3;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;2546localhost_forker;2546 forker test;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;2616localhost;2616ido2db Process;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;host_001;warning_04;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;host_007;critical_04;1345399260
Aug 19 20:01:07 imagine icinga: EXTERNAL COMMAND: SCHEDULE_FORCED_SVC_CHECK;host_008;warning_09;1345399260

aren't the checkboxes themselves a new feature at all? if so, please add a new issue for that, marking it a feature. as well as add a CHANGES entry to Changelog then.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2012

Updated by ricardo on 2012-08-20 15:01:12 +00:00

  • File added select_all.jpg

Added "Select All" checkbox

select_all.jpg

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2012

Updated by mfriedrich on 2012-08-20 19:40:58 +00:00

  • File added icinga_classicui_2697_active_passive_checks_cmd_cgi_check_all.png

works as expected.

  • the check all box is in place
  • moving the mouse over the checkbox will tell you if active or passive - awesome idea!

icinga_classicui_2697_active_passive_checks_cmd_cgi_check_all.png

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2012

Updated by tgelf on 2012-08-20 19:46:14 +00:00

Looks great. How about showing icons with tooltips instead of expecting that people want to hover each single checkbox? There is plenty of space available...

Regards,
Thomas

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2012

Updated by ricardo on 2012-08-20 20:25:36 +00:00

@tgelf: Go for it!

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2012

Updated by mfriedrich on 2012-08-31 12:51:23 +00:00

  • File added icinga_classicui_2697_show_passive_icon_table_header.png

i've done a little work on that.

  • the header of the table now uses the same background color as the status.cgi - that allows to identify the "check all" box a bit better, as it's the exact same position like you already know for years now. at least for me this is important.
  • if the host/service is passive, it will align the passive icon on the right table column, like known from status.cgi as well.

icinga_classicui_2697_show_passive_icon_table_header.png

imho those changes will allow users to identify the command table with the select boxes even better, as the style goes hand in hand with the status table.

thoughts?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2012

Updated by mfriedrich on 2012-09-02 07:47:46 +00:00

what comes to mind - since we already read the status file on cmd.cgi now, we do have all the states within the objects as well.

we could use the status.cgi color scheme for the background as well, indicating the current status of the service again on $whateveraction. what do you think - confusing or helpful?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2012

Updated by mjbrooks on 2012-09-02 08:40:41 +00:00

Wicked awesome job on this guys.

@dnsmichi would it be much trouble to do a mock-up of what it would look like with the color? I like the idea, but it might be too busy visually taking one's eyes away from the checkboxes which are key to this page. Perhaps a column of empty appropriately colored squares to the left of the checkbox might work better?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2012

Updated by mfriedrich on 2012-09-03 17:35:04 +00:00

  • Status changed from 7 to Resolved
  • Done % changed from 90 to 100

hm. i'll leave the coloring for an extra issue. my initial request is more than resolved, thank you ricardo.

i think people should get to know the extra tick column, as well as the difference on rescheduling passive checks or not. and not getting confused by the coloring, etc.

we can discuss the coloring schema in a different issue if needed. for me, it's resolved.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:27:20 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 52 to Classic UI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.