Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #2740] add option for partial servicegroups #1016

Closed
icinga-migration opened this issue Jun 28, 2012 · 14 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jun 28, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2740

Created by Vega82 on 2012-06-28 08:21:43 +00:00

Assignee: ricardo
Status: Resolved (closed on 2013-09-27 18:21:53 +00:00)
Target Version: 1.10
Last Update: 2014-12-08 09:27:22 +00:00 (in Redmine)


For Example:
I have some checks as "Check Load", "Check Memory", ... assigned to servicegroup "Linux OS Servicechecks"

These checks are also assigned to a hostgroup called "Linux Servers".
This hostgroup contains any hosts owned by different contacts.

So it should be possible that every contact can see the servicegroup "Linux OS Servicechecks" with service checks, owned by his hosts.

Changesets

2013-09-22 21:05:55 +00:00 by ricardo ea38b80

classic-ui: added option for partial servicegroups #2740

* adds new config option "show_partial_servicegroups"
* same behavior as "show_partial_hostgroups" just for servicegroups
* some bugs on "show_partial_hostgroups" where found and got fixed
* calculating and displaying of hostgroups in general should be faster now

Got so bored at the bus on the way home from Linux Hotel.
Someone owes me a beer now ;-)

refs: #2740

2013-09-25 19:47:41 +00:00 by ricardo 68d2506

Merge branch 'feature/add_partial_servicegroups-2740' into next

Conflicts:
	Changelog

fixes: #2740

2013-09-26 14:57:07 +00:00 by ricardo 99ce3dc

classic-ui: fix for last commit, hostgroup overview works now #2740

refs: #2740
whatthecommit.com: A fix I believe, not like I tested or anything

2013-09-26 14:59:47 +00:00 by ricardo ec6c94e

Merge branch 'feature/add_partial_servicegroups-2740' into next

fixes: #2740

2013-10-04 00:03:54 +00:00 by ricardo 26fd28c

classic-ui: fixed displaying of servicegroup name #2740

refs: #2740

2013-10-04 00:16:31 +00:00 by ricardo e661c23

Merge branch 'feature/add_partial_servicegroups-2740' into next

fixes: #2740

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 28, 2012

Updated by mfriedrich on 2012-06-28 08:38:37 +00:00

that requires some nested loops to actually step from the servicegroup -> service -> host (-> hostgroup) and gather all the needed information to actually filter the authorization.

i guess this will add a performance impact, decreasing it slightly. though someone should profile that once implemented.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Aug 27, 2012

Updated by ricardo on 2012-08-27 18:57:10 +00:00

  • Status changed from New to Feedback
  1. I still don't get it.
  2. Is this still necessary?
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 3, 2012

Updated by ricardo on 2012-09-03 20:41:04 +00:00

  • Status changed from Feedback to Closed

No Feedback.

Closing this one. Reopen if needed.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 21, 2012

Updated by Vega82 on 2012-09-21 16:00:44 +00:00

Still needed feature.
Sorry i stayed in holiday the last 4 weeks.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 21, 2012

Updated by ricardo on 2012-09-21 16:29:42 +00:00

  • Status changed from Closed to Feedback

Please describe request better.

Because, I still don't get it.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 9, 2012

Updated by ricardo on 2012-11-09 17:11:48 +00:00

on holidays again?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 9, 2012

Updated by mfriedrich on 2012-11-09 17:28:54 +00:00

i guess this is sort of "partial servicegroups", like known from the partial hostgroup feature. though, as remarked in my first comment, parsing that information in nested loops will possibly decrease performance overall (unless there will be some auth pre-caching when first page opening like icinga-web does now)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 10, 2013

Updated by Vega82 on 2013-01-10 09:39:22 +00:00

Sorry here i am again ....i got no mail notification, so i can't answer to you.

This feature is still needed, i found some threads in www and i'm not the only one who needes this feature.

Let me explain again my problem.

I want, that i can summary some checks to one servicegroup, but to multiple hosts in different hostgroups. And every nagios user should see this servicegroup with only his own hosts.

Currently i only can assign this user to this servicegroup and the he will see all hosts, which have assigned this service.
Or i assign the user to hostgroup, the he only will see the servicegroup, if he is assigned to every host with this check.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 21, 2013

Updated by ricardo on 2013-01-21 23:52:13 +00:00

believe me, this needs quite a bit of code to be changed.

I'm not sure why you don't get any notifications about this issue. But I don't agree with your tone of demanding stuff. It would be really helpful if you have a look at the code, checkout how "partial_hostgroup" is implemented and then try to write a patch I could apply and test.

And yes, now that I understood what you mean, I think it would be helpful to have this feature.

Cheers
Ricardo

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 22, 2013

Updated by mfriedrich on 2013-01-22 18:09:16 +00:00

requiring a feature requires resources to be assigned as well. since i am a bit out of resources currently (dayjob requires my full attention), i am not paying much attention to classic ui these days, only core and ido in a limited scope.

if this feature cannot be implemented by the core team (for free), someone might pay someone/somebody to implement it properly. by chance to do it based on the current source tree and pushing it back to upstream.

jm2c,
michael

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 29, 2013

Updated by mfriedrich on 2013-06-29 15:02:11 +00:00

i would vote for closing this here, instead pointing to advanced restriction possibilities with icinga web. @ricardo - you too?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 22, 2013

Updated by ricardo on 2013-09-22 21:17:21 +00:00

  • Subject changed from show servicegroup if contacts hosts have services assigned to servicegroup to add option for partial servicegroups
  • Assigned to set to ricardo
  • Target Version set to 1.10
  • Done % changed from 0 to 90

got bored on the bus home.

new config option:

# SHOW PARTIAL SERVICEROUPS
# By default (meaning the directive is not present or disabled), a user
# only sees a servicegroup and the hosts and services within it if they are an
# authorised contact for all of the hosts and services of the group.
# The behaviour can be changed using the directive show_partial_servicegroups=1.
# When enabled, the serviceroups overview will show a partial listing of hosts
# and services that the user is an authorised contact for within each servicegroup.
# It will also add the string "(Partial Servicegroups Enabled)" to the top of
# the Servicegroup Overview to help prevent any confusion over whether the option
# is in use or not. However for privacy reasons, servicegroups that are only showing
# a partial listing are not specifically indicated.
#
# Values: 0 - disabled, user only sees full servicegroups (default)
#         1 - enabled, user sees partial servicegroups

show_partial_servicegroups=0

in current "feature/add_partial_servicegroups-2740"

please test.

Someone owes me a beer now ;-)

Cheers Ricardo

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 27, 2013

Updated by ricardo on 2013-09-27 18:21:53 +00:00

  • Status changed from Feedback to Resolved
  • Done % changed from 90 to 100

Applied in changeset icinga-core:68d2506e6a3de328c1e5a1852f64aefad4383ba8.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:27:22 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 54 to Classic UI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.