Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #3412] ido2db on oracle: move output fields from varchar to clob #1157
This issue has been migrated from Redmine: https://dev.icinga.com/issues/3412
Created by Tommi on 2012-10-29 20:41:46 +00:00
output data from checks may reach up to 8k in size (or more), but oracle varchar type is limited to 4k bytes. to prevent truncating data a change to clob (character large object) is required
2012-10-31 18:42:52 +00:00 by Tommi 286e0d8fde31d7296cc710a67697a86ec38faff7
2012-10-31 20:22:17 +00:00 by Tommi aac510047471476617b2138150d7cab4d0424225
2012-10-31 20:59:03 +00:00 by Tommi 448fb46632d9100295b0599b2c1779038fcdd2a4
2013-03-11 21:16:32 +00:00 by Tommi 8584e505fda90de8311810c282481ea9eb8ac505
2013-03-11 21:20:42 +00:00 by Tommi 0604961c655db069bce2b3b03419f878012ca367
2013-03-11 21:20:42 +00:00 by Tommi 985851bac9ec3402b1772b95f5c12903c464c991
2013-04-16 07:35:24 +00:00 by Tommi 4eb4467
2013-04-16 07:35:45 +00:00 by Tommi 4384f2d
2013-04-16 07:35:45 +00:00 by Tommi a4fadf2
Updated by mfriedrich on 2012-10-30 16:41:35 +00:00
for the upgrade sqls - i've prepared them from 'next' on, if you merge dev/ido in your dev tree for 1.9, you'll get them for free - insert your very own changes needed, and then commit on top of that merged history.
Updated by mfriedrich on 2013-03-11 20:55:12 +00:00
well given the size of the diff, i consider this as a feature, and not suitable for a bugfix release. that's the main reason why i refuse to add such "rewrites" into the fixed tree, where new additions will create new bugs and so on. you know the game.
regarding tests - if we all know where this can be found, we all could test (and merge it). so i was asking about that, and now i can actually do that with my oracle xe install.
Updated by mfriedrich on 2013-03-11 22:13:07 +00:00
rebasing failed due to some seq_name and notification id rewrites, but generally resolved in the dev/ido tree with a rewind and rebase putting the commits on top the current tree.
lives now in 'test/ido' for further tests.
Updated by Tommi on 2013-03-13 21:16:22 +00:00
i rebased my tree with dev/ido, dont know why it made additional commits. Compiles fine, no problems with installing and running so far.
regarding tests i would expect to get it tested atleast from gunnar because he raised the request. Since you are working now in the same company you can discuss this face to face
Updated by mfriedrich on 2013-03-13 23:07:12 +00:00
well i had to fix mysql - see #3408
good. i guess you now understand why i don't want such changes in minor bugfix releases with such side effects.
mhm. and what i do in my spare time while working on these issues does not render my work stuff related to coordinate the communication between you two. if you got a problem with gunnar's feedback, get in touch with him in person and in private - as two adults. i've already taken the liberty to coordinate the code fixes and actually test them myself - as core release manager.
Updated by mfriedrich on 2013-04-06 22:20:05 +00:00
rebranched into mfriedrich/clob until the web issue is resolved.
Updated by mfriedrich on 2013-04-16 09:14:11 +00:00
by resolving #3965 this has been run as test branch in order to fully see output/long_output/perfdata in the making, and will allow us to properly merge this into 1.9 - mfriedrich/clob is already rebased against current next for those tests. thanks for implementing and fixing.
further final tests are still required.