Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #3418] cmd.cgi does not honor commandpipe location; overwrites from empty environment variable #1161

Closed
icinga-migration opened this issue Nov 2, 2012 · 5 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Nov 2, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3418

Created by mfriedrich on 2012-11-02 21:51:15 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2012-11-09 14:40:52 +00:00)
Target Version: 1.8.2
Last Update: 2014-12-08 09:27:49 +00:00 (in Redmine)

Icinga Version: 1.8.1
OS Version: any

this is due to the change introduced with #3106 where cmd.cgi tries to read the environment variable, but if it fails, it does not take the config file, but rather the compiled into DEFAULT_COMMAND_FILE.

solution - fix the get_cmd_file_location() to return the proper location read from configs (if that's empty, go for the DEFAULT_COMMAND_FILE)

Attachments

Changesets

2012-11-02 22:21:55 +00:00 by mfriedrich 70253ef

classic ui: fix cmd.cgi does not honor commandpipe location; overwrites from empty environment variable refs #3418
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2012

Updated by mfriedrich on 2012-11-02 21:51:59 +00:00

  • File added icinga_classic_1.8.1_3418_cmd.cgi_wrong_commandpipe.png

icinga_classic_1.8.1_3418_cmd.cgi_wrong_commandpipe.png

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2012

Updated by mfriedrich on 2012-11-02 21:52:23 +00:00

in icinga.cfg for testing

command_file=/var/icinga/icinga_test.cmd
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2012

Updated by mfriedrich on 2012-11-02 22:23:35 +00:00

  • Status changed from Assigned to 7
  • Done % changed from 0 to 100

now the fallback for the environment check is to use the commandfile var, and fully ignore the compiled into one.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2012

Updated by ricardo on 2012-11-09 14:40:52 +00:00

  • Status changed from 7 to Resolved
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:27:49 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 53 to Classic UI
  • OS Version set to any
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.