Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #3419] ido2db does not cleanly exit the client on wrong schema version check in db_hello #1162

Closed
icinga-migration opened this issue Nov 2, 2012 · 4 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Nov 2, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3419

Created by mfriedrich on 2012-11-02 23:11:12 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2012-11-09 16:54:46 +00:00)
Target Version: 1.8.2
Last Update: 2014-12-08 14:37:56 +00:00 (in Redmine)

Icinga Version: 1.10.0
OS Version: any

within ido2db.c there's the first db_hello call, causing a protocol and also db schema version check. if either one of them returns an error, the caller just ignores that, and goes on with data inserts.

problem at this stage - the instance id is likely not fetched at this stage, being 0 as db_hello did not select nor populate it correctly.

this is likely a possible fix for #3326 too (and many other issues with data duplication on upgrade when the upgraded schema version was not in place, bailing too early).

Changesets

2012-11-02 23:24:55 +00:00 by mfriedrich 7a9ff72

idoutils: fix ido2db does not cleanly exit the client on wrong schema version check in db_hello refs #3419

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2012

Updated by mfriedrich on 2012-11-02 23:12:47 +00:00

Nov  3 00:11:46 sol ido2db: IDO2DB 1.9.0dev (04-25-2013) Copyright(c) 2005-2008 Ethan Galstad, Copyright(c) 2009-2012 Icinga Development Team (https://www.icinga.org)
Nov  3 00:11:46 sol ido2db: IDO2DB 1.9.0dev starting... (PID=9935)
Nov  3 00:11:46 sol ido2db: Finished daemonizing... (New PID=9937)
Nov  3 00:11:47 sol icinga: Caught SIGTERM, shutting down...
Nov  3 00:11:48 sol icinga: Successfully shutdown... (PID=672)
Nov  3 00:11:48 sol icinga: Warning: Empty definition found in file '/etc/icinga/test-conf/etc/services.cfg' on line 5.
Nov  3 00:11:48 sol icinga: Icinga 1.9.0dev starting... (PID=9968)
Nov  3 00:11:48 sol icinga: Local time is Sat Nov 03 00:11:48 CET 2012
Nov  3 00:11:48 sol icinga: LOG VERSION: 2.0
Nov  3 00:11:48 sol icinga: idomod: IDOMOD 1.9.0dev (04-25-2013) Copyright(c) 2005-2008 Ethan Galstad, Copyright(c) 2009-2012 Icinga Development Team (https://www.icinga.org)
Nov  3 00:11:48 sol ido2db: Client connected, data available.
Nov  3 00:11:48 sol icinga: idomod: Successfully connected to data sink.  0 queued items to flush.
Nov  3 00:11:48 sol icinga: Event broker module 'IDOMOD' version '1.9.0dev' from '/usr/lib/idomod.so' initialized successfully.
Nov  3 00:11:48 sol ido2db: Handling client connection...
Nov  3 00:11:48 sol icinga: Warning: Empty definition found in file '/etc/icinga/test-conf/etc/services.cfg' on line 5.
Nov  3 00:11:48 sol ido2db: Successfully connected to mysql database
Nov  3 00:11:48 sol ido2db: Error: DB Version Check against mysql database query failed! Please check mysql database configuration and schema!
Nov  3 00:11:48 sol ido2db: Exiting ...
Nov  3 00:11:48 sol ido2db: Error: Initial DB Handshake failed.  Disconnecting client...
Nov  3 00:11:48 sol ido2db: Successfully disconnected from mysql database
Nov  3 00:11:48 sol ido2db: Successfully shutdown... (PID=9969)
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2012

Updated by mfriedrich on 2012-11-02 23:30:45 +00:00

  • Status changed from Assigned to 7
  • Done % changed from 0 to 100
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2012

Updated by mfriedrich on 2012-11-09 16:54:46 +00:00

  • Status changed from 7 to Resolved

confirmed working by http://monitoring-portal.org/wbb/index.php?page=Thread&postID=179718#post179718

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 14:37:56 +00:00

  • Project changed from 18 to Core, Classic UI, IDOUtils
  • Category changed from 79 to IDOUtils
  • Icinga Version changed from 1 to 1
  • OS Version set to any

@icinga-migration icinga-migration added this to the 1.8.2 milestone Jan 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.