Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #3720] Allow exclude (!) to work for regexp matches as well. #1212
This issue has been migrated from Redmine: https://dev.icinga.com/issues/3720
Created by liedekef on 2013-02-20 15:14:45 +00:00
This link contains the whole patch (the patch also works when just regexp is turned on, use_true_regexp_matching is not needed):
I confirm that it works at least for the hosts+regex as expected. But maybe there are known side-effects or is this undesirable?
2013-06-22 16:29:06 +00:00 by (unknown) 3723404
2013-07-20 10:53:22 +00:00 by (unknown) 10d2cb0
Updated by liedekef on 2013-02-22 09:42:10 +00:00
Sure. I now patched the whole xodtemplate.c file (see attachment).
Updated by mfriedrich on 2013-03-20 09:30:23 +00:00
i was planning to look into it. if this is not applicable for 1.9 i'll reschedule it once i got time to test it myself.
Updated by mfriedrich on 2013-04-06 23:33:32 +00:00
patch does not apply cleanly against current dev tree, and since there definitely is more testing required, i'm rescheduling this due to feature freeze in order not to harm the release quality.
Updated by mfriedrich on 2013-06-22 16:31:48 +00:00
Kudos should be preserved to the original author of the patch back in 2008. lives now in git https://git.icinga.org/?p=icinga-core.git;a=shortlog;h=refs/heads/feature/exclude-with-regexp-3720 - can you re-test that one please?