Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #3720] Allow exclude (!) to work for regexp matches as well. #1212

Closed
icinga-migration opened this issue Feb 20, 2013 · 8 comments

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Feb 20, 2013

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3720

Created by liedekef on 2013-02-20 15:14:45 +00:00

Assignee: liedekef
Status: Resolved (closed on 2013-09-14 14:37:04 +00:00)
Target Version: 1.10
Last Update: 2013-09-14 14:37:04 +00:00 (in Redmine)


This link contains the whole patch (the patch also works when just regexp is turned on, use_true_regexp_matching is not needed):

http://permalink.gmane.org/gmane.network.nagios.devel/5338

I confirm that it works at least for the hosts+regex as expected. But maybe there are known side-effects or is this undesirable?

Attachments

Changesets

2013-06-22 16:29:06 +00:00 by (unknown) 3723404

core: allow exclude (!) to work for regexp matches as well

only works when regexp are enabled, the only behavioural change is that
the check now happens sooner, setting a flag/ptr increment.

refs #3720

2013-07-20 10:53:22 +00:00 by (unknown) 10d2cb0

config parser: fix missing exclude on host expansion

refs #3720
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Feb 21, 2013

Updated by mfriedrich on 2013-02-21 19:20:17 +00:00

that's a patch against nagios 3.0.3 - did you create one yourself against icinga's latest release and test that? can i see that patch in case?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Feb 22, 2013

Updated by liedekef on 2013-02-22 09:42:10 +00:00

  • File added xodtemplate.diff

Sure. I now patched the whole xodtemplate.c file (see attachment).
So now I'm able to do this for a service definition:

        hostgroup_name                  .*,!rhel4
        host_name                       !..ac.*,!..glo.*,!.*db$
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 20, 2013

Updated by liedekef on 2013-03-20 09:27:43 +00:00

Is there any news on this? I'm running this patch for over a month now for 373 hosts and 5330 services and had no issues whatsoever, so I hope it gets included in the next version ...

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 20, 2013

Updated by mfriedrich on 2013-03-20 09:30:23 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 1.9

i was planning to look into it. if this is not applicable for 1.9 i'll reschedule it once i got time to test it myself.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 6, 2013

Updated by mfriedrich on 2013-04-06 23:33:32 +00:00

  • Target Version changed from 1.9 to 1.10

patch does not apply cleanly against current dev tree, and since there definitely is more testing required, i'm rescheduling this due to feature freeze in order not to harm the release quality.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 22, 2013

Updated by mfriedrich on 2013-06-22 16:31:48 +00:00

  • Status changed from Assigned to 8

Kudos should be preserved to the original author of the patch back in 2008. lives now in git https://git.icinga.org/?p=icinga-core.git;a=shortlog;h=refs/heads/feature/exclude-with-regexp-3720 - can you re-test that one please?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 20, 2013

Updated by mfriedrich on 2013-07-20 10:55:27 +00:00

  • Assigned to changed from mfriedrich to liedekef
  • Done % changed from 0 to 90

fixed a missing exclude on host expansion in git next. can you please test that too?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 14, 2013

Updated by mfriedrich on 2013-09-14 14:37:04 +00:00

  • Status changed from 8 to Resolved
  • Done % changed from 90 to 100

i consider it resolved, if noone tests it before release, it will hit it anyways. but don't complain on bugs later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.