[dev.icinga.com #3854] statehistory entries for newly added services (checkresult with OK state) #1237

Closed
icinga-migration opened this Issue Mar 13, 2013 · 2 comments

Comments

Projects
None yet
1 participant
Member

icinga-migration commented Mar 13, 2013

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3854

Created by mfriedrich on 2013-03-13 20:07:10 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2014-01-03 20:03:49 +00:00)
Target Version: 1.11
Last Update: 2014-01-03 20:03:49 +00:00 (in Redmine)


an idea from sneaking around in this area. not sure if this a valid bug or feature, but it's only valid if the service is

  • newly added (has_been_checkedFALSE)

  • the checkresult is PK (stateOK)

    diff --git a/base/checks.c b/base/checks.c
    index 9838698..b8374c1 100644
    --- a/base/checks.c
    +++ b/base/checks.c
    @@ -1247,6 +1247,13 @@ int handle_async_service_check_result(service *temp_service, check_result *queue
    else
    run_async_host_check_3x(temp_host, CHECK_OPTION_NONE, 0.0, FALSE, FALSE, NULL, NULL);
    }
    +

    •           /* if a new service has been added, it needs to
      
    •            * be saved into statehistory. NOK states will
      
    •            * be added in other sections.
      
    •            */
      
    •           if (temp_service->has_been_checked == FALSE)
      
    •                   handle_service_event(temp_service);
        }
      

Changesets

2014-01-03 17:34:11 +00:00 by (unknown) b16ba51

core: Add statehistory entries for newly added services.

Refs #3854

2014-01-03 17:34:39 +00:00 by (unknown) a95977f

Merge branch 'feature/statehist-svc-new-ok-3854' into next

Fixes #3854
Member

icinga-migration commented Jan 3, 2014

Updated by mfriedrich on 2014-01-03 17:33:25 +00:00

  • Category set to Check Results
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 1.11
Member

icinga-migration commented Jan 3, 2014

Updated by Anonymous on 2014-01-03 20:03:49 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset a95977f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment