Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #4210] ido2db gradually consumes more and more CPU time with time #1285
This issue has been migrated from Redmine: https://dev.icinga.com/issues/4210
Created by crfriend on 2013-05-25 20:13:13 +00:00
These are early results, but I am seeing my ido2db process consuming more and more CPU time on a 440 MHz SPARC processor as the runtime increases. Along with this, I am seeing a lot of BEGIN/COMMIT cycles with no transaction data bracketed by same.
At this time I am leaning towards a failure to check for actual data at line 1538 in ido2db.c where ido2db_check_for_client_input does not indicate whether anything was available or not.
Film, as they say, at eleven and, likely a patch.
2013-06-22 15:53:13 +00:00 by (unknown) f841c16
Updated by crfriend on 2013-05-27 15:38:22 +00:00
The memory leak was solved by the attached patch. The repeated BEGIN/COMMIT issue is primarily the result of a NEBTYPE_TIMEDEVENT_SLEEP type in the datastream which the dbhandler code dismisses with an IDO_OK without a database access, and this is a separate issue altogether.
Should I split this issue into two pieces (one of which is fixed, and the other will likely have ramifications in core as it may affect some of the include files) or should I ignore the empty BEGIN/COMMIT cycles?
Updated by mfriedrich on 2013-05-27 15:42:20 +00:00
please create a branch on the fix/.* tree, according to the dev guidelines for git flow, just as "fix/topicname-issueid". and yes, split issues by their topic - some might get merged into releases, some are kept for dev in 'next' only.
Updated by crfriend on 2013-05-27 16:18:09 +00:00
OK, I will create a new one for the empty BEGIN/COMMIT transactions and retain #4210 as the memory leak.