Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #4211] bug with non-ASCII (> 127) illegal macro output characters on char-to-int cast #1286

Closed
icinga-migration opened this issue May 26, 2013 · 3 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented May 26, 2013

This issue has been migrated from Redmine: https://dev.icinga.com/issues/4211

Created by jyoung15 on 2013-05-26 04:48:45 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2013-06-03 19:07:19 +00:00)
Target Version: 1.9.2
Last Update: 2013-06-03 19:07:19 +00:00 (in Redmine)

Icinga Version: 1.9.1
OS Version: FreeBSD 9.1

If illegal_macro_output_chars contains non-ASCII characters, there is a problem with the cast from char to int in base/config.c line 1835. This causes characters larger than 127 to overwrite other regions of memory, which may cause icinga to crash. The cast should be to unsigned char instead of int. Patch supplied.

Attachments

Changesets

2013-06-03 19:02:02 +00:00 by (unknown) d88570e

core: fix bug with non-ASCII (> 127) illegal macro output characters on char-to-int cast

fixes #4211

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 29, 2013

Updated by mfriedrich on 2013-05-29 10:41:22 +00:00

  • Category set to Other
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 1.9.2
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 3, 2013

Updated by mfriedrich on 2013-06-03 19:00:34 +00:00

  • Subject changed from feature #3389 introduced bug with non-ASCII (> 127) illegal macro output characters to bug with non-ASCII (> 127) illegal macro output characters on char-to-int cast
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 3, 2013

Updated by Anonymous on 2013-06-03 19:07:19 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset d88570e.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.