Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #4390] show custom variables in extended info, allow to exclude name/value containing defined config options #1303

Closed
icinga-migration opened this issue Jul 6, 2013 · 5 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jul 6, 2013

This issue has been migrated from Redmine: https://dev.icinga.com/issues/4390

Created by mfriedrich on 2013-07-06 13:51:11 +00:00

Assignee: ricardo
Status: Resolved (closed on 2013-09-12 18:10:54 +00:00)
Target Version: 1.10
Last Update: 2014-12-08 09:15:29 +00:00 (in Redmine)


Having Icinga2 Compat on my plate, I wanted to test the "custom dictionary to customvar name/value" functionality with objects.cache until I realized that the Classic UI does not support custom variables at all.

It's not quite true, as the hosts and services have already read all custom variables into memory, so accessing them is quite easy. The actual hard part is - well known from Icinga Web - that you must exclude sensitive information like passwords, snmp communities etc.

For that reason, cgi.cfg should include 2 new options

  • exclude_customvar_name=
  • exclude_customvar_value=

basically the exclude works like the database 'LIKE pattern' in order to filter everything just by the pattern, and not the exact match. If you pass '*' all names/values will be filtered (makes sense in some installations).

the parser should be as modular as the parsing for authorization information already is (hooray for Ricardo's macro magic).

location on the screen - either somewhere on the state information, or a seperated table next to the enable/disable options. will only be shown if there are actually custom vars set for this host/service.

Attachments

Changesets

2013-07-06 14:02:04 +00:00 by (unknown) 02ac61c

classic ui: show custom variables in extended info, allow to exclude custom variable name/value based on pattern

everything set except the correct formatting (maybe make this hidden by
default and clickable with the plus icon).

refs #4390

2013-09-11 20:14:18 +00:00 by ricardo 6866528

classic-ui: moved table of custom variables to more visible spot #4390

now the formatting should be ok, hope you like it

refs: #4390

2013-09-21 16:07:36 +00:00 by ricardo a8c110b

classic-ui: added custom vars to extinfo JSON output #4390

Also changed "cgi_json_version" to 1.10.0

refs: #4390

2013-09-21 16:49:48 +00:00 by ricardo c0694a6

Merge branch 'feature/classic-cv-with-excludes-4390' into next

fixes: #4390

2013-09-21 18:34:14 +00:00 by ricardo 7a4ad61

classic-ui: added json_encode to custum var json output #4390

refs: #4390

2013-09-21 18:37:31 +00:00 by ricardo aa77900

Merge branch 'feature/classic-cv-with-excludes-4390' into next

fixes: #4390
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 6, 2013

Updated by mfriedrich on 2013-07-06 14:09:57 +00:00

  • Status changed from Assigned to 8
  • Assigned to changed from mfriedrich to ricardo
  • Done % changed from 0 to 90
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 11, 2013

Updated by ricardo on 2013-09-11 20:41:26 +00:00

  • File added extinfo_custom_vars.png
  • Status changed from 8 to Feedback

how about this?

in current next

extinfo_custom_vars.png

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 11, 2013

Updated by mfriedrich on 2013-09-11 22:42:59 +00:00

looks nice :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 12, 2013

Updated by ricardo on 2013-09-12 18:10:54 +00:00

  • Status changed from Feedback to Resolved
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:15:29 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 55 to Classic UI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.