[dev.icinga.com #311] add config option to disable logging into the daemon log file #135

Closed
icinga-migration opened this Issue Feb 27, 2010 · 16 comments

Comments

Projects
None yet
1 participant
Member

icinga-migration commented Feb 27, 2010

This issue has been migrated from Redmine: https://dev.icinga.com/issues/311

Created by mfriedrich on 2010-02-27 17:43:32 +00:00

Assignee: elagon
Status: Resolved (closed on 2010-08-30 08:57:39 +00:00)
Target Version: 1.2 (Stable)
Last Update: 2010-09-21 14:43:20 +00:00 (in Redmine)


changes behavior, needs to be discussed.

-------- Original Message --------
Subject:    [Nagios-devel] use_syslog patch
Date:   Fri, 5 Jun 2009 11:37:41 -0600
From:   Steven D. Morrey 
Reply-To:   Nagios Developers List 
To:     nagios-devel@lists.sourceforge.net 


Hi Everyone,

The patch attached adds another option to use_syslog.
This option is 2 and will cause it to log to syslog only, thus preventing nagios.log from being written.
Beware:  Setting this option will break ANYTHING that requires the log to function this includes history browsing,  so use it at your own risk.

I have created 2 versions, one for nagios-2.12 and one for nagios-3x (todays cvs)
Enjoy!

Sincerely,
Steve

Attachments

Changesets

2010-08-30 10:01:34 +00:00 by elagon d80c3ac

New config option to enable/disable logging in to the daemon log file

fixes #311

Relations:

Member

icinga-migration commented May 24, 2010

Updated by mfriedrich on 2010-05-24 20:47:18 +00:00

since we already have the syslog facility, we need to force attention in changing use_syslog sth other than 0 or 1 which could cause confusion.

it might be good to just add a new config option "no_daemon_log=1" if icinga.log shouldn't be written.

Member

icinga-migration commented Jul 3, 2010

Updated by Meier on 2010-07-03 06:25:25 +00:00

dnsmichi wrote:

since we already have the syslog facility, we need to force attention in changing use_syslog sth other than 0 or 1 which could cause confusion.

it might be good to just add a new config option "no_daemon_log=1" if icinga.log shouldn't be written.

i don't see why this should cause confusion, also it does not affect any previous configurations. before you implement more and more config options the config parser should be revamped.
i would apply this patch.

Member

icinga-migration commented Jul 9, 2010

Updated by mfriedrich on 2010-07-09 14:58:04 +00:00

  • Category changed from Other to Configuration
  • Status changed from Feedback to New
  • Priority changed from Low to Normal

you are right on that, it does not really matter in this regard.

but i would consider setting the default config option to 2 for future releases (which is incompatible to older versions).

Member

icinga-migration commented Jul 18, 2010

Updated by Meier on 2010-07-18 20:07:24 +00:00

  • Status changed from New to Assigned
  • Assigned to set to Meier
  • Target Version set to 1.0.3
  • Done % changed from 0 to 90

I adapted the patch and pushed it in: 5effc34

Please consider it for rel 1.0.3

Member

icinga-migration commented Jul 19, 2010

Updated by elagon on 2010-07-19 15:13:34 +00:00

I really prefer the idea of "no_daemon_log=1"
If I will modify your commit with this option instead will it be ok with you?
The think I don't like very much is using the boolean variable "use_syslog" for more than one it's yes|no value, I think users will be confused about this.

Member

icinga-migration commented Jul 19, 2010

Updated by Meier on 2010-07-19 19:15:18 +00:00

go ahead, i don't mind if you rewrite it

Member

icinga-migration commented Jul 30, 2010

Updated by Meier on 2010-07-30 20:58:04 +00:00

  • Assigned to deleted Meier
  • Done % changed from 90 to 0
Member

icinga-migration commented Jul 30, 2010

Updated by Meier on 2010-07-30 20:58:17 +00:00

  • Target Version deleted 1.0.3
Member

icinga-migration commented Aug 10, 2010

Updated by elagon on 2010-08-10 17:00:05 +00:00

  • Assigned to set to elagon
Member

icinga-migration commented Aug 13, 2010

Updated by elagon on 2010-08-13 07:31:51 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

fixed in commit 157743f679961a22ebe8036fec72a2e111a62efa
the option is 'use_daemon_log' and default is 1 (true)

Member

icinga-migration commented Aug 13, 2010

Updated by mfriedrich on 2010-08-13 09:33:52 +00:00

  • Status changed from Resolved to Assigned

tests and output? during testing period before a release this needs to be extensively clarified for the rest, in order to adapt test cases.

this is a feature, not a bugfix - can this run into 1.0.3?

in that case, features require a docs issue too.

Member

icinga-migration commented Aug 13, 2010

Updated by elagon on 2010-08-13 11:40:32 +00:00

Sorry, forgot about that.
I tested it on Ubuntu Server 8.04 32bit and Ubuntu Desktop 10.04 32bit.
I think we can postpone it, it's not a feature essential for 1.0.3
For the doc issue I always prefere to see the commit in master first because it can be refused and in that case the doc issue was done for nothing :)

Member

icinga-migration commented Aug 16, 2010

Updated by mfriedrich on 2010-08-16 12:56:28 +00:00

  • Target Version set to 1.2 (Stable)
Member

icinga-migration commented Aug 30, 2010

Updated by mfriedrich on 2010-08-30 08:57:39 +00:00

  • Status changed from Assigned to Resolved

tested, works as expected. changed some identing and updated changelog.

Member

icinga-migration commented Aug 30, 2010

Updated by elagon on 2010-08-30 09:09:13 +00:00

must open an issue for the docs

Member

icinga-migration commented Sep 21, 2010

Updated by mfriedrich on 2010-09-21 14:43:20 +00:00

  • Subject changed from use_syslog patch to add config option to disable logging into the daemon log file

icinga-migration added this to the 1.2 (Stable) milestone Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment