[dev.icinga.com #5689] add option to anonymize external command user in icinga log #1435

Closed
icinga-migration opened this Issue Feb 21, 2014 · 5 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Member

icinga-migration commented Feb 21, 2014

This issue has been migrated from Redmine: https://dev.icinga.com/issues/5689

Created by ricardo on 2014-02-21 13:42:41 +00:00

Assignee: ricardo
Status: Resolved (closed on 2014-03-03 20:27:34 +00:00)
Target Version: 1.11
Last Update: 2014-03-03 20:27:34 +00:00 (in Redmine)


To make Icinga compliant with data retention laws in some countries it would be nice NOT to have any user names in Icinga Log

# LOG ANONYMIZED EXTERNAL COMMAND AUTHOR !!EXPERIMENTAL!!
# This option substitutes the user name on external commands with
# the string "" if the command gets logged. It is
# anonymized in log files only. This option was added to make
# icinga compliant with data retention laws on various countries.

Changesets

2014-02-21 13:52:14 +00:00 by ricardo d528a62

core: add option to anonymize external command user in icinga log #5689

Adds a new icinga.cfg option "log_anonymized_external_command_author".
Config description:
  LOG ANONYMIZED EXTERNAL COMMAND AUTHOR !!EXPERIMENTAL!!
  This option substitutes the user name on external commands with
  the string "<anon>" if the command gets logged. It is
  anonymized in log files only. This option was added to make
  icinga compliant with data retention laws on various countries.
  This option is disabled by default.

Refs: #5689
whatthecommit: Either Hot Shit or Total Bollocks

2014-02-21 16:39:35 +00:00 by ricardo 7bd1591

core: anonymize external command - add tests and config change #5689

* Add file with config change description
* Satisfy tests

Refs: #5689
whatthecommit: avoid the cherries

2014-03-03 20:25:23 +00:00 by (unknown) a169158

Merge branch 'feature/anonymize-external-command-user-5689' into next

Fixes #5689
@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Feb 21, 2014

Member

Updated by ricardo on 2014-02-21 14:04:47 +00:00

  • Done % changed from 60 to 90

in current "feature/anonymize-external-command-user-5689" and ready for testing.

Member

icinga-migration commented Feb 21, 2014

Updated by ricardo on 2014-02-21 14:04:47 +00:00

  • Done % changed from 60 to 90

in current "feature/anonymize-external-command-user-5689" and ready for testing.

@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Feb 21, 2014

Member

Updated by mfriedrich on 2014-02-21 15:12:51 +00:00

tests are failing (jenkins)

make[2]: Leaving directory `/var/lib/jenkins/workspace/icinga-core/tools/libtap'
cd ./base && make
make[2]: Entering directory `/var/lib/jenkins/workspace/icinga-core/base'
make[2]: Für das Ziel »all« ist nichts zu tun.
make[2]: Leaving directory `/var/lib/jenkins/workspace/icinga-core/base'
cd ./cgi && make
make[2]: Entering directory `/var/lib/jenkins/workspace/icinga-core/cgi'
make[2]: Für das Ziel »all« ist nichts zu tun.
make[2]: Leaving directory `/var/lib/jenkins/workspace/icinga-core/cgi'
cd ./t-tap && make test;
make[2]: Entering directory `/var/lib/jenkins/workspace/icinga-core/t-tap'
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap   -c -o test_logging.o test_logging.c
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap -o test_logging test_logging.o ../base/logging.o ../tools/libtap/tap.o -L/usr/lib/x86_64-linux-gnu
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap   -c -o test_events.o test_events.c
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap -o test_events test_events.o ../base/events.o ../tools/libtap/tap.o -L/usr/lib/x86_64-linux-gnu -lm -lz -lssl -lcrypto
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap   -c -o test_timeperiods.o test_timeperiods.c
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap -o test_timeperiods test_timeperiods.o ../base/utils.o ../base/config.o ../base/macros-base.o ../base/objects-base.o ../base/xobjects-base.o ../base/skiplist.o ../common/shared.o ../tools/libtap/tap.o -Wl,-export-dynamic -L/usr/lib/x86_64-linux-gnu -lm  -lpthread -lltdl -lz -lssl -lcrypto
../base/config.o: In function `read_main_config_file':
/var/lib/jenkins/workspace/icinga-core/base/config.c:705: undefined reference to `log_anonymized_external_command_author'
collect2: error: ld returned 1 exit status
make[2]: *** [test_timeperiods] Fehler 1
make[2]: Leaving directory `/var/lib/jenkins/workspace/icinga-core/t-tap'
make[1]: *** [test-tap] Fehler 2
make[1]: Leaving directory `/var/lib/jenkins/workspace/icinga-core'
make: *** [test] Fehler 2
Build step 'Shell ausführen' marked build as failure
Finished: FAILURE
Member

icinga-migration commented Feb 21, 2014

Updated by mfriedrich on 2014-02-21 15:12:51 +00:00

tests are failing (jenkins)

make[2]: Leaving directory `/var/lib/jenkins/workspace/icinga-core/tools/libtap'
cd ./base && make
make[2]: Entering directory `/var/lib/jenkins/workspace/icinga-core/base'
make[2]: Für das Ziel »all« ist nichts zu tun.
make[2]: Leaving directory `/var/lib/jenkins/workspace/icinga-core/base'
cd ./cgi && make
make[2]: Entering directory `/var/lib/jenkins/workspace/icinga-core/cgi'
make[2]: Für das Ziel »all« ist nichts zu tun.
make[2]: Leaving directory `/var/lib/jenkins/workspace/icinga-core/cgi'
cd ./t-tap && make test;
make[2]: Entering directory `/var/lib/jenkins/workspace/icinga-core/t-tap'
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap   -c -o test_logging.o test_logging.c
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap -o test_logging test_logging.o ../base/logging.o ../tools/libtap/tap.o -L/usr/lib/x86_64-linux-gnu
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap   -c -o test_events.o test_events.c
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap -o test_events test_events.o ../base/events.o ../tools/libtap/tap.o -L/usr/lib/x86_64-linux-gnu -lm -lz -lssl -lcrypto
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap   -c -o test_timeperiods.o test_timeperiods.c
ccache gcc -g -O2  -I/usr/include/openssl -I/usr/include -DHAVE_CONFIG_H -DNSCORE -I../include -I../tools/libtap -o test_timeperiods test_timeperiods.o ../base/utils.o ../base/config.o ../base/macros-base.o ../base/objects-base.o ../base/xobjects-base.o ../base/skiplist.o ../common/shared.o ../tools/libtap/tap.o -Wl,-export-dynamic -L/usr/lib/x86_64-linux-gnu -lm  -lpthread -lltdl -lz -lssl -lcrypto
../base/config.o: In function `read_main_config_file':
/var/lib/jenkins/workspace/icinga-core/base/config.c:705: undefined reference to `log_anonymized_external_command_author'
collect2: error: ld returned 1 exit status
make[2]: *** [test_timeperiods] Fehler 1
make[2]: Leaving directory `/var/lib/jenkins/workspace/icinga-core/t-tap'
make[1]: *** [test-tap] Fehler 2
make[1]: Leaving directory `/var/lib/jenkins/workspace/icinga-core'
make: *** [test] Fehler 2
Build step 'Shell ausführen' marked build as failure
Finished: FAILURE
@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Feb 21, 2014

Member

Updated by ricardo on 2014-02-21 16:49:59 +00:00

  • Status changed from New to Feedback

thank you. I should be better at this.

fixed the tests and all looks good now according to jenkins.

Also added the config change file which I forgot to add in the last commit.

Member

icinga-migration commented Feb 21, 2014

Updated by ricardo on 2014-02-21 16:49:59 +00:00

  • Status changed from New to Feedback

thank you. I should be better at this.

fixed the tests and all looks good now according to jenkins.

Also added the config change file which I forgot to add in the last commit.

@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Mar 3, 2014

Member

Updated by mfriedrich on 2014-03-03 18:55:29 +00:00

  • Status changed from Feedback to Assigned

please merge to next.

Member

icinga-migration commented Mar 3, 2014

Updated by mfriedrich on 2014-03-03 18:55:29 +00:00

  • Status changed from Feedback to Assigned

please merge to next.

@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Mar 3, 2014

Member

Updated by Anonymous on 2014-03-03 20:27:34 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 90 to 100

Applied in changeset a169158.

Member

icinga-migration commented Mar 3, 2014

Updated by Anonymous on 2014-03-03 20:27:34 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 90 to 100

Applied in changeset a169158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment