[dev.icinga.com #609] Having check box in the web interface for selecting multiple host and services #304

Closed
icinga-migration opened this Issue Jul 8, 2010 · 16 comments

Comments

Projects
None yet
1 participant
Member

icinga-migration commented Jul 8, 2010

This issue has been migrated from Redmine: https://dev.icinga.com/issues/609

Created by mfriedrich on 2010-07-08 17:09:18 +00:00

Assignee: (none)
Status: Resolved (closed on 2010-08-13 11:24:36 +00:00)
Target Version: 1.0.3
Last Update: 2014-12-08 09:34:11 +00:00 (in Redmine)


basically sth like icinga web provides, but the classic way. would be hard to read the POST with different selected array ids though, but why not. It's not that different in c/cgi than in php.

Summary      0000053: Having check box in the web interface for selecting multiple host and services
Description     When looking at host problem or service problem page, having check box next to host and service name will be a great addition. This will give user the opportunity to acknowledge multiple problem at the same time. Specially useful during major outages.

Changesets

2010-08-08 01:47:15 +00:00 by (unknown) d4789ab

Added batch selecting hosts and services.
Large changes in cmd.c and status.c
Cleaned up some whitespaces in the other CGI's.

JavaScript dropdown menu
JavaScript enabled checkbox to select everything in the view.
Current limit of around 125 simultaneous commands.

IssueID #609

2010-08-09 08:00:03 +00:00 by mfriedrich 3cea114

classic ui: move inline file names/dirs for multiple commands into cgiutils.c/.h

add url_js_path and several #defines in order to maintain it a bit easier,
and also modular when updating versions of jquery etc.

the html path is also not hardcoded anymore, allowing configure params
changing the html base dir.

refs #609

2010-08-09 13:25:23 +00:00 by mfriedrich f4b63e9

classic ui: change location of multiple commands dropdown

seperating the urls box, and commands dropdown into its
own table makes more sense, not loosing too many space on
small displays.

also added a submit button with js onclick event instead
of a normal selective text url.

refs #609

2010-08-09 18:20:53 +00:00 by (unknown) f2b1c52

Rewrote the read-checkboxes javascript to be more robust.
Moved several javascripts out of status.c into their own files.
Added in a debug for the URL that can be manually enabled by removing the comment in checkboxesNbutton.js
Fixes 609

Updated scriptalicious to 1.8.3, up from 1.8.2
Fixes #698

2010-08-09 18:28:48 +00:00 by (unknown) 2ad210d

Rewrote the read-checkboxes javascript to be more robust.
Moved several javascripts out of status.c into their own files.
Added in a debug for the URL that can be manually enabled by removing the comment in checkboxesNbutton.js
Fixes #609

Updated scriptalicious to 1.8.3, up from 1.8.2
Fixes #698
Member

icinga-migration commented Jul 8, 2010

Updated by mfriedrich on 2010-07-08 17:09:29 +00:00

  • Tracker changed from Bug to Feature
Member

icinga-migration commented Jul 30, 2010

Updated by mfriedrich on 2010-07-30 12:19:38 +00:00

  • Project changed from Core, Classic UI, IDOUtils to 19
  • Category deleted Classic UI
Member

icinga-migration commented Aug 6, 2010

Updated by Anonymous on 2010-08-06 20:57:54 +00:00

  • Category set to 44
  • Assigned to set to __
  • Done % changed from 0 to 30
  • Estimated Hours set to 12

I am working on this.
I've got a basic version of it to work, just need to brush up the HTML and a good way to present all the checks available.

Member

icinga-migration commented Aug 7, 2010

Updated by Anonymous on 2010-08-07 14:24:33 +00:00

  • Subject changed from aving check box in the web interface for selecting multiple host and services to Having check box in the web interface for selecting multiple host and services
  • Target Version set to 1.2 (Stable)
  • Done % changed from 30 to 50
  • Estimated Hours changed from 12 to 20

Done:
Add in checks in status.c
Selection is done via a dropdown menu and a "submit" link.
To select targets, just click in the checkboxes on the page.

ToDo:
Fix HTML so it can be more easy to read these "batch" checks.

Member

icinga-migration commented Aug 8, 2010

Updated by Anonymous on 2010-08-08 01:29:44 +00:00

  • Done % changed from 50 to 90

Last thing ToDo:
Extensive testing

Wishlist:
Make a nicer HTML output in cmd.c

Member

icinga-migration commented Aug 8, 2010

Updated by Anonymous on 2010-08-08 11:07:29 +00:00

  • Status changed from New to Resolved
  • Done % changed from 90 to 100

Extensive testing done, added 2 missing checks to the command table.

I consider this resolved, fixing up the HTML can be done if the feedback from the current is negative.

Member

icinga-migration commented Aug 9, 2010

Updated by mfriedrich on 2010-08-09 08:03:47 +00:00

  • Status changed from Resolved to Assigned
  • Target Version changed from 1.2 (Stable) to 1.0.3
  • Done % changed from 100 to 90

maybe possible to bring this into 1.0.3 ?

see my commit about the path changes.

Member

icinga-migration commented Aug 9, 2010

Updated by Anonymous on 2010-08-09 08:37:50 +00:00

I will update the code later today, great to see you added paths(will save hassle later!)

Member

icinga-migration commented Aug 9, 2010

Updated by mfriedrich on 2010-08-09 08:45:44 +00:00

simply do a

$ git checkout master
$ git pull
$ git checkout mfriedrich/core
$ git pull origin mfriedrich/core
$ git checkout rdarrud/cgis
$ git merge mfriedrich/core

then you'll have the latest and greatest.

regarding the location of the command dropdown - i woud prefer having it next to "view service status detail" etc links, and not in the table at the top.

since this is a rather complicated table layout, maybe it's even better to put that right below everything meaning over here:

                /* end of top table */
                printf("\n"); // <===========
                printf("\n");
Member

icinga-migration commented Aug 9, 2010

Updated by mfriedrich on 2010-08-09 13:31:16 +00:00

i've revamped it a bit, split the top table into 2 tables (id display_header is set), and moved the commands dropdown into the 2nd table on the most right.

the submit text url with a onclick event is now a submit button with onclick event, which fits better into the current layout imho.

some todos:

  • create option to enable/disable reload function
  • add style for all buttons throughout the classic ui, in order to make those things a bit more 'smooth' ;-)
Member

icinga-migration commented Aug 9, 2010

Updated by Anonymous on 2010-08-09 18:27:20 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 90 to 100

Applied in changeset commit:"f2b1c52d9b956dec600012d7ba5f73b8594687d2".

Member

icinga-migration commented Aug 13, 2010

Updated by ricardo on 2010-08-13 09:33:38 +00:00

  • Status changed from Resolved to Feedback
  • Done % changed from 100 to 90

on Windows with Firefox 4 beta3 the DropDown Menu disappears! Con someone confirm this behavior?

Member

icinga-migration commented Aug 13, 2010

Updated by Anonymous on 2010-08-13 10:27:16 +00:00

Is firebug available for FireFox 4 beta's? If so, please install it and activate it when you go to the site. Post back any error messages.

Member

icinga-migration commented Aug 13, 2010

Updated by ricardo on 2010-08-13 11:24:13 +00:00

  • Done % changed from 90 to 100

i tested it with Safari for Mac and Windows. Works fine there as well.

Probably better not to test it with a Firefox beta.

And Firebug isn't available for firefox 4b3

Member

icinga-migration commented Aug 13, 2010

Updated by ricardo on 2010-08-13 11:24:36 +00:00

  • Status changed from Feedback to Resolved
Member

icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:34:11 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 44 to Classic UI

icinga-migration added this to the 1.0.3 milestone Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment