Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #610] enforce a need for comment for action taken in cmd.cgi #305
This issue has been migrated from Redmine: https://dev.icinga.com/issues/610
Created by mfriedrich on 2010-07-08 17:16:43 +00:00
I would make that a config option, e.g. enforce_comments_on_actions=0|1
2011-03-15 13:23:59 +00:00 by ricardo 352574f
Updated by ricardo on 2010-11-11 21:52:00 +00:00
I pretty much finished it but now I realized it's quit difficult to implement it properly.
Because every action has to be commented. So even if you delete comments witch where crested through an action, it creates another comment. It's like getting into "comment hell". Then you will have thousands of comments and don't actually need them.
The second problem is: Where to add comments witch are created by actions witch are not directly affecting a host or service. For example stopping the "global" flap detection. We could add it to the Server with runs Icinga, but witch host is it. Or do we create a new host?
And It isn't necessary to have them in the comments list. Just in the log would be fine.
Then we should create a new command "CMD_LOG_ACTION" or something similar.
What are your thoughts about this feature?
Updated by mfriedrich on 2011-01-10 17:18:37 +00:00
currently, it will become a comment hell - in the way comments are handled and assigned. if we do find a proper backend handling that correctly, i might say to enforce such a need. but for now i don't think it's worth on running into more bugs than wanted ;-)
if you don't mind i'll close for now and you'll focus on more important issues.
Updated by ricardo on 2011-03-15 13:33:51 +00:00
risen from the dead ;-)
see commit: 352574f
as usual: please test, test, test