Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #610] enforce a need for comment for action taken in cmd.cgi #305

Closed
icinga-migration opened this issue Jul 8, 2010 · 16 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jul 8, 2010

This issue has been migrated from Redmine: https://dev.icinga.com/issues/610

Created by mfriedrich on 2010-07-08 17:16:43 +00:00

Assignee: ricardo
Status: Resolved (closed on 2011-05-02 15:59:22 +00:00)
Target Version: 1.4
Last Update: 2014-12-08 09:34:12 +00:00 (in Redmine)


I would make that a config option, e.g. enforce_comments_on_actions=0|1

http://tracker.nagios.org/view.php?id=52

Summary      0000052: enforce a need for comment for action taken on host and services
Description     Currently only acknowledging problem requires to input a comment. It would be great for tracking if we can enforce all action requiring a comment. Specially for disabling checks and disabling notification.

Changesets

2011-03-15 13:23:59 +00:00 by ricardo 352574f

enforce a need for comment for action taken in cmd.cgi #610

refs: #610

* added new config option: enforce_comments_on_actions
* writes enforced comments to cgi log

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 30, 2010

Updated by mfriedrich on 2010-07-30 12:19:48 +00:00

  • Project changed from Core, Classic UI, IDOUtils to 19
  • Category deleted Classic UI
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Aug 30, 2010

Updated by mfriedrich on 2010-08-30 08:49:32 +00:00

  • Status changed from New to Assigned
  • Assigned to set to __

@rune

can you please check on that - I think it should be easy to add a config option, and then insisting on comments on all actions.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Aug 30, 2010

Updated by Anonymous on 2010-08-30 10:27:27 +00:00

As in a cgi.cfg option? If so, it shouldnt be too hard, just a lot of lines to update with more code ;-P

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Aug 30, 2010

Updated by mfriedrich on 2010-08-30 10:34:15 +00:00

yep, cgi.cfg would be the easiest way to handle that (admin can set it, user has to work with).

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 23, 2010

Updated by ricardo on 2010-09-23 20:19:30 +00:00

when I'm doing #804 I try to resolve this as well

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 5, 2010

Updated by ricardo on 2010-11-05 10:45:32 +00:00

I'll try to implement this next week.

should'nt be to dificult.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 11, 2010

Updated by ricardo on 2010-11-11 21:52:00 +00:00

  • Assigned to changed from __ to ricardo

I pretty much finished it but now I realized it's quit difficult to implement it properly.

Because every action has to be commented. So even if you delete comments witch where crested through an action, it creates another comment. It's like getting into "comment hell". Then you will have thousands of comments and don't actually need them.

The second problem is: Where to add comments witch are created by actions witch are not directly affecting a host or service. For example stopping the "global" flap detection. We could add it to the Server with runs Icinga, but witch host is it. Or do we create a new host?

And It isn't necessary to have them in the comments list. Just in the log would be fine.

Then we should create a new command "CMD_LOG_ACTION" or something similar.

What are your thoughts about this feature?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 10, 2011

Updated by mfriedrich on 2011-01-10 17:18:37 +00:00

  • Status changed from Assigned to Closed

currently, it will become a comment hell - in the way comments are handled and assigned. if we do find a proper backend handling that correctly, i might say to enforce such a need. but for now i don't think it's worth on running into more bugs than wanted ;-)

if you don't mind i'll close for now and you'll focus on more important issues.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 10, 2011

Updated by ricardo on 2011-03-10 21:54:58 +00:00

can you please reaopen this one, I want to link it to: https://dev.icinga.org/issues/1161

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 10, 2011

Updated by mfriedrich on 2011-03-10 22:16:42 +00:00

  • Status changed from Closed to Assigned
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 15, 2011

Updated by ricardo on 2011-03-15 13:33:51 +00:00

  • Subject changed from enforce a need for comment for action taken on host and services to enforce a need for comment for action taken in cmd.cgi
  • Status changed from Assigned to Resolved
  • Target Version set to 1.4
  • Done % changed from 0 to 90

risen from the dead ;-)

see commit: 352574f

as usual: please test, test, test

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 15, 2011

Updated by ricardo on 2011-03-15 13:38:06 +00:00

  • Status changed from Resolved to Feedback
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 27, 2011

Updated by mfriedrich on 2011-04-27 18:17:37 +00:00

very nice, working properly - and given the fact that the extended cgi log must be turned on, maybe you'll create some text for the docs section then?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 28, 2011

Updated by mfriedrich on 2011-04-28 20:33:18 +00:00

  • Done % changed from 90 to 100
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 2, 2011

Updated by mfriedrich on 2011-05-02 15:59:22 +00:00

  • Status changed from Feedback to Resolved

works, proven stable.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:34:12 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category set to Classic UI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.