Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #852] Modify Display Filter for the status.cgi #397

Closed
icinga-migration opened this issue Oct 4, 2010 · 27 comments

Comments

@icinga-migration
Copy link
Member

commented Oct 4, 2010

This issue has been migrated from Redmine: https://dev.icinga.com/issues/852

Created by stku on 2010-10-04 17:56:20 +00:00

Assignee: ricardo
Status: Resolved (closed on 2013-06-14 16:45:28 +00:00)
Target Version: 1.10
Last Update: 2014-12-08 09:34:21 +00:00 (in Redmine)


I think it will be great to have to possibility to modify the Display Filter direct in the status.cgi and not only over the url. I hope it is allowed to post a link here. The Gui Thruk have something like this.
Here you can see it:
http://www.thruk.org/images/screenshots/medium/13\_change\_filter.png

Attachments

Changesets

2011-04-05 10:41:36 +00:00 by ricardo d787f07

first part of status.cgi rewrite

* added a new struct witch holds status data for hosts AND services
* just one sort function left
* data for host and service list get filtered first and if necesarry filtered then
* corrected indentation

refs: #844
refs: #852

2013-06-14 00:44:40 +00:00 by ricardo 8acad63

classic-ui: add display filter modification for status.cgi #852

now you can modify the display filters directly in status.cgi
and the most annoying bug EVER was found
more information in next commit

* jQuery UI version updated to 1.10.3

refs: #852

2013-06-14 15:44:28 +00:00 by ricardo 2324e84

classic-ui: fixes and modification for last commit #852

now with more fixes, more rants and more beauty

* fixes bug from last commit where "Submit" brought you to cmd.cgi
* adds round corners colored background in filters
* adds comments on "status_filter_functions.js"
* removes "HOST_PASSIVE_CHECK", "HOST_ACTIVE_CHECK",
  "SERVICE_PASSIVE_CHECK", "SERVICE_ACTIVE_CHECK" as they
  where never used anywhere
* adds MORE RANT

fixes: #852

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2010

Updated by mfriedrich on 2010-10-10 11:53:00 +00:00

  • Priority changed from Low to Normal
  • Target Version set to 1.3

sure thing. needs to be evaluated though. and not touching status.c but instead using cgiutils in order to create that box.

thanks for the idea!

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2011

Updated by mfriedrich on 2011-01-04 17:07:26 +00:00

  • Status changed from New to Assigned
  • Assigned to set to __
  • Target Version changed from 1.3 to 1.4

can be worthwhile a feature 1.4 then.

rune, do you have time for that?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2011

Updated by Anonymous on 2011-01-04 22:39:56 +00:00

I'll have a look when the time comes, "shouldnt" be too hard.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jan 5, 2011

Updated by mfriedrich on 2011-01-05 07:24:22 +00:00

you can have a look into it right now if you like to ;-)

i'd only put 1.4 for it because of an explicite possible feature for a stable release. but if you'll add it to 1.3.1 (after official 1.3.0 release) for testing, no problem either :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2011

Updated by mfriedrich on 2011-03-14 21:15:37 +00:00

any updates?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2011

Updated by ricardo on 2011-03-14 21:52:09 +00:00

still busy implementing stuff at other spots. But I started with this before I left to canada and have already some code for it.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2011

Updated by mfriedrich on 2011-03-14 22:32:21 +00:00

  • Assigned to changed from __ to ricardo

ok, take your time and if not possible, re-assign to next version.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2011

Updated by mfriedrich on 2011-04-27 18:13:36 +00:00

status on that? more time needed or ready for 1.4?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2011

Updated by ricardo on 2011-04-27 23:12:36 +00:00

not ready yet, needs more stuff to be written.

Actually until now I have no clue how to implement the filter anyway.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2011

Updated by mfriedrich on 2011-04-28 11:39:42 +00:00

  • Target Version changed from 1.4 to 1.5
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2011

Updated by mfriedrich on 2011-07-16 16:03:25 +00:00

  • Target Version changed from 1.5 to 1.6

consider it for a full rewrite later on.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Oct 18, 2011

Updated by kiranos on 2011-10-18 17:14:18 +00:00

Hi how is this feature going? I see great use for it. Would love to see it happen for 1.6

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 4, 2011

Updated by mfriedrich on 2011-11-04 08:12:45 +00:00

  • Target Version changed from 1.6 to 1.7

let's discuss that on osmc and try to hack together.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2012

Updated by ricardo on 2012-03-08 20:22:48 +00:00

thinking about, and should be possible now.

try to get some ideas in the next days

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2012

Updated by ricardo on 2012-04-13 14:14:15 +00:00

  • Target Version changed from 1.7 to 1.8
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2012

Updated by mfriedrich on 2012-08-31 11:14:55 +00:00

  • Target Version deleted 1.8
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2012

Updated by mfriedrich on 2012-10-24 17:57:31 +00:00

  • Target Version set to 1.10

using a different backend, this should be doable. though, measure the effort to do so in the first place before trying to hack around without proper results.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2013

Updated by ricardo on 2013-06-01 18:04:18 +00:00

  • File added filter_alpha_preview.png

Brace yourself, Filters are comming

filter_alpha_preview.png

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2013

Updated by mfriedrich on 2013-06-01 18:22:39 +00:00

geil :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2013

Updated by ricardo on 2013-06-12 21:06:50 +00:00

It's alive... It's alive, IT'S ALIVE!

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2013

Updated by mfriedrich on 2013-06-12 21:15:38 +00:00

where? gimme :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2013

Updated by ricardo on 2013-06-14 00:55:59 +00:00

check git and tell me what you think

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2013

Updated by mfriedrich on 2013-06-14 07:11:12 +00:00

  • File added icinga_1.10_classic_ui_filters_error_cmd.cgi.png

hm, there's an error when modifying the host filter, and then hitting "submit". it forwards to cmd.cgi which throws an error with "Error: No command was specified!"

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2013

Updated by ricardo on 2013-06-14 15:58:49 +00:00

  • File added filter_final.png
  • Status changed from Assigned to Feedback
  • Done % changed from 0 to 90

I'm sorry that it didn't worked. But I fixed it now.

Having a look at the changes in "status_filter_functions.js" is might worth it.

Please test and tell me if you like it or not.

This is what it looks like now: filter_final.png

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2013

Updated by mfriedrich on 2013-06-14 16:10:32 +00:00

  • File added icinga_1.10_classic_ui_filters_02.png

looks like i owe you much beer :)

fetched your branch, all working fine now!

icinga_1.10_classic_ui_filters_02.png

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2013

Updated by ricardo on 2013-06-14 16:45:28 +00:00

  • Status changed from Feedback to Resolved
  • Done % changed from 90 to 100

Applied in changeset icinga-core:2324e8405a707246edeff7f7762c24c7096c4c40.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:34:21 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 44 to Classic UI

@icinga-migration icinga-migration added this to the 1.10 milestone Jan 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.