[dev.icinga.com #1192] replace libtap with an actively developed version #545

Closed
icinga-migration opened this Issue Feb 8, 2011 · 5 comments

Projects

None yet

1 participant

@icinga-migration
Member

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1192

Created by mfriedrich on 2011-02-08 07:57:30 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2012-03-04 12:33:19 +00:00)
Target Version: 1.7
Last Update: 2012-03-04 12:33:19 +00:00 (in Redmine)


https://github.com/zorgnax/libtap?

as pointed out by sven, seems to be more active development on that.

Changesets

2012-02-27 12:27:11 +00:00 by mfriedrich 6b02a90

tests: replace libtap with an actively developed version #1192

refs #1192

2012-02-27 12:31:35 +00:00 by mfriedrich abc2e7f

tests: you can now test with pleasure: $ make distclean ; ./configure ; make test #2369 #1192

no, i don't want to run 'make all' before running make test-perl
and no, i don't want debug funny perl error msg.

just fix it and allow test focus on the more important things.

refs #1192
refs #2369

2012-02-27 13:15:15 +00:00 by mfriedrich e16b53c

tests: readd ignored libtap Makefile

refs #1192

2012-02-27 17:01:16 +00:00 by mfriedrich 7e57f30

fix test_checks in t-tap, strange sigsegv all the way ...

passing a checkresult from services straight to a host
without checking that the svcdesc is null'ed leads to
rather strange behaviour. furthermore, using calloc
instead of malloc does not prevent us from initializing
all the important members which reach the inner core
functionality already set - we shouldn't fail on the
tests just because we don't know how to set variables.

refs #1192
@icinga-migration
Member

Updated by mfriedrich on 2011-09-30 21:46:56 +00:00

  • Status changed from New to Closed
@icinga-migration
Member

Updated by mfriedrich on 2012-02-27 11:45:51 +00:00

  • Category set to Testing
  • Status changed from Closed to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 1.7

as a matter of fact, the currently used libtap in tap/ is outdated and it seems, not developed anymore.

the one on github is actively developed, and requires some small adaptions.

plan_tests => plan
todo_start => todo
todo_end => cendtodo

meanwhile, it does not require a configure call anymore, so we can silently drop --enable-libtap in configure as well.
furthermore, the current location in tap/ is rather suspicious, as we should ship bundled libraries elsewhere. the new location will be tools/libtap with a special README.icinga file. as well as a distclean patch to the Makefile.

@icinga-migration
Member

Updated by mfriedrich on 2012-02-27 11:48:44 +00:00

tools/libtap/README.icinga


libtap in Icinga
----------------

The original libtap implementation from http://jc.ngo.org.uk/trac-bin/trac.cgi/wiki/LibTap
seems to have stopped development (last release 2005, autoconf 2.59. no --datarootdir).

Icinga now steps onto https://github.com/zorgnax/libtap which provides active development
as well as more flexibility on build systems (no configure, but plain make).

This will also be place in tools/libtap as bundled library, not to confuse with the main
package.

For further questions on testing, please refer to the official Icinga support channels at
https://www.icinga.org/support/

More information on testing strategies can be found in the Icinga wiki
https://wiki.icinga.org
@icinga-migration
Member

Updated by mfriedrich on 2012-02-27 12:02:22 +00:00

  • Tracker changed from Support to Feature
  • Subject changed from replace libtap to replace libtap with an actively developed version
  • Priority changed from Low to Normal
@icinga-migration
Member

Updated by mfriedrich on 2012-03-04 12:33:19 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100
@icinga-migration icinga-migration added this to the 1.7 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment