Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #1406] Replace top.html with alternative CGI driven view #612

Closed
icinga-migration opened this issue Apr 14, 2011 · 17 comments
Closed
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Apr 14, 2011

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1406

Created by mjbrooks on 2011-04-14 06:00:52 +00:00

Assignee: mjbrooks
Status: Resolved (closed on 2011-05-04 13:34:01 +00:00)
Target Version: 1.4
Last Update: 2014-12-08 09:32:25 +00:00 (in Redmine)


While attractive in its minimalism, the top frame could use some attention.

One of the more popular aspects of the icinga-web interface is the inclusion of tactical and monitoring system information that stays at the top of icinga-web at all times. However, with teh classic cgi, people tend to find themselves either parked on the tac overview or constantly switching to it to stay on top of necessary, but still fairly basic information.

The goal is to have the display given by the Classic UI CGIs to have a similar feel to that of icinga-web.

The new view will be disabled by default via a cgi.cfg option. If left disabled, the output of the CGI will be nearly equivalent to the current output from top.html.

I have it mostly done, just a few more adjustments and perhaps some added functionality if a really good idea that can't wait hits me before I finish dotting the i's.

Attachments

Changesets

2011-04-21 17:49:10 +00:00 by (unknown) efa9dc3

Add an optional alternative CGI driven view for the top frame #1406

This enables the ability to display CGI content in the 'top' frame of
the Classic UI that has a similar feel to the top header in icinga-web
including tactical and monitor performance information.

index.html now calls tac.cgi?tac_header instead of top.html for the
content of the top frame. By default the output essentially looks
the same as what was in top.html.

The new CGI top view can be enabled with the cgi.cfg option:

show_tac_header=1

refs #1406

2011-04-21 22:59:47 +00:00 by ricardo bcbe474

changed some colors for tac_header #1406

cleaned the code a bit
also deleted unused javascript libs

refs #1406

2011-04-27 22:09:32 +00:00 by (unknown) b22fdf5

Prevent wraps in the tac_header monitor service table

When the lines wrap in the monitor service table, the magic of
using a backround image for the cell gets revealed.

This change includes the following:
 - sets nowrap on some of the table dividers
 - changes "sec" to "s" to reduce the cell line width

refs #1406

2011-05-06 09:22:26 +00:00 by mfriedrich 236c6f7

classicui: add title tooltip to enhanced tac header counts #1406

re-orded the code a bit to allow easy identifying
of the sections.

refs #1406
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 15, 2011

Updated by mjbrooks on 2011-04-15 16:20:15 +00:00

Ricardo was kind enough to point out that I had hard coded some things, so I'm cleaning it up.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 17, 2011

Updated by mjbrooks on 2011-04-17 09:08:43 +00:00

  • Status changed from New to Assigned
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 17, 2011

Updated by mjbrooks on 2011-04-17 22:00:53 +00:00

  • Status changed from Assigned to Feedback
  • Done % changed from 80 to 100
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 19, 2011

Updated by mjbrooks on 2011-04-19 02:15:51 +00:00

  • File added tac_header.png

Here's what it looks like when enabled.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 21, 2011

Updated by ricardo on 2011-04-21 23:48:58 +00:00

merged it into my branch

changed some stuff:

  • it only shows unhandled problems and links also lead to status.cgi with the corresponding filters
    • think in most cases you just want to see what has a real problem at the moment
  • changed the color to match the cgi color scheme
  • removed the prototype.js and scriptaculous.js, seems like they aren't needed anymore

have a look at it and test it!!!

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 21, 2011

Updated by ricardo on 2011-04-21 23:56:00 +00:00

  • Target Version set to 1.4
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 22, 2011

Updated by mjbrooks on 2011-04-22 00:20:21 +00:00

Thanks, I will take a peek once I'm back in my comfy chair. (in the field ATM)

Was the color still off? I actually had noticed it myself and specifically changed the colors to match... perhaps I left the commit for that elsewhere.

Yeah, the two js entries looked useless, that's why I had commented them out.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 27, 2011

Updated by mfriedrich on 2011-04-27 16:41:46 +00:00

  • File added icinga_tac_header_malformed_width_res_1600x900.png

i've tested that (i think enabling by default might be possible). but it is somehow broken on a 1600x900 resolution. see the picture alone, it will be cut within the frameset.

icinga_tac_header_malformed_width_res_1600x900.png

browser is ff 3.6.16 kubuntu 10.10

can you please verify the error on the html an fix that accordingly?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 27, 2011

Updated by mjbrooks on 2011-04-27 23:49:15 +00:00

Welcome back!

Enabled by default?! That's a lot more than I was expecting, but I'm glad that the idea is liked that much.

I'm running Kubuntu 10.10 at 1600x1200 and I don't have the issue, but I think I can see what the issue is and just pushed up b22fdf5 to mbrooks/cgifix that prevents the cell wrap. Please give that change a try and tell me if that corrects it on your end. If not I'll give it more attention tonight.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 28, 2011

Updated by mfriedrich on 2011-04-28 09:55:59 +00:00

  • File added icinga_tac_header_malformed_1600x900_nowrap.png

i'm not back officially, just had a creative moment while chilling on the couch ;-)

1 thing further - i had no core running when calling the interface. using the tac header now remains with a big fat "Whooops!" instead of the icinga logo.
maybe you can have a look into that, fixing the error message to something convenient - e.g. showing the icinga logo and telling what the basic error msg tells in a shorter form (daemon not running, no status data available)?

regarding the wrapped stuff - yes that works, but the height is not calculated properly. this seems to be a fixed format which doesn't fit my resolution. so the tac_header isn't aware of the frame height given to it?

icinga_tac_header_malformed_1600x900_nowrap.png

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 28, 2011

Updated by mjbrooks on 2011-04-28 11:09:30 +00:00

  • File added tac_header_spacing.png

Thanks for the feedback.

The "Whoops!" is the default error that is driven from tac.cgi not being able to load. I'll see what I can come up with to improve on that.

The tac_header is flexible adjusting along the horizontal, but the frame height is fixed in html/index.html.in. Ricardo reduced my original by 2px, but that doesn't account for the amount of the discrepancy you're seeing.

What I do think I see, though perhaps it's just my eyes since I'm already a few hours beyond proper sleep time, is that you have a few px more padding in the cells and the fonts appear like they are also bigger than they should be. I'm attaching what I have at 1600x for a comparison. Perhaps this is an issue with tacheader.css not loading for you? Out of curiosity, are you seeing the same thing if you load it in the KDE browser Konqueror?

I'll look into it more tomorrow... I'm off to sleep for now.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 2, 2011

Updated by mfriedrich on 2011-05-02 16:12:03 +00:00

mjbrooks wrote:

The "Whoops!" is the default error that is driven from tac.cgi not being able to load. I'll see what I can come up with to improve on that.

well there are 4 different error locations, which would need to be adapted on the print_error() function. so for the first attempt i would leave that as it is.

The tac_header is flexible adjusting along the horizontal, but the frame height is fixed in html/index.html.in. Ricardo reduced my original by 2px, but that doesn't account for the amount of the discrepancy you're seeing.

as spoken on irc, probably the default browser font size has been changed by a zoom-in. let#s see how users react on that.

i do consider that a new default header, and if there aren't any other thoughts against, i'd like to set this issue to resolved?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 2, 2011

Updated by mjbrooks on 2011-05-02 16:40:17 +00:00

Sounds good to me.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 2, 2011

Updated by mfriedrich on 2011-05-02 16:43:30 +00:00

ok. then the final question - interested in joining team icinga, especially on classicui/cgi driven development and supporting ricardo ? :-)

if yes, drop me a short application letter via mail, i'll forward.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 4, 2011

Updated by mfriedrich on 2011-05-04 13:34:01 +00:00

  • Status changed from Feedback to Resolved

initial import in icinga 1.4

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 6, 2011

Updated by mfriedrich on 2011-05-06 08:24:47 +00:00

  • File added icinga_classicui_statusheader_unack_active_unack_passive_acked_counts.png

adding the active unack, passive unack and acked counts.

icinga_classicui_statusheader_unack_active_unack_passive_acked_counts.png

and adding a title / tooltip to reflect an info.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:32:25 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 52 to Classic UI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.