Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #1406] Replace top.html with alternative CGI driven view #612
This issue has been migrated from Redmine: https://dev.icinga.com/issues/1406
Created by mjbrooks on 2011-04-14 06:00:52 +00:00
While attractive in its minimalism, the top frame could use some attention.
One of the more popular aspects of the icinga-web interface is the inclusion of tactical and monitoring system information that stays at the top of icinga-web at all times. However, with teh classic cgi, people tend to find themselves either parked on the tac overview or constantly switching to it to stay on top of necessary, but still fairly basic information.
The goal is to have the display given by the Classic UI CGIs to have a similar feel to that of icinga-web.
The new view will be disabled by default via a cgi.cfg option. If left disabled, the output of the CGI will be nearly equivalent to the current output from top.html.
I have it mostly done, just a few more adjustments and perhaps some added functionality if a really good idea that can't wait hits me before I finish dotting the i's.
2011-04-21 17:49:10 +00:00 by (unknown) efa9dc3
2011-04-21 22:59:47 +00:00 by ricardo bcbe474
2011-04-27 22:09:32 +00:00 by (unknown) b22fdf5
2011-05-06 09:22:26 +00:00 by mfriedrich 236c6f7
Updated by ricardo on 2011-04-21 23:48:58 +00:00
merged it into my branch
changed some stuff:
have a look at it and test it!!!
Updated by mjbrooks on 2011-04-22 00:20:21 +00:00
Thanks, I will take a peek once I'm back in my comfy chair. (in the field ATM)
Was the color still off? I actually had noticed it myself and specifically changed the colors to match... perhaps I left the commit for that elsewhere.
Yeah, the two js entries looked useless, that's why I had commented them out.
Updated by mfriedrich on 2011-04-27 16:41:46 +00:00
i've tested that (i think enabling by default might be possible). but it is somehow broken on a 1600x900 resolution. see the picture alone, it will be cut within the frameset.
browser is ff 3.6.16 kubuntu 10.10
can you please verify the error on the html an fix that accordingly?
Updated by mjbrooks on 2011-04-27 23:49:15 +00:00
Enabled by default?! That's a lot more than I was expecting, but I'm glad that the idea is liked that much.
I'm running Kubuntu 10.10 at 1600x1200 and I don't have the issue, but I think I can see what the issue is and just pushed up b22fdf5 to mbrooks/cgifix that prevents the cell wrap. Please give that change a try and tell me if that corrects it on your end. If not I'll give it more attention tonight.
Updated by mfriedrich on 2011-04-28 09:55:59 +00:00
i'm not back officially, just had a creative moment while chilling on the couch ;-)
1 thing further - i had no core running when calling the interface. using the tac header now remains with a big fat "Whooops!" instead of the icinga logo.
regarding the wrapped stuff - yes that works, but the height is not calculated properly. this seems to be a fixed format which doesn't fit my resolution. so the tac_header isn't aware of the frame height given to it?
Updated by mjbrooks on 2011-04-28 11:09:30 +00:00
Thanks for the feedback.
The "Whoops!" is the default error that is driven from tac.cgi not being able to load. I'll see what I can come up with to improve on that.
The tac_header is flexible adjusting along the horizontal, but the frame height is fixed in html/index.html.in. Ricardo reduced my original by 2px, but that doesn't account for the amount of the discrepancy you're seeing.
What I do think I see, though perhaps it's just my eyes since I'm already a few hours beyond proper sleep time, is that you have a few px more padding in the cells and the fonts appear like they are also bigger than they should be. I'm attaching what I have at 1600x for a comparison. Perhaps this is an issue with tacheader.css not loading for you? Out of curiosity, are you seeing the same thing if you load it in the KDE browser Konqueror?
I'll look into it more tomorrow... I'm off to sleep for now.
Updated by mfriedrich on 2011-05-02 16:12:03 +00:00
well there are 4 different error locations, which would need to be adapted on the print_error() function. so for the first attempt i would leave that as it is.
as spoken on irc, probably the default browser font size has been changed by a zoom-in. let#s see how users react on that.
i do consider that a new default header, and if there aren't any other thoughts against, i'd like to set this issue to resolved?
Updated by mfriedrich on 2011-05-02 16:43:30 +00:00
ok. then the final question - interested in joining team icinga, especially on classicui/cgi driven development and supporting ricardo ? :-)
if yes, drop me a short application letter via mail, i'll forward.