[dev.icinga.com #1633] cmd.cgi is parameter order dependant #649

Closed
icinga-migration opened this Issue Jun 9, 2011 · 6 comments

Projects

None yet

1 participant

@icinga-migration
Member

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1633

Created by insom on 2011-06-09 19:58:56 +00:00

Assignee: (none)
Status: Resolved (closed on 2011-07-12 06:34:42 +00:00)
Target Version: 1.5
Last Update: 2014-12-08 09:32:32 +00:00 (in Redmine)


Hi,

cmd.cgi commands which require a `host` and a `service` parameter require that the service immediately follow the host parameter. This was introduced in d4789ab, along with multiple checkboxes (which are super!).

iWeb call cmd.cgi from Python scripts, but Python dictionaries are not ordered. We run a patch against 1.4.0 which allows one to merge `host` and `service` into one new parameter called `hostservice` - separating the two by a caret.

I'll be sending along a patch of my implementation. I don't know that it's perfect (for one thing, you can't use caret in service or host names any more), but perhaps it's a starting point.

Aaron

Attachments

Changesets

2011-06-15 21:55:57 +00:00 by ricardo b6fd633

Added ability to combine host and service in one CGI parameter (Aaron Brady) #1633

refs: #1633
refs: #1120
refs: #1644

* added parameter hostservice to cmd.cgi parameter
* fixed dropdown, causing error when not in status list of status.cgi
* changed dropdown from get to post, hopefully ollowing more
  hosts and services to be sent.
* added missing Changlogentry for #1120
Member

Updated by insom on 2011-06-09 20:06:45 +00:00

  • File added 0001-Add-hostservice-CGI-parameter.patch

This patch adds the `hostservice` parameter, which is position independent.

Member

Updated by mfriedrich on 2011-06-15 16:49:56 +00:00

  • Status changed from New to Feedback
  • Target Version changed from 1.4.1 to 1.5

this is a nice feature enhancement, thanks - targetted for 1.5 though.

Member

Updated by ricardo on 2011-06-16 09:26:03 +00:00

  • Done % changed from 0 to 100

please test in "test/cgis"

Member

Updated by mfriedrich on 2011-06-24 10:30:08 +00:00

  • Tracker changed from Bug to Feature
  • Assigned to deleted insom
Member

Updated by mfriedrich on 2011-07-12 06:34:42 +00:00

  • Status changed from Feedback to Resolved
Member

Updated by mfriedrich on 2014-12-08 09:32:32 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 53 to Classic UI
@icinga-migration icinga-migration added this to the 1.5 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment