Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #1843] host and service names are not allowed to have a '+' included #722

Closed
icinga-migration opened this Issue Aug 24, 2011 · 11 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

icinga-migration commented Aug 24, 2011

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1843

Created by ricardo on 2011-08-24 19:52:01 +00:00

Assignee: ricardo
Status: Resolved (closed on 2013-04-30 20:38:08 +00:00)
Target Version: 1.9
Last Update: 2014-12-08 09:32:45 +00:00 (in Redmine)

Icinga Version: 1.8.4
OS Version: any

Because '+' is treated as whitespace.

When submitted data gets decoded every '+' turns into a whitespace.

Changesets

2011-09-06 20:31:52 +00:00 by ricardo 82ec55d

classic-ui: fixed host and service names are not allowed to have a '+' included #1843

refs: #1843

reverted code I added before and now '+' gets converted in the right stage.

2013-04-30 08:13:50 +00:00 by ricardo c4fff10

classic-ui: fixed host and service names are not allowed to have a '+' included #1843

refs: #1843

fixed again, broke with a commit in january this year.

whatthecommit: We should delete this crap before shipping.

2013-04-30 08:58:31 +00:00 by ricardo 988b80f

classic-ui: fixed host and service names are not allowed to have a '+' included #1843

refs: #1843

fixed again, broke with a commit in january this year.

whatthecommit: We should delete this crap before shipping.

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Sep 4, 2011

Updated by mfriedrich on 2011-09-04 18:05:07 +00:00

this is intended, as every whitespace gets replaced with '+' in cgiutils.c:url_encode.

the main problem is, that e.g. the urls in status.cgi are not created properly.

device-fw+vpn

sourcing from url_encode ...

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Sep 6, 2011

Updated by ricardo on 2011-09-06 20:59:07 +00:00

  • Status changed from New to Feedback
  • Assigned to set to ricardo

applied in current "test/cgi".

please test, test, test as usual!

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Sep 7, 2011

Updated by mfriedrich on 2011-09-07 05:11:24 +00:00

i'll check it when i'm in nuremberg @NETWAYS

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Sep 8, 2011

Updated by mfriedrich on 2011-09-08 14:42:44 +00:00

  • Target Version changed from 1.6 to 1.5.1
@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Sep 8, 2011

Updated by mfriedrich on 2011-09-08 15:03:13 +00:00

  • Done % changed from 0 to 100

i've now tested and verified that ok. evrything affected turns out to be working normal, so i'll consider it for an 1.5.1 asap.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Sep 12, 2011

Updated by mfriedrich on 2011-09-12 13:39:35 +00:00

  • Status changed from Feedback to Resolved
@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 30, 2013

Updated by ricardo on 2013-04-30 08:27:30 +00:00

  • Status changed from Resolved to 7
  • Target Version changed from 1.5.1 to 1.9
  • Done % changed from 100 to 90
  • Icinga Version set to 1
  • OS Version set to all
  • (unknown custom field) set to all

Hi,

just found out, thanks to Rune, this was fixed but broke within another commit again.

now it's workin again. promise.

fixed in current 'rbartels/cgi', ready for cherry-pick

I consider this safe to get merged for 1.9

Testers are welcome :-)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 30, 2013

Updated by mfriedrich on 2013-04-30 08:57:23 +00:00

rbartels/next is not clean - there's a commit from the html cleanup. i'll cherry-pick instead.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 30, 2013

Updated by ricardo on 2013-04-30 09:38:03 +00:00

yep, this would be great.

i know, I want to keep 'rbartels/next' for after the release. it contains all the gcc cleanups.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 30, 2013

Updated by mfriedrich on 2013-04-30 20:38:08 +00:00

  • Status changed from 7 to Resolved
  • Done % changed from 90 to 100
@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:32:45 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category set to Classic UI
  • OS Version set to any

@icinga-migration icinga-migration added this to the 1.9 milestone Jan 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.