[dev.icinga.com #2292] Compatibility problems on Solaris 10 #856

Closed
icinga-migration opened this Issue Jan 29, 2012 · 16 comments

Projects

None yet

1 participant

@icinga-migration
Member

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2292

Created by crfriend on 2012-01-29 14:12:34 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2012-04-19 14:49:52 +00:00)
Target Version: 1.7
Last Update: 2012-04-19 14:49:52 +00:00 (in Redmine)


When building Icinga 1.6.1 on Solaris 10 (SPARC) with gcc 2.95.3 I ran into several problems with declarations, and null-pointer dereferencing. Attached are five patches which addressed the problems.

Attachments

Changesets

2012-02-05 09:00:11 +00:00 by Tommi 96d9c51

idoutils: apply idomod patch contributed in #2292 for gcc2.95 compatibility
refs #2292

2012-02-05 11:35:16 +00:00 by mfriedrich ee2fe6b

core: apply patch from #2292

refs #2292

2012-04-03 08:48:05 +00:00 by mfriedrich 7e7f5d8

final fix compatibility problems on solaris 10 (Carl R. Friend) #2292

refs #2292

2012-04-08 18:17:04 +00:00 by Tommi f5b780b

idoutils: add remaining patch to ido2db #2292
refs #2292

Relations:

@icinga-migration
Member

Updated by crfriend on 2012-01-29 14:17:31 +00:00

  • File added patch-ido2db.c

There should be five attachments, patch-(checks|utils|extinfo|idomod|ido2db).c containing fixes to each of those source files. The patches for checks.c and utils.c correct a problem with an undefined variable "n_a" that happens with the embedded perl interpreter enabled. The ones for extinfo.c and idomod.c move declarations to the beginning of functions to correct compilation errors on the old version of gcc. The changes to ido2db correct null-pointer dereferencing and compilation errors when deep debugging is turned on.

@icinga-migration
Member

Updated by crfriend on 2012-01-29 14:19:13 +00:00

  • File added patch-utils.c
@icinga-migration
Member

Updated by crfriend on 2012-01-29 14:19:43 +00:00

  • File added patch-extinfo.c
@icinga-migration
Member

Updated by crfriend on 2012-01-29 14:20:44 +00:00

  • File added patch-idomod.c
@icinga-migration
Member

Updated by crfriend on 2012-01-29 14:45:59 +00:00

  • File added 0001-Feature-2292-Compatibility-patches.patch
@icinga-migration
Member

Updated by Tommi on 2012-01-29 16:39:15 +00:00

Thanks! I will check this tommorow with suncc.
BTW:You dont need this old gcc, you can use an actual SunStudioExpress as well (after applying some additional patches :-)))
Thomas

@icinga-migration
Member

Updated by mfriedrich on 2012-01-29 19:01:17 +00:00

see icinga-users mailinglist for previous discussions.

thanks for the patches, should be put by their respective git branches (cgi, core, ido) and not fully applied into one branch.

@icinga-migration
Member

Updated by mfriedrich on 2012-01-29 19:01:24 +00:00

  • Target Version set to 1.7
@icinga-migration
Member

Updated by crfriend on 2012-01-29 19:27:22 +00:00

dnsmichi wrote:

thanks for the patches, should be put by their respective git branches (cgi, core, ido) and not fully applied into one branch.

You're most welcome, and I shall bear that in mind. Thanks.

@icinga-migration
Member

Updated by mfriedrich on 2012-01-30 08:04:23 +00:00

that was just an update for the guy taking your patches then (if it won't be me). that's why i was insisting on seperated patches, to allow their applying onto the seperated dev and test branches. on release, they'll get merged together.

@icinga-migration
Member

Updated by Tommi on 2012-02-05 10:10:06 +00:00

  • Category set to Installation
  • Status changed from New to Assigned
  • Assigned to set to ricardo
  • Done % changed from 0 to 20

patch for idomod added
patch for ido2db not added, because logging patches from #2271 should do this more in general. other patches should be checked from core team.for solaris related issues see also #1772 and #1253

@icinga-migration
Member

Updated by mfriedrich on 2012-02-05 11:40:26 +00:00

core is added, just some minor addins if compiled with embedded perl.

@icinga-migration
Member

Updated by mfriedrich on 2012-04-03 08:52:07 +00:00

  • Status changed from Assigned to Feedback
  • Assigned to changed from ricardo to mfriedrich
  • Done % changed from 20 to 100

last one is now in dev/cgis waiting for the merge upstream.

@icinga-migration
Member

Updated by Tommi on 2012-04-09 08:58:49 +00:00

added changes from patch-ido2db.c which not has been applied before to ido2db in changeset f5b780b

@icinga-migration
Member

Updated by mfriedrich on 2012-04-19 14:49:47 +00:00

thanks for the final fix, i'll resolve for now. full merge is to be done.

@icinga-migration
Member

Updated by mfriedrich on 2012-04-19 14:49:52 +00:00

  • Status changed from Feedback to Resolved
@icinga-migration icinga-migration added this to the 1.7 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment