Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #2558] warn users to read Changelog after install #952

Closed
icinga-migration opened this issue Apr 26, 2012 · 8 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Apr 26, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2558

Created by mfriedrich on 2012-04-26 12:14:29 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2012-04-30 16:08:38 +00:00)
Target Version: 1.7
Last Update: 2012-04-30 16:08:38 +00:00 (in Redmine)


as now happened with the idomod change, the default make install routines should remark that as well.

Changesets

2012-04-26 12:38:17 +00:00 by mfriedrich fb2a14e

warn users after make install-init about idomod changes

refs #2558
refs #524
refs #2346

2012-04-26 12:41:23 +00:00 by mfriedrich 6f70d2b

warn users to read Changelog after install #2558

refs #2558

2012-04-27 17:00:13 +00:00 by mfriedrich 453ed8e

add a check to nebmod loader if 'idomod.o' should be loaded, now only warn

refs #2558

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 26, 2012

Updated by mfriedrich on 2012-04-26 12:37:50 +00:00

example on rhel

*** IDOUtils installed ***

!!! ATTENTION !!!
        idomod.o was renamed to idomod.so, module extension is now .so
        idomod.so will now be installed to /usr/lib64 
!!! ATTENTION !!!

Please check Changelog - CHANGES for more information!
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 26, 2012

Updated by mfriedrich on 2012-04-26 12:43:12 +00:00

*** Main program, CGIs and HTML files installed ***

You can continue with installing Icinga as follows (type 'make'
without any arguments for a list of all possible options):

  make install-init
     - This installs the init script in /etc/init.d

  make install-commandmode
     - This installs and configures permissions on the
       directory for holding the external command file

  make install-eventhandlers
     - This installs the sample eventhandlers in /usr/lib/nagios/plugins/eventhandlers

  make install-idoutils
     - This installs the database addon IDOUtils into the
       destination directory

  make install-config
     - This installs sample config files in /etc/icinga

  make install-webconf
     - This installs the Apache config file for the web interface


*** Make sure to check Changelog for introduced changes! ***
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 26, 2012

Updated by Tommi on 2012-04-26 19:50:03 +00:00

I would like to vote to rename or drop of the existing idomod.o, after 2 times i ran into trouble while i forgot to remove the broker entry from icinga.cfg or modules dir and therefore had to old idomod still activ. This resultes in very nice effects. When renaming/dropping a clear errormessage appears, if the user forgot to change his configs and we can help immediate

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 26, 2012

Updated by mfriedrich on 2012-04-26 20:28:07 +00:00

rm'ing something (as source install) where i don't exactly where it was installed before, is dangerous. i had that in mind, but source is something for users and their attention imho - i don't want to be blamed when the rm does something wrong.

and it will not work for packages - it will try to rm something in buildroot which is not there.

i'd rather let the users paste their log output in case of problems. as well as the docs entry on upgrades. as well as already sent - a note to the mailinglists.

last resort will be a core check when parsing the config and trying to load the neb module - if the name matches idomod.o spit a warning to syslog.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 26, 2012

Updated by mfriedrich on 2012-04-26 20:35:01 +00:00

base/nebmods.c

int neb_load_module(nebmodule *mod) {

strcmp or strstr on the mod->filename, bailing out if "idomod.o"

thoughts?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 27, 2012

Updated by mfriedrich on 2012-04-27 16:50:20 +00:00

a strstr is possible.

given that idomod does not export its version, nor a function is there as well, we can't really use dlsym() call on the module in order to detect the version used - you could inject the logging somehow, but that's performance decreasement for nothing.

# nm /usr/lib64/idomod.so | less
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 27, 2012

Updated by mfriedrich on 2012-04-27 16:56:39 +00:00

  • Done % changed from 0 to 50

    ls -la /usr/bin/idomod.o

    -rwxrwxr-- 1 nagios nagios 153491 Mar 14 22:33 /usr/bin/idomod.o

    icinga-dev /etc/icinga/modules # vim idoutils.cfg

    define module{
    module_name idomod1
    module_type neb
    #path /usr/lib/idomod.so
    path /usr/bin/idomod.o
    args config_file=/etc/icinga/idomod.cfg
    }

    service icinga restart

    Running configuration check...OK
    Stopping icinga: .Stopping icinga done.
    Starting icinga: Starting icinga done.

    Apr 27 18:55:15 icinga-dev icinga: Icinga 1.7.0-dev starting... (PID=2713)
    Apr 27 18:55:15 icinga-dev icinga: Local time is Fri Apr 27 18:55:15 CEST 2012
    Apr 27 18:55:15 icinga-dev icinga: LOG VERSION: 2.0
    Apr 27 18:55:15 icinga-dev icinga: Error: trying to load module '/usr/bin/idomod.o' which has been deprecated! Check Changelog and upgrade docs!
    Apr 27 18:55:15 icinga-dev icinga: idomod: IDOMOD 1.6.1 (12-02-2011) Copyright(c) 2005-2008 Ethan Galstad, Copyright(c) 2009-2011 Icinga Development Team (https://www.icinga.org)
    Apr 27 18:55:15 icinga-dev ido2db: Client connected, data available.

question remains if the loader should bail out entirely?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 30, 2012

Updated by mfriedrich on 2012-04-30 16:08:38 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 50 to 100

this is fixed with #2569 and #2570

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.