This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #3578] Combined customvariable restriction has no effect #1012

Closed
icinga-migration opened this Issue Jan 28, 2013 · 9 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

icinga-migration commented Jan 28, 2013

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3578

Created by ossmon on 2013-01-28 14:06:42 +00:00

Assignee: mfrosch
Status: Resolved (closed on 2013-04-26 09:58:18 +00:00)
Target Version: 1.9
Last Update: 2013-04-26 09:58:18 +00:00 (in Redmine)

Icinga Version: 1.8.4
Icinga Web Version: 1.8.1
IDO Version: 1.8.4
OS Version: RHEL 6.1
DB Type: MySQL
DB Version: 5.1.61
Browser Version: Firefox 11

We're using combined customvariable restrictions within our user/group management.
Each host/service has several customvars, defining which team wants to see the object.

Example:

host/service definition:
-----------------------
    host: Some-DB-Server
    _TEAM1  YES
    _TEAM2  YES

    service: Database
    _TEAM1  YES

    service: Filesystems
    _TEAM2  YES



customvariable restrictions
---------------------------
  for Database-Team:
    Variable    Value       Affects
    TEAM1       YES      host
    TEAM1       YES      service

  for Filesystem-Team:
    Variable    Value       Affects
    TEAM2       YES      host
    TEAM2       YES      service

Correct effect in icinga-web/v1.7.2:

  • both Teams get the host "Some-DB-Server"
  • DB-Team (Team1) sees the Database service, but not the Filesystems
  • FS-Team (Team2) sees the Filesystems service, but not the Database

Erroneous effect in icinga-web/v1.8.1:

  • both Teams get the host "Some-DB-Server"
  • both Teams get Database AND Filesystems services

Some more thoughts:
The problem seems to be somewhere in the combination of host and service restrictions.
A single host restriction OR a single service restriction is working well. The described effect occurs only while using both restrictions together.

Attachments

Changesets

2013-04-25 13:04:10 +00:00 by mfrosch 9dc7513

Redesign CustomVariableExtender for new credential system

The WHERE statements are now aggregated correctly to match
the key/values exactly.

fixes #3578
refs #3715

2013-04-26 09:54:15 +00:00 by mfrosch 4e7c0f7

Redesign CustomVariableExtender for new credential system

The WHERE statements are now aggregated correctly to match
the key/values exactly.

fixes #3578
refs #3715

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Feb 5, 2013

Updated by ossmon on 2013-02-05 10:38:52 +00:00

Hi dnsmichi,
i make a test with the actual git version you specified in #3625
Our problem is not resolved.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Feb 12, 2013

Updated by ossmon on 2013-02-12 21:12:30 +00:00

Any News to this Issue. We would to go to 1.8.2 but wie cannot... :-(

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Feb 22, 2013

Updated by mfrosch on 2013-02-22 15:20:49 +00:00

  • Category set to Authorization
  • Status changed from New to Assigned
  • Assigned to set to mfrosch
  • Target Version set to 1.9

This should be fixed with #3715

But the fix will have to delayed until 1.9.0

Sorry :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 11, 2013

Updated by mfriedrich on 2013-04-11 11:34:34 +00:00

is this resolved for 1.9?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 25, 2013

Updated by mfrosch on 2013-04-25 13:08:11 +00:00

  • Done % changed from 0 to 80

I think I found the problem with this and solved it by rewriting the CustomVariableExtender.

Pushed to feature/credentials-3715

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 25, 2013

Updated by mfrosch on 2013-04-25 13:09:50 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 80 to 100

Applied in changeset 9dc7513.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 25, 2013

Updated by ossmon on 2013-04-25 13:57:22 +00:00

  • File added HostStatusBadServiceNb.JPG

Hi,
i've tested the branch from Markus (Comment "Removed NotificationCustomVariableExtender").

It's very better ! Congratulation !

But in the Host View, there is still one problem.
Im my example, the user should see the service with OK, but not the service with CRITICAL

HostStatusBadServiceNb.JPG

Perhaps problem with the issue #3988

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 26, 2013

Updated by mfrosch on 2013-04-26 09:57:07 +00:00

  • Status changed from Resolved to Assigned
  • Done % changed from 100 to 80

Forgot the Legacy stuff...

@icinga-migration

This comment has been minimized.

Copy link
Member Author

icinga-migration commented Apr 26, 2013

Updated by mfrosch on 2013-04-26 09:58:18 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 80 to 100

Applied in changeset 4e7c0f7.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.